6:16 p.m.
Lukáš Fryč created RF-12248:
-------------------------------
Summary: CDK: Auto-casting #{component} inside the encodeBegin / encodeEnd
methods
Key: RF-12248
URL: https://issues.jboss.org/browse/RF-12248
Project: RichFaces
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:24 p.m.
[
https://issues.jboss.org/browse/RF-12248?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč updated RF-12248:
----------------------------
Description:
When using
{code}#{component}{code}
expression in templates.
It results into using
{code}UIComponent component{code}
which needs to be casted explicitly.
----
E.g.: {{castComponent}} method used in
[{{alert.template.xml}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/templates/org/richfaces/bootstrap/alert.template.xml#L15]
and defined in
[{{AlertRendererBase}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/java/org/richfaces/bootstrap/renderkit/AlertRendererBase.java#L44]
CDK: Auto-casting #{component} inside the encodeBegin / encodeEnd
methods
-------------------------------------------------------------------------
Key: RF-12248
URL: https://issues.jboss.org/browse/RF-12248
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
When using
{code}#{component}{code}
expression in templates.
It results into using
{code}UIComponent component{code}
which needs to be casted explicitly.
----
E.g.: {{castComponent}} method used in
[{{alert.template.xml}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/templates/org/richfaces/bootstrap/alert.template.xml#L15]
and defined in
[{{AlertRendererBase}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/java/org/richfaces/bootstrap/renderkit/AlertRendererBase.java#L44]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:24 p.m.
[
https://issues.jboss.org/browse/RF-12248?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč updated RF-12248:
----------------------------
Description:
When using
{code}#{component}{code}
expression in templates,
it results into using
{code}UIComponent component{code}
which needs to be casted explicitly.
----
E.g.: {{castComponent}} method used in
[{{alert.template.xml}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/templates/org/richfaces/bootstrap/alert.template.xml#L15]
and defined in
[{{AlertRendererBase}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/java/org/richfaces/bootstrap/renderkit/AlertRendererBase.java#L44]
was:
When using
{code}#{component}{code}
expression in templates.
It results into using
{code}UIComponent component{code}
which needs to be casted explicitly.
----
E.g.: {{castComponent}} method used in
[{{alert.template.xml}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/templates/org/richfaces/bootstrap/alert.template.xml#L15]
and defined in
[{{AlertRendererBase}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/java/org/richfaces/bootstrap/renderkit/AlertRendererBase.java#L44]
CDK: Auto-casting #{component} inside the encodeBegin / encodeEnd
methods
-------------------------------------------------------------------------
Key: RF-12248
URL: https://issues.jboss.org/browse/RF-12248
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
When using
{code}#{component}{code}
expression in templates,
it results into using
{code}UIComponent component{code}
which needs to be casted explicitly.
----
E.g.: {{castComponent}} method used in
[{{alert.template.xml}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/templates/org/richfaces/bootstrap/alert.template.xml#L15]
and defined in
[{{AlertRendererBase}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/java/org/richfaces/bootstrap/renderkit/AlertRendererBase.java#L44]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:30 p.m.
[
https://issues.jboss.org/browse/RF-12248?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-12248:
---------------------------------
I would suggest to cast the {{component}} expression automatically at the start of
{{encodeBegin}} and {{encodeEnd}}:
{code:java}
@Override
public void encodeBegin(FacesContext facesContext, UIComponent uiComponent)
throws IOException
{
AbstractAlert component = (org.richfaces.bootstrap.component.AbstractAlert)
uiComponent;
}
{code}
----
The problem is we don't know the type of {{component}} expression in renderer
template.
We can add it to the interface:
{code:xml}
<cdk:componentInfo type="org.richfaces.bootstrap.component.AbstractAlert"
/>
{code}
When provided, it will be used.
CDK: Auto-casting #{component} inside the encodeBegin / encodeEnd
methods
-------------------------------------------------------------------------
Key: RF-12248
URL: https://issues.jboss.org/browse/RF-12248
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
When using
{code}#{component}{code}
expression in templates,
it results into using
{code}UIComponent component{code}
which needs to be casted explicitly.
----
E.g.: {{castComponent}} method used in
[{{alert.template.xml}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/templates/org/richfaces/bootstrap/alert.template.xml#L15]
and defined in
[{{AlertRendererBase}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/java/org/richfaces/bootstrap/renderkit/AlertRendererBase.java#L44]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:29 a.m.
[
https://issues.jboss.org/browse/RF-12248?page=com.atlassian.jira.plugin.s...
]
Brian Leathem commented on RF-12248:
------------------------------------
Can we leverage RF-11668 here? Do the cast once in the template, and use that throughout
the renderer?
CDK: Auto-casting #{component} inside the encodeBegin / encodeEnd
methods
-------------------------------------------------------------------------
Key: RF-12248
URL: https://issues.jboss.org/browse/RF-12248
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
When using
{code}#{component}{code}
expression in templates,
it results into using
{code}UIComponent component{code}
which needs to be casted explicitly.
----
E.g.: {{castComponent}} method used in
[{{alert.template.xml}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/templates/org/richfaces/bootstrap/alert.template.xml#L15]
and defined in
[{{AlertRendererBase}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/java/org/richfaces/bootstrap/renderkit/AlertRendererBase.java#L44]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:17 p.m.
[
https://issues.jboss.org/browse/RF-12248?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč updated RF-12248:
----------------------------
Fix Version/s: 4.3.0.Milestone1
This one should be investigated before RF-12195 since it can avoid the need for cdk:object
scoping.
CDK: Auto-casting #{component} inside the encodeBegin / encodeEnd
methods
-------------------------------------------------------------------------
Key: RF-12248
URL: https://issues.jboss.org/browse/RF-12248
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Fix For: 4.3.0.Milestone1
When using
{code}#{component}{code}
expression in templates,
it results into using
{code}UIComponent component{code}
which needs to be casted explicitly.
----
E.g.: {{castComponent}} method used in
[{{alert.template.xml}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/templates/org/richfaces/bootstrap/alert.template.xml#L15]
and defined in
[{{AlertRendererBase}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/java/org/richfaces/bootstrap/renderkit/AlertRendererBase.java#L44]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:09 p.m.
[
https://issues.jboss.org/browse/RF-12248?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč commented on RF-12248:
---------------------------------
AGREED: we can define the cast type in the interface, it should use a common parent type
for all components that it applies to and default to UIComponent (bleathem, 17:01:50)
CDK: Auto-casting #{component} inside the encodeBegin / encodeEnd
methods
-------------------------------------------------------------------------
Key: RF-12248
URL: https://issues.jboss.org/browse/RF-12248
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Fix For: 4.3.0.Milestone1
When using
{code}#{component}{code}
expression in templates,
it results into using
{code}UIComponent component{code}
which needs to be casted explicitly.
----
E.g.: {{castComponent}} method used in
[{{alert.template.xml}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/templates/org/richfaces/bootstrap/alert.template.xml#L15]
and defined in
[{{AlertRendererBase}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/java/org/richfaces/bootstrap/renderkit/AlertRendererBase.java#L44]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:13 p.m.
[
https://issues.jboss.org/browse/RF-12248?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč edited comment on RF-12248 at 5/16/12 2:12 PM:
----------------------------------------------------------
AGREED: we can define the cast type in the interface, it should use a common parent type
for all components that it applies to and default to UIComponent (bleathem, 17:01:50)
http://transcripts.jboss.org/meeting/irc.freenode.org/richfaces/2012/rich...
was (Author: lfryc):
AGREED: we can define the cast type in the interface, it should use a common parent
type for all components that it applies to and default to UIComponent (bleathem,
17:01:50)
CDK: Auto-casting #{component} inside the encodeBegin / encodeEnd
methods
-------------------------------------------------------------------------
Key: RF-12248
URL: https://issues.jboss.org/browse/RF-12248
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Fix For: 4.3.0.Milestone1
When using
{code}#{component}{code}
expression in templates,
it results into using
{code}UIComponent component{code}
which needs to be casted explicitly.
----
E.g.: {{castComponent}} method used in
[{{alert.template.xml}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/templates/org/richfaces/bootstrap/alert.template.xml#L15]
and defined in
[{{AlertRendererBase}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/java/org/richfaces/bootstrap/renderkit/AlertRendererBase.java#L44]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:56 p.m.
[
https://issues.jboss.org/browse/RF-12248?page=com.atlassian.jira.plugin.s...
]
Brian Leathem commented on RF-12248:
------------------------------------
Note: we decided to go with the name _component-base-class_, as in:
{code}
<cc:interface>
<cdk:class>org.richfaces.renderkit.TestComponentRenderer</cdk:class>
<cdk:superclass>org.richfaces.renderkit.TestComponentRendererBase</cdk:superclass>
<cdk:component-family>org.richfaces.TestComponentFamily</cdk:component-family>
<cdk:renderer-type>org.richfaces.TestComponentRenderer</cdk:renderer-type>
<cdk:component-base-class>org.richfaces.component.TestComponent</cdk:component-base-class>
</cc:interface>
{code}
CDK: Auto-casting #{component} inside the encodeBegin / encodeEnd
methods
-------------------------------------------------------------------------
Key: RF-12248
URL: https://issues.jboss.org/browse/RF-12248
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Labels: xp
Fix For: 4.3.0.Milestone1
When using
{code}#{component}{code}
expression in templates,
it results into using
{code}UIComponent component{code}
which needs to be casted explicitly.
----
E.g.: {{castComponent}} method used in
[{{alert.template.xml}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/templates/org/richfaces/bootstrap/alert.template.xml#L15]
and defined in
[{{AlertRendererBase}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/java/org/richfaces/bootstrap/renderkit/AlertRendererBase.java#L44]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:01 a.m.
[
https://issues.jboss.org/browse/RF-12248?page=com.atlassian.jira.plugin.s...
]
Brian Leathem resolved RF-12248.
--------------------------------
Assignee: Brian Leathem
Resolution: Done
CDK: Auto-casting #{component} inside the encodeBegin / encodeEnd
methods
-------------------------------------------------------------------------
Key: RF-12248
URL: https://issues.jboss.org/browse/RF-12248
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Assignee: Brian Leathem
Labels: xp
Fix For: 4.3.0.Milestone1
When using
{code}#{component}{code}
expression in templates,
it results into using
{code}UIComponent component{code}
which needs to be casted explicitly.
----
E.g.: {{castComponent}} method used in
[{{alert.template.xml}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/templates/org/richfaces/bootstrap/alert.template.xml#L15]
and defined in
[{{AlertRendererBase}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/java/org/richfaces/bootstrap/renderkit/AlertRendererBase.java#L44]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:29 p.m.
[
https://issues.jboss.org/browse/RF-12248?page=com.atlassian.jira.plugin.s...
]
Juraj Húska closed RF-12248.
----------------------------
CDK: Auto-casting #{component} inside the encodeBegin / encodeEnd
methods
-------------------------------------------------------------------------
Key: RF-12248
URL: https://issues.jboss.org/browse/RF-12248
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: cdk
Affects Versions: 4.2.0.Final
Reporter: Paul Dijou
Assignee: Brian Leathem
Labels: xp
Fix For: 4.3.0.Milestone1
When using
{code}#{component}{code}
expression in templates,
it results into using
{code}UIComponent component{code}
which needs to be casted explicitly.
----
E.g.: {{castComponent}} method used in
[{{alert.template.xml}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/templates/org/richfaces/bootstrap/alert.template.xml#L15]
and defined in
[{{AlertRendererBase}}|https://github.com/richfaces/sandbox/blob/bbdaa1ee7bfde58f87fa2d909cc87cb726822919/bootstrap/ui/src/main/java/org/richfaces/bootstrap/renderkit/AlertRendererBase.java#L44]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4278
days inactive
4358
days old
richfaces-issues@lists.jboss.org
10 comments
3 participants
participants (3)
-
Brian Leathem (JIRA) -
Juraj Húska (JIRA)
-
Lukáš Fryč (JIRA)