[JBoss JIRA] (TEIID-4883) Teiid Excel Translator should filter blank cells from header row
by Ramesh Reddy (JIRA)
[ https://issues.jboss.org/browse/TEIID-4883?page=com.atlassian.jira.plugin... ]
Ramesh Reddy commented on TEIID-4883:
-------------------------------------
[~dvilaverde] In that case, this is bug. What I see is Teiid is not accounting for blank cells in header, thus using empty column name and considering the next cell as duplicate. I was thinking your usecase is much like
||heading 1||heading 2|| ||heading 3||
|col A1|col A2| |col A3|
|col B1|col B2| |col B3|
Where 3 should not be part of the table. Even this is good usecase.
So, for the bug, we would need to make sure headerCell is not blank, if it is blank then either skip the cell or end the the table creation at that column based on the {{getAllowEmptyCells}} proeprty you created. If you want to submit patch I will review it again.
> Teiid Excel Translator should filter blank cells from header row
> ----------------------------------------------------------------
>
> Key: TEIID-4883
> URL: https://issues.jboss.org/browse/TEIID-4883
> Project: Teiid
> Issue Type: Enhancement
> Components: Misc. Connectors
> Reporter: David Vilaverde
> Assignee: Steven Hawkins
> Priority: Minor
> Fix For: Open To Community
>
> Attachments: fr-demo1-sample-data.xls
>
>
> The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
> The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
> I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951
> If this PR is not going to be accepted, can the methods in the ExcelMetadataProcessor me changed from private to protected so that the processor can be extended easily?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (TEIID-4883) Teiid Excel Translator should filter blank cells from header row
by David Vilaverde (JIRA)
[ https://issues.jboss.org/browse/TEIID-4883?page=com.atlassian.jira.plugin... ]
David Vilaverde commented on TEIID-4883:
----------------------------------------
[~rareddy] The attache has empty cells in rows E through H. Trying to use that attached XLS i'll get an error about duplicate column names. If you highlight rows E through H in MS-Excel and right moust button and choose delete, then save, the error will go away.
> Teiid Excel Translator should filter blank cells from header row
> ----------------------------------------------------------------
>
> Key: TEIID-4883
> URL: https://issues.jboss.org/browse/TEIID-4883
> Project: Teiid
> Issue Type: Enhancement
> Components: Misc. Connectors
> Reporter: David Vilaverde
> Assignee: Steven Hawkins
> Priority: Minor
> Fix For: Open To Community
>
> Attachments: fr-demo1-sample-data.xls
>
>
> The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
> The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
> I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951
> If this PR is not going to be accepted, can the methods in the ExcelMetadataProcessor me changed from private to protected so that the processor can be extended easily?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (TEIID-4883) Teiid Excel Translator should filter blank cells from header row
by Ramesh Reddy (JIRA)
[ https://issues.jboss.org/browse/TEIID-4883?page=com.atlassian.jira.plugin... ]
Ramesh Reddy commented on TEIID-4883:
-------------------------------------
[~dvilaverde] I do not think I understand your intent from your example xls attached. Can you attach one with empty cells?
> Teiid Excel Translator should filter blank cells from header row
> ----------------------------------------------------------------
>
> Key: TEIID-4883
> URL: https://issues.jboss.org/browse/TEIID-4883
> Project: Teiid
> Issue Type: Enhancement
> Components: Misc. Connectors
> Reporter: David Vilaverde
> Assignee: Steven Hawkins
> Priority: Minor
> Fix For: Open To Community
>
> Attachments: fr-demo1-sample-data.xls
>
>
> The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
> The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
> I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951
> If this PR is not going to be accepted, can the methods in the ExcelMetadataProcessor me changed from private to protected so that the processor can be extended easily?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (TEIID-4806) Infinispan DSL Resource Adapter: NullPointerException when Admin user/password not provided
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/TEIID-4806?page=com.atlassian.jira.plugin... ]
RH Bugzilla Integration commented on TEIID-4806:
------------------------------------------------
Van Halbert <vhalbert(a)redhat.com> changed the Status of [bug 1430740|https://bugzilla.redhat.com/show_bug.cgi?id=1430740] from ASSIGNED to MODIFIED
> Infinispan DSL Resource Adapter: NullPointerException when Admin user/password not provided
> -------------------------------------------------------------------------------------------
>
> Key: TEIID-4806
> URL: https://issues.jboss.org/browse/TEIID-4806
> Project: Teiid
> Issue Type: Bug
> Components: JDG Connector
> Affects Versions: 8.12.9.6_3
> Reporter: Jan Stastny
> Assignee: Van Halbert
> Fix For: 9.3, 8.12.x-6.4
>
>
> Infinispan DSL Resource adapter properties AdminUserName and AdminPassword are not defined as required. If they are not configured it results in NullpointerException during metadata load of a vdb which uses the connector.
> Creation of such resource-adapter shouldn't have succeeded, if the properties are required.
> {code:xml}
> <resource-adapter id="jdg-protobuf-customer-report">
> <module slot="main" id="org.jboss.teiid.resource-adapter.infinispan.dsl"/>
> <transaction-support>LocalTransaction</transaction-support>
> <connection-definitions>
> <connection-definition class-name="org.teiid.resource.adapter.infinispan.dsl.InfinispanManagedConnectionFactory" jndi-name="java:/teiid4709-pro-ds" enabled="true" use-java-context="true" pool-name="jdg-protobuf-customer-report">
> <config-property name="MessageDescriptor">
> org.jboss.qe.jdg.remote.protobuf.CustomerReport
> </config-property>
> <config-property name="AuthApplicationRealm">
> ApplicationRealm
> </config-property>
> <config-property name="MessageMarshallers">
> org.jboss.qe.jdg.pojo.CustomerReport:org.jboss.qe.jdg.remote.marshaller.CustomerReportMarshaller
> </config-property>
> <config-property name="AuthUserName">
> teiidUser
> </config-property>
> <config-property name="AuthServerName">
> hostsecured
> </config-property>
> <config-property name="AuthSASLMechanism">
> DIGEST-MD5
> </config-property>
> <config-property name="AuthPassword">
> password
> </config-property>
> <config-property name="Module">
> org.jboss.qe.jdg.pojos
> </config-property>
> <config-property name="RemoteServerList">
> hostname:11323
> </config-property>
> <config-property name="ProtobufDefinitionFile">
> /org/jboss/qe/jdg/remote/protobuf/CustomerReport.proto
> </config-property>
> <config-property name="CacheTypeMap">
> sec-cache:org.jboss.qe.jdg.pojo.CustomerReport;customerId
> </config-property>
> </connection-definition>
> </connection-definitions>
> </resource-adapter>
> {code}
> {code}
> 13:34:21,156 WARN [org.teiid.RUNTIME] (teiid-async-threads - 2) TEIID50036 VDB teiid4709-pro.1 model "Source" metadata failed to load. Reason:java.lang.NullPointerException: org.teiid.translator.TranslatorException: java.lang.NullPointerException
> at org.teiid.resource.adapter.infinispan.dsl.InfinispanConnectionImpl.getCacheContainer(InfinispanConnectionImpl.java:363)
> at org.teiid.resource.adapter.infinispan.dsl.InfinispanConnectionImpl.getDescriptor(InfinispanConnectionImpl.java:189)
> at org.teiid.resource.adapter.infinispan.dsl.InfinispanConnectionImpl.getDescriptor(InfinispanConnectionImpl.java:180)
> at org.teiid.translator.infinispan.dsl.metadata.ProtobufMetadataProcessor.process(ProtobufMetadataProcessor.java:103)
> at org.teiid.translator.infinispan.dsl.metadata.ProtobufMetadataProcessor.process(ProtobufMetadataProcessor.java:77)
> at org.teiid.translator.ExecutionFactory.getMetadata(ExecutionFactory.java:950) [teiid-api-8.12.10.6_3.jar:8.12.10.6_3]
> at org.teiid.query.metadata.NativeMetadataRepository.getMetadata(NativeMetadataRepository.java:96) [teiid-engine-8.12.10.6_3.jar:8.12.10.6_3]
> at org.teiid.query.metadata.NativeMetadataRepository.loadMetadata(NativeMetadataRepository.java:62) [teiid-engine-8.12.10.6_3.jar:8.12.10.6_3]
> at org.teiid.query.metadata.ChainingMetadataRepository.loadMetadata(ChainingMetadataRepository.java:55) [teiid-engine-8.12.10.6_3.jar:8.12.10.6_3]
> at org.teiid.jboss.VDBService$6.run(VDBService.java:395) [teiid-jboss-integration-8.12.10.6_3.jar:8.12.10.6_3]
> at org.teiid.jboss.VDBService$7.run(VDBService.java:446) [teiid-jboss-integration-8.12.10.6_3.jar:8.12.10.6_3]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [rt.jar:1.8.0_111]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [rt.jar:1.8.0_111]
> at java.lang.Thread.run(Thread.java:745) [rt.jar:1.8.0_111]
> at org.jboss.threads.JBossThread.run(JBossThread.java:122)
> Caused by: javax.resource.ResourceException: java.lang.NullPointerException
> at org.teiid.resource.adapter.infinispan.dsl.InfinispanConnectionImpl.createRemoteCache(InfinispanConnectionImpl.java:537)
> at org.teiid.resource.adapter.infinispan.dsl.InfinispanConnectionImpl.createRemoteCacheFromServerList(InfinispanConnectionImpl.java:477)
> at org.teiid.resource.adapter.infinispan.dsl.InfinispanConnectionImpl.createCacheContainer(InfinispanConnectionImpl.java:390)
> at org.teiid.resource.adapter.infinispan.dsl.InfinispanConnectionImpl.getCacheContainer(InfinispanConnectionImpl.java:361)
> ... 14 more
> Caused by: java.lang.NullPointerException
> at org.teiid.resource.adapter.infinispan.dsl.InfinispanConnectionImpl.createRemoteCache(InfinispanConnectionImpl.java:500)
> ... 17 more
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (TEIID-4883) Teiid Excel Translator should filter blank cells from header row
by David Vilaverde (JIRA)
[ https://issues.jboss.org/browse/TEIID-4883?page=com.atlassian.jira.plugin... ]
David Vilaverde updated TEIID-4883:
-----------------------------------
Description:
The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951
If this PR is not going to be accepted, can the methods in the ExcelMetadataProcessor me changed from private to protected so that the processor can be extended easily?
was:
The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951
> Teiid Excel Translator should filter blank cells from header row
> ----------------------------------------------------------------
>
> Key: TEIID-4883
> URL: https://issues.jboss.org/browse/TEIID-4883
> Project: Teiid
> Issue Type: Enhancement
> Components: Misc. Connectors
> Reporter: David Vilaverde
> Assignee: Steven Hawkins
> Priority: Minor
> Fix For: Open To Community
>
> Attachments: fr-demo1-sample-data.xls
>
>
> The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
> The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
> I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951
> If this PR is not going to be accepted, can the methods in the ExcelMetadataProcessor me changed from private to protected so that the processor can be extended easily?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (TEIID-4883) Teiid Excel Translator should filter blank cells from header row
by David Vilaverde (JIRA)
[ https://issues.jboss.org/browse/TEIID-4883?page=com.atlassian.jira.plugin... ]
David Vilaverde updated TEIID-4883:
-----------------------------------
Description:
The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951
was:
The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
> Teiid Excel Translator should filter blank cells from header row
> ----------------------------------------------------------------
>
> Key: TEIID-4883
> URL: https://issues.jboss.org/browse/TEIID-4883
> Project: Teiid
> Issue Type: Enhancement
> Components: Misc. Connectors
> Reporter: David Vilaverde
> Assignee: Steven Hawkins
> Priority: Minor
> Fix For: Open To Community
>
> Attachments: fr-demo1-sample-data.xls
>
>
> The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
> The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
> I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (TEIID-4883) Teiid Excel Translator should filter blank cells from header row
by David Vilaverde (JIRA)
[ https://issues.jboss.org/browse/TEIID-4883?page=com.atlassian.jira.plugin... ]
David Vilaverde commented on TEIID-4883:
----------------------------------------
Fix is in PR https://github.com/teiid/teiid/pull/951 on Github.
> Teiid Excel Translator should filter blank cells from header row
> ----------------------------------------------------------------
>
> Key: TEIID-4883
> URL: https://issues.jboss.org/browse/TEIID-4883
> Project: Teiid
> Issue Type: Enhancement
> Components: Misc. Connectors
> Reporter: David Vilaverde
> Assignee: Steven Hawkins
> Priority: Minor
> Fix For: Open To Community
>
> Attachments: fr-demo1-sample-data.xls
>
>
> The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
> The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (TEIID-4883) Teiid Excel Translator should filter blank cells from header row
by David Vilaverde (JIRA)
[ https://issues.jboss.org/browse/TEIID-4883?page=com.atlassian.jira.plugin... ]
David Vilaverde updated TEIID-4883:
-----------------------------------
Component/s: Misc. Connectors
> Teiid Excel Translator should filter blank cells from header row
> ----------------------------------------------------------------
>
> Key: TEIID-4883
> URL: https://issues.jboss.org/browse/TEIID-4883
> Project: Teiid
> Issue Type: Enhancement
> Components: Misc. Connectors
> Reporter: David Vilaverde
> Assignee: Steven Hawkins
> Priority: Minor
> Fix For: Open To Community
>
> Attachments: fr-demo1-sample-data.xls
>
>
> The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
> The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (TEIID-4883) Teiid Excel Translator should filter blank cells from header row
by David Vilaverde (JIRA)
[ https://issues.jboss.org/browse/TEIID-4883?page=com.atlassian.jira.plugin... ]
David Vilaverde updated TEIID-4883:
-----------------------------------
Fix Version/s: Open To Community
> Teiid Excel Translator should filter blank cells from header row
> ----------------------------------------------------------------
>
> Key: TEIID-4883
> URL: https://issues.jboss.org/browse/TEIID-4883
> Project: Teiid
> Issue Type: Enhancement
> Components: Misc. Connectors
> Reporter: David Vilaverde
> Assignee: Steven Hawkins
> Priority: Minor
> Fix For: Open To Community
>
> Attachments: fr-demo1-sample-data.xls
>
>
> The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
> The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months
[JBoss JIRA] (TEIID-4883) Teiid Excel Translator should filter blank cells from header row
by David Vilaverde (JIRA)
David Vilaverde created TEIID-4883:
--------------------------------------
Summary: Teiid Excel Translator should filter blank cells from header row
Key: TEIID-4883
URL: https://issues.jboss.org/browse/TEIID-4883
Project: Teiid
Issue Type: Enhancement
Reporter: David Vilaverde
Assignee: Steven Hawkins
Priority: Minor
Attachments: fr-demo1-sample-data.xls
The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 6 months