]
Steven Hawkins commented on TEIID-2411:
---------------------------------------
Actually those calls should just be using the getFullName method (which does include the
schema) instead of getName.
Add schema name to metadata validation messages
-----------------------------------------------
Key: TEIID-2411
URL:
https://issues.jboss.org/browse/TEIID-2411
Project: Teiid
Issue Type: Enhancement
Components: Query Engine
Affects Versions: 8.2
Reporter: Paul Lysak
Assignee: Steven Hawkins
Currently metadata validation messages don't contain schema name, so when working
with lot of schemas it may be difficult to find out problematic element. For example, if
table SOME_TABLE has no columns then
org.teiid.query.metadata.MetadataValidator.MinimalMetadata.execute() will log following
error message:
TEIID31071 Invalid table; Table SOME_TABLE has no columns defined
And there's no ability to detect later to which schema problematic table belongs.
I suggest to append schema name - either by simple concatenation in
MetadataValidator.java:
metadataValidator.log(report, model, QueryPlugin.Util.gs(QueryPlugin.Event.TEIID31071,
scmena.getName()+"."+t.getName()));
or by changing message bundle i18n.properties:
TEIID31071=Invalid table; Table {0}.{1} has no columns defined
and providing message parameters in MetadataValidator.java:
metadataValidator.log(report, model, QueryPlugin.Util.gs(QueryPlugin.Event.TEIID31071,
scmena.getName(), t.getName()));
There are also another validation messages in MetadataValidator.java which could be
improved in similar way.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: