[ https://issues.jboss.org/browse/TEIID-2057?page=com.atlassian.jira.plugin... ] Ramesh Reddy commented on TEIID-2057: ------------------------------------- This is by design. There is no use for this text once the metadata is retrieved from it. This will also reduce the foot print of the VDB. This is some discussion to add a admin method given the VDB name and model name, Teiid can expose the metadata by exporting to DDL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIID-2057?page=com.atlassian.jira.plugin... ] Steven Hawkins commented on TEIID-2057: --------------------------------------- I agree with Mark. While we don't want/need the DDL in the memory state, we do want it persisted if we are creating a persistent form of the model. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIID-2057?page=com.atlassian.jira.plugin... ] Ramesh Reddy commented on TEIID-2057: ------------------------------------- started conversation on this at [https://community.jboss.org/thread/200246] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIID-2057?page=com.atlassian.jira.plugin... ] Steven Hawkins commented on TEIID-2057: --------------------------------------- After looking things over more a full parse/save cycle doesn't seem like the right way to go. To disentangle things better, there are several somewhat relate issues we have to address: - vdb saved state needs to be complete. the ddl or other necessary information cannot be ommitted. The simplest approach with the current logic would be to just leave the ddl on the model. We could consider adding an option for dynamic deployment as a zip and allow the ddl text file to be referenced in the zip. - the vdb saved state should not carry over any errors from the runtime state. For this we may want to consider not using the model error mechanism at all for runtime errors. At least for metadata load an error is no longer necessary to track completion. - modifications to the runtime/metadata state need to be made in a thread-safe manner. for example mapped data role names are held by just an ArrayList without synchronization. - we need to differentiate between vdb modifications that require a vdb restart (an operation that we should add) and those that have an immediate effect. At the extreme of fully parsing/re-saving the metadata state of the vdb.xml with each operation there would be no runtime effect. Ramesh, Are the mutative methods on VDBService (such as addDataRole) used? I see the same logic also in the TeiidOperationHandler and both make the problematic calls to save the vdb state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIID-2057?page=com.atlassian.jira.plugin... ] Ramesh Reddy commented on TEIID-2057: ------------------------------------- - The problem with accessing the DDL is not during the deployment time, but once it is deployed. So, I am not sure how adding as archive helps. I agree this keeps the state as provided by the user. But for runtime state metadata is already fully available to the engine. However, we could add a method like "getSchema(vdbname, version, modelName) to the Admin API, that will return the DDL and internally during the parse time or after metadata load save the DDL to a separate file just as metadata cache file and supply to user when they requests through above method. - yes, I see saving runtime errors as bad. Should differentiate between runtime and design/deploy time errors. - All the methods on Admin API that operate on VDB take effect immediately. We do not provide any methods that modify the VDB and leave in state that requires a restart. So, I am not sure which methods you are mentioning that require a restart method. - yes, addDataRole kind methods are used, since we do not have any tooling it is not wired anywhere currently. We did in 7.7 with Console plugin. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira