[ https://issues.jboss.org/browse/TEIID-4572?page=com.atlassian.jira.plugin... ] Amr Ismail commented on TEIID-4572: ----------------------------------- any updates On May 24, 2017 1:28 PM, "Steven Hawkins (JIRA)" <issues(a)jboss.org&gt; wrote: Steven Hawkins <https://issues.jboss.org/secure/ViewProfile.jspa?name=shawkins> *commented* on [image: Enhancement] TEIID-4572 <https://issues.jboss.org/browse/TEIID-4572> Re: Grouping by and faceted search for Solr tranlator <https://issues.jboss.org/browse/TEIID-4572> As mentioned on the original pull request, the SolrQueryExecution changes seem to have issues or need clarification: - There are quite a few checks for a column of type timestamp (in particular findTimestampIndex) - but it doesn't appear that there is a guarantee it will be the correct column. That is you could easily have the gap on one field and group by another timestamp column. - Why is adjustDateFormat needed now, but wasn't needed before? - The this.visitor.isCountStarInUse() logic is only enabled in faceted scenario. It looks like "select count(*) from tbl" won't work as expected. I would like to see unit tests of the execution logic, or perhaps you could provide a docker image of a representative solr instance to aid in testing. [image: Add Comment] <https://issues.jboss.org/browse/TEIID-4572#add-comment> Add Comment <https://issues.jboss.org/browse/TEIID-4572#add-comment> This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) [image: Atlassian logo] -- This message was sent by Atlassian JIRA (v7.2.3#72005)