[JBoss JIRA] (TEIID-2068) Recursion Limit not being processed for XML documents - Possible recursion issue?
4:49 p.m.
Paul Nittel created TEIID-2068:
----------------------------------
Summary: Recursion Limit not being processed for XML documents - Possible
recursion issue?
Key: TEIID-2068
URL: https://issues.jboss.org/browse/TEIID-2068
Project: Teiid
Issue Type: Bug
Components: Query Engine
Environment: SOA-P 5.3 ER3
Reporter: Paul Nittel
Assignee: Steven Hawkins
I ran the E2ERecursiveXmlTextSource test. It involves setting a limit of 3 on the
recursion, and then changing the limit to 4 (where all XML document queries will pass). I
found the limit exception was being thrown regardless of the setting (even up to 10).
I changed the behavior from THROW to RECORD and now the queries do not return (in a timely
manner), leading me to worry that recursion may be the cause, not the limit itself.
Model Project Set and server log will be attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:55 p.m.
[
https://issues.jboss.org/browse/TEIID-2068?page=com.atlassian.jira.plugin...
]
Paul Nittel updated TEIID-2068:
-------------------------------
Description:
I ran the E2ERecursiveXmlTextSource test. It involves setting a limit of 3 on the
recursion, and then changing the limit to 4 (where all XML document queries will pass). I
found the limit exception was being thrown regardless of the setting (even up to 10).
I changed the behavior from THROW to RECORD and now the queries do not return (in a timely
manner), leading me to worry that recursion may be the cause, not the limit itself.
Model Project Set and server log will be attached.
Just looked at the command log and it looks pretty weird. I'd be inclined to start
there. I AM able to successfully query the source (text).
was:
I ran the E2ERecursiveXmlTextSource test. It involves setting a limit of 3 on the
recursion, and then changing the limit to 4 (where all XML document queries will pass). I
found the limit exception was being thrown regardless of the setting (even up to 10).
I changed the behavior from THROW to RECORD and now the queries do not return (in a timely
manner), leading me to worry that recursion may be the cause, not the limit itself.
Model Project Set and server log will be attached.
Recursion Limit not being processed for XML documents - Possible
recursion issue?
---------------------------------------------------------------------------------
Key: TEIID-2068
URL: https://issues.jboss.org/browse/TEIID-2068
Project: Teiid
Issue Type: Bug
Components: Query Engine
Environment: SOA-P 5.3 ER3
Reporter: Paul Nittel
Assignee: Steven Hawkins
Attachments: RecursionLimit_MPS.zip, server.log, teiid-command.log.8
I ran the E2ERecursiveXmlTextSource test. It involves setting a limit of 3 on the
recursion, and then changing the limit to 4 (where all XML document queries will pass). I
found the limit exception was being thrown regardless of the setting (even up to 10).
I changed the behavior from THROW to RECORD and now the queries do not return (in a
timely manner), leading me to worry that recursion may be the cause, not the limit
itself.
Model Project Set and server log will be attached.
Just looked at the command log and it looks pretty weird. I'd be inclined to start
there. I AM able to successfully query the source (text).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:30 p.m.
[
https://issues.jboss.org/browse/TEIID-2068?page=com.atlassian.jira.plugin...
]
Steven Hawkins commented on TEIID-2068:
---------------------------------------
There are several issues here.
1. Is there a valid recursion limit for the test? Since the code and unit tests have not
changed, I would re-verify the test scenario by manually inspecting if the recursion depth
is actually 3.
2. RECORD was never implemented - see https://issues.jboss.org/browse/TEIID-63 back when
were more intent on retiring the XML document model feature we didn't see a need to
add support. I'm not sure exactly what this was supposed to do. I had just assumed
there would be a log entry if the recursion limit was exceeded.
3. If RECORD is set rather than THROW, then it seems like you just keep recusing (related
to 1). I would expect here that the limit is still respected. I believe this is an issue
with the logic in RecuseProgramCondition which could be addressed easily (and a log could
be added to address 2).
The record feature was never implemented. I'm assuming that it means produce a log
Recursion Limit not being processed for XML documents - Possible
recursion issue?
---------------------------------------------------------------------------------
Key: TEIID-2068
URL: https://issues.jboss.org/browse/TEIID-2068
Project: Teiid
Issue Type: Bug
Components: Query Engine
Environment: SOA-P 5.3 ER3
Reporter: Paul Nittel
Assignee: Steven Hawkins
Attachments: RecursionLimit_MPS.zip, server.log, teiid-command.log.8
I ran the E2ERecursiveXmlTextSource test. It involves setting a limit of 3 on the
recursion, and then changing the limit to 4 (where all XML document queries will pass). I
found the limit exception was being thrown regardless of the setting (even up to 10).
I changed the behavior from THROW to RECORD and now the queries do not return (in a
timely manner), leading me to worry that recursion may be the cause, not the limit
itself.
Model Project Set and server log will be attached.
Just looked at the command log and it looks pretty weird. I'd be inclined to start
there. I AM able to successfully query the source (text).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:08 p.m.
[
https://issues.jboss.org/browse/TEIID-2068?page=com.atlassian.jira.plugin...
]
Paul Nittel commented on TEIID-2068:
------------------------------------
RE: #1 above, I can't say that I checked the VDB to see the value 3, but when I
changed it to 10 I did inspect the VDB and the correct value was there.
Recursion Limit not being processed for XML documents - Possible
recursion issue?
---------------------------------------------------------------------------------
Key: TEIID-2068
URL: https://issues.jboss.org/browse/TEIID-2068
Project: Teiid
Issue Type: Bug
Components: Query Engine
Environment: SOA-P 5.3 ER3
Reporter: Paul Nittel
Assignee: Steven Hawkins
Attachments: RecursionLimit_MPS.zip, server.log, teiid-command.log.8
I ran the E2ERecursiveXmlTextSource test. It involves setting a limit of 3 on the
recursion, and then changing the limit to 4 (where all XML document queries will pass). I
found the limit exception was being thrown regardless of the setting (even up to 10).
I changed the behavior from THROW to RECORD and now the queries do not return (in a
timely manner), leading me to worry that recursion may be the cause, not the limit
itself.
Model Project Set and server log will be attached.
Just looked at the command log and it looks pretty weird. I'd be inclined to start
there. I AM able to successfully query the source (text).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:23 p.m.
[
https://issues.jboss.org/browse/TEIID-2068?page=com.atlassian.jira.plugin...
]
Steven Hawkins commented on TEIID-2068:
---------------------------------------
The command log isn't so much troubling as it indicates the need for a staging table
and or a mat view.
What does your last comment mean? If you set the limit to 10 you are getting valid
results back to a depth of 10? Does this contradict the test expectations and/or your
initial description in which you expected only to a depth of 4?
In re-inspecting RecuseProgramCondition, I think that the logic is actually fine. Other
than the record feature not being implemented it looks like you may not have a good set of
test expectations and/or a poorly performing query that gets worse at further recursion
depths.
Recursion Limit not being processed for XML documents - Possible
recursion issue?
---------------------------------------------------------------------------------
Key: TEIID-2068
URL: https://issues.jboss.org/browse/TEIID-2068
Project: Teiid
Issue Type: Bug
Components: Query Engine
Environment: SOA-P 5.3 ER3
Reporter: Paul Nittel
Assignee: Steven Hawkins
Attachments: RecursionLimit_MPS.zip, server.log, teiid-command.log.8
I ran the E2ERecursiveXmlTextSource test. It involves setting a limit of 3 on the
recursion, and then changing the limit to 4 (where all XML document queries will pass). I
found the limit exception was being thrown regardless of the setting (even up to 10).
I changed the behavior from THROW to RECORD and now the queries do not return (in a
timely manner), leading me to worry that recursion may be the cause, not the limit
itself.
Model Project Set and server log will be attached.
Just looked at the command log and it looks pretty weird. I'd be inclined to start
there. I AM able to successfully query the source (text).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:42 p.m.
[
https://issues.jboss.org/browse/TEIID-2068?page=com.atlassian.jira.plugin...
]
Steven Hawkins closed TEIID-2068.
---------------------------------
Recursion Limit not being processed for XML documents - Possible
recursion issue?
---------------------------------------------------------------------------------
Key: TEIID-2068
URL: https://issues.jboss.org/browse/TEIID-2068
Project: Teiid
Issue Type: Bug
Components: Query Engine
Affects Versions: 7.7.1
Environment: SOA-P 5.3 ER3
Reporter: Paul Nittel
Assignee: Steven Hawkins
Attachments: RecursionLimit_MPS.zip, server.log, teiid-command.log.8
I ran the E2ERecursiveXmlTextSource test. It involves setting a limit of 3 on the
recursion, and then changing the limit to 4 (where all XML document queries will pass). I
found the limit exception was being thrown regardless of the setting (even up to 10).
I changed the behavior from THROW to RECORD and now the queries do not return (in a
timely manner), leading me to worry that recursion may be the cause, not the limit
itself.
Model Project Set and server log will be attached.
Just looked at the command log and it looks pretty weird. I'd be inclined to start
there. I AM able to successfully query the source (text).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4527
days inactive
4594
days old
8 comments
2 participants
participants (2)
-
Paul Nittel (JIRA) -
Steven Hawkins (JIRA)