Hi Robert,
the change sounds good to me. As for IcedTea we never got Weld running
with it. Last time we tried we got blocked by
http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1733 If you can
help us with IcedTea support that would be very appreciated.
Btw did you get better performance with Jandex index?
Jozef
On 01/15/2015 03:17 PM, Robert Marcano wrote:
Greetings, I am new to using Weld on an Java SE environment, trying
to
optimized the container initialization, I got help on the developer IRC
channel telling me to add jandex as a dependency. I found that jandex
indexes could be embedded on jars so I did that. for some reason I got
worse times after adding the dependency. The problem is that Oracle
WebStart implementation doesn't store cached Jar files with the jar
extension anymore.
JandexIndexBeanArchiveHandler is looking for path with the .jar ending
to detect if it is a Jar or directory path [1]. Changing that line to:
> if (urlPath.toLowerCase().endsWith(".jar") || new File(urlPath).isFile())
This solve the problem and now the embedded jandex indexes are used (log
confirmed) on Oracle WebStart implementation. I am not sure about just
using:
> if (new File(urlPath).isFile())
I think that checking for the .jar ending is redundant, opinions before
submitting a patch?
Note: I still have a problem with IcedTea NetX where
JandexIndexBeanArchiveHandler get the http url of the jar file, it
doesn't get a path to the local cached file. Any guide of where I should
look at on Weld source code is welcome.
[1]
https://github.com/weld/core/blob/master/environments/common/src/main/jav...
_______________________________________________
weld-dev mailing list
weld-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-dev