Re: [weld-dev] Maintenance release

Hi Gavin! A few random observations from a non-native english speaker, so beg your pardon if I got something wrong ;) Clarifying the 'Context' lifespan: I think it is currently not clear what a Context instance represents. While the wording in the default scope lifecycle section (6.7) suggests that there are n (multiple) Context objects for a specific Scope annotation [1] (e.g. one SessionContext instance for each session), the system eventing section (11.5.2) [2] only allows adding a single Context for a Scope annotation (kind of a Context-Facade?). [1] 6.7.2 The session context is shared between all servlet requests that occur _in_the_same_HTTP_session (->another session gets another session context?). The session context is destroyed when the HTTPSession times out, after all HttpSessionListeners have been called, and at the very end of any request in which invalidate() was called, after all filters and ServletRequestListeners have been called (->again backs the n-contexts theory). [2] 11.5.2 AfterBeanDiscovery#addContext() registers a custom Context object with the container. (-> no way to add a 'ContextFactory') While this doesn't make much difference for our built in scopes (e.g. OWB currently implements the n-context strategy with a ContextFactory while weld seems to use 1 SessionContext instance, isn't?) it may make a difference for portable extensions. And it is really confusing for people who only want to write an extension providing a Context for a custom scope. Btw, we should also add a note to the Context interface decription (or somewhere else?) to explicitely state that a Context implementation is obliged to destroy all Contextual instances if they are not needed any longer. This includes listening to the BeforeShutdown event (11.5.4) and destroying all beans properly... Almost all extensions I've seen so far don't destroy their Contextuals, thus imho no @PreDestroy will get called on them, etc... LieGrue, strub --- On Thu, 1/7/10, Gavin King <gavin.king(a)gmail.com&gt; wrote: