Hi All, In the scope of https://issues.jboss.org/browse/AEROGEAR-803 , we have a method to retrieve an user (based on its id). If the user don't exist it returns null. There were some suggestions to change that into : - throwing a runtime exception (seems a bit brutal) - or returning an empty user (can be confusing) What is your opinion about this ? Seb ps: the method https://gist.github.com/4510879 _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

Hi All, In the scope of https://issues.jboss.org/browse/AEROGEAR-803 , we have a method to retrieve an user (based on its id). If the user don't exist it returns null. There were some suggestions to change that into : - throwing a runtime exception (seems a bit brutal) - or returning an empty user (can be confusing) What is your opinion about this ? Seb ps: the method https://gist.github.com/4510879 _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org (mailto:aerogear-dev@lists.jboss.org) https://lists.jboss.org/mailman/listinfo/aerogear-dev

What is really wrong with returning 'null' ? I'm used to this situation when using Hibernate for example, when the user don't exist then it just return null and it's up to the developer (as Lucas said) to handle this situation ... Seb On Fri, Jan 11, 2013 at 5:02 PM, Matthias Wessendorf <matzew(a)apache.org&gt;wrote: > On Fri, Jan 11, 2013 at 4:01 PM, Sebastien Blanc <scm.blanc(a)gmail.com&gt; > wrote: > > Hi All, > > In the scope of https://issues.jboss.org/browse/AEROGEAR-803 , we have > a > > method to retrieve an user (based on its id). If the user don't exist it > > returns null. > > > > There were some suggestions to change that into : > > - throwing a runtime exception (seems a bit brutal) > > +1 on exception > > -M > > > > - or returning an empty user (can be confusing) > > > > What is your opinion about this ? > > > > Seb > > > > ps: the method https://gist.github.com/4510879 > > > > > > > > _______________________________________________ > > aerogear-dev mailing list > > aerogear-dev(a)lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > twitter: http://twitter.com/mwessendorf > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On 11/01/2013, at 13:01, Sebastien Blanc <scm.blanc(a)gmail.com&gt; wrote: > Hi All, > In the scope of https://issues.jboss.org/browse/AEROGEAR-803 , we have a method to retrieve an user (based on its id). If the user don't exist it returns null. > > There were some suggestions to change that into : > - throwing a runtime exception (seems a bit brutal) +1 > - or returning an empty user (can be confusing) -1 > > What is your opinion about this ? > > Seb > > ps: the method https://gist.github.com/4510879 > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

Ok, We have a majority for the Exception, so go! go! go! for the runtime Exception , shall I create a new Exception in ag-security ? Suggestions for the name ?