Hi, The database unit tests of the UPS contain a lot of setup code as setting up the database is done within the test method. I’m proposing to remove this ‘noise’ from the test and put it in a separate file. Another thing that is setting up the dao's, when we use arquillian weld container we can use injection in our tests to further reduce the boilerplate, have a look at an example: https://github.com/edewit/aerogear-unifiedpush-server/blob/4bb63adce319df... If you like I could do this for all these tests. Cheers, Erik Jan _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

This is using weld container, that is not a application container it doesn’t add a lot of execution time. It only enables CDI in tests. On 21 Jan,2015, at 16:50 , Matthias Wessendorf <matzew(a)apache.org&gt; wrote: > I think the problem that I have with using Arquillian is the time of execution for these integration tests. It boots up a container and stuff and just makes the test execution take a very long time. We spoke about that in the past, and didn't do Aquillian due to that. > > Not sure how others feel about it, but I'd prefer we dont boot a container inside our tests > > On Wed, Jan 21, 2015 at 4:40 PM, Erik Jan de Wit <edewit(a)redhat.com&gt; wrote: > Hi, > > The database unit tests of the UPS contain a lot of setup code as setting up the database is done within the test method. I’m proposing to remove this ‘noise’ from the test and put it in a separate file. Another thing that is setting up the dao's, when we use arquillian weld container we can use injection in our tests to further reduce the boilerplate, have a look at an example: > > https://github.com/edewit/aerogear-unifiedpush-server/blob/4bb63adce319df... > > If you like I could do this for all these tests. > > Cheers, > Erik Jan > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > twitter: http://twitter.com/mwessendorf > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

I think the problem that I have with using Arquillian is the time of execution for these integration tests. It boots up a container and stuff and just makes the test execution take a very long time. We spoke about that in the past, and didn't do Aquillian due to that.

Not sure how others feel about it, but I'd prefer we dont boot a container inside our tests On Wed, Jan 21, 2015 at 4:40 PM, Erik Jan de Wit <edewit(a)redhat.com <mailto:edewit@redhat.com>> wrote: Hi, The database unit tests of the UPS contain a lot of setup code as setting up the database is done within the test method. I’m proposing to remove this ‘noise’ from the test and put it in a separate file. Another thing that is setting up the dao's, when we use arquillian weld container we can use injection in our tests to further reduce the boilerplate, have a look at an example: https://github.com/edewit/aerogear-unifiedpush-server/blob/4bb63adce319df... If you like I could do this for all these tests. Cheers, Erik Jan _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> https://lists.jboss.org/mailman/listinfo/aerogear-dev -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

>Phone:404 941 4698 >Java is my crack.

On Wed, Jan 21, 2015 at 5:29 PM, Summers Pittman <supittma(a)redhat.com&gt; wrote: On 01/21/2015 10:50 AM, Matthias Wessendorf wrote: > I think the problem that I have with using Arquillian is the > time of execution for these integration tests. It boots up a > container and stuff and just makes the test execution take a > very long time. We spoke about that in the past, and didn't > do Aquillian due to that. I'm learning to alike Arquillian. Would it be terribly to put the Arq tests in a profile so they only get run if you pass -Pit or something? nope - that sounds good, folder could be src/itest/java/....

and only enabled on a -Pit or -Pitests Eventually the tests may get to take long enough its important. The android-maven-plugin does that so you aren't always firing up Android VM's. > > > Not sure how others feel about it, but I'd prefer we dont > boot a container inside our tests > > On Wed, Jan 21, 2015 at 4:40 PM, Erik Jan de Wit > <edewit(a)redhat.com&gt; wrote: > Hi, > > > The database unit tests of the UPS contain a lot of > setup code as setting up the database is done within > the test method. I’m proposing to remove this > ‘noise’ from the test and put it in a separate file. > Another thing that is setting up the dao's, when we > use arquillian weld container we can use injection > in our tests to further reduce the boilerplate, have > a look at an example: > > > https://github.com/edewit/aerogear-unifiedpush-server/blob/4bb63adce319df... > > > If you like I could do this for all these tests. > > > Cheers, > Erik Jan > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > twitter: http://twitter.com/mwessendorf > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev -- Summers Pittman >>Phone:404 941 4698 >>Java is my crack. _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

Totally out of the blue, but is there a way to annotate test classes to make them run iff there is a flag set? If you put integration-tests in a different folder then you will also have to tell maven about them in the testSourceSet stanza which will cause them to get run anyway. (And if they aren't in source set for the default profile I'm not sure IDEs will pick them up)(Unless there is a third source set type I'm not familiar with)