2:55 p.m.
Y'all,
I noticed that some of the method and class names in AeroGear Android
around Paging are sub obtimal.
I would like to, before 1.0 is cut, make the following changes
Methods:
PageConfig.setPageHeaderParser -> PageConfig.setParameterProvider
Classed:
PageResultExtractor -> ParameterProvider
ParameterProvider -> gets merged into Parameter Provider
All implementations are updated
wdyt?
2:57 p.m.
I am +0.99 on this. As long as it's easy and the risk of breaking a bunch of stuff is
low.
On Mar 22, 2013, at 8:55 AM, Summers Pittman <supittma(a)redhat.com> wrote:
Y'all,
I noticed that some of the method and class names in AeroGear Android around Paging are
sub obtimal.
I would like to, before 1.0 is cut, make the following changes
Methods:
PageConfig.setPageHeaderParser -> PageConfig.setParameterProvider
Classed:
PageResultExtractor -> ParameterProvider
ParameterProvider -> gets merged into Parameter Provider
All implementations are updated
wdyt?
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
2:58 p.m.
+1
On Fri, Mar 22, 2013 at 10:55 AM, Summers Pittman <supittma(a)redhat.com>wrote:
Y'all,
I noticed that some of the method and class names in AeroGear Android
around Paging are sub obtimal.
I would like to, before 1.0 is cut, make the following changes
Methods:
PageConfig.setPageHeaderParser -> PageConfig.setParameterProvider
Classed:
PageResultExtractor -> ParameterProvider
ParameterProvider -> gets merged into Parameter Provider
All implementations are updated
wdyt?
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
2:58 p.m.
On 03/22/2013 09:57 AM, Kris Borchers wrote:
I am +0.99 on this. As long as it's easy and the risk of breaking
a bunch of stuff is low.
Risk is rather low, I have plenty of tests on this and a
few sample apps.
On Mar 22, 2013, at 8:55 AM, Summers Pittman
<supittma(a)redhat.com> wrote:
> Y'all,
>
> I noticed that some of the method and class names in AeroGear Android around Paging
are sub obtimal.
>
> I would like to, before 1.0 is cut, make the following changes
>
> Methods:
> PageConfig.setPageHeaderParser -> PageConfig.setParameterProvider
>
>
> Classed:
>
> PageResultExtractor -> ParameterProvider
> ParameterProvider -> gets merged into Parameter Provider
>
> All implementations are updated
>
> wdyt?
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
3:05 p.m.
parameter provider, is used to specify the "query" (e.g. limit/offset ,
page. per-page) etc
Is that waht it does ?
On Fri, Mar 22, 2013 at 2:55 PM, Summers Pittman <supittma(a)redhat.com>wrote:
Y'all,
I noticed that some of the method and class names in AeroGear Android
around Paging are sub obtimal.
I would like to, before 1.0 is cut, make the following changes
Methods:
PageConfig.setPageHeaderParser -> PageConfig.setParameterProvider
Classed:
PageResultExtractor -> ParameterProvider
ParameterProvider -> gets merged into Parameter Provider
All implementations are updated
wdyt?
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
3:07 p.m.
From the spec:
A|parameter provider|API will be provided to that the application
developer can submit any (paging) parameter that the used server
requires. An example would be that the used paging service supports
sorting as well.
That is what this class did and is getting renamed to be correct.
You are referring to Paging parameters.
On 03/22/2013 10:05 AM, Matthias Wessendorf wrote:
parameter provider, is used to specify the "query" (e.g.
limit/offset
, page. per-page) etc
Is that waht it does ?
On Fri, Mar 22, 2013 at 2:55 PM, Summers Pittman <supittma(a)redhat.com
<mailto:supittma@redhat.com>> wrote:
Y'all,
I noticed that some of the method and class names in AeroGear
Android around Paging are sub obtimal.
I would like to, before 1.0 is cut, make the following changes
Methods:
PageConfig.setPageHeaderParser -> PageConfig.setParameterProvider
Classed:
PageResultExtractor -> ParameterProvider
ParameterProvider -> gets merged into Parameter Provider
All implementations are updated
wdyt?
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
3:15 p.m.
On Fri, Mar 22, 2013 at 3:07 PM, Summers Pittman <supittma(a)redhat.com>wrote:
From the spec:
A parameter provider API will be provided to that the application
developer can submit any (paging) parameter that the used server requires.
An example would be that the used paging service supports sorting as well.
That is what this class did and is getting renamed to be correct.
provided as a parameter provider :)
You are referring to Paging parameters.
On 03/22/2013 10:05 AM, Matthias Wessendorf wrote:
parameter provider, is used to specify the "query" (e.g. limit/offset ,
page. per-page) etc
Is that waht it does ?
On Fri, Mar 22, 2013 at 2:55 PM, Summers Pittman <supittma(a)redhat.com>wrote:
> Y'all,
>
> I noticed that some of the method and class names in AeroGear Android
> around Paging are sub obtimal.
>
> I would like to, before 1.0 is cut, make the following changes
>
> Methods:
> PageConfig.setPageHeaderParser -> PageConfig.setParameterProvider
>
>
> Classed:
>
> PageResultExtractor -> ParameterProvider
> ParameterProvider -> gets merged into Parameter Provider
>
> All implementations are updated
>
> wdyt?
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing
listaerogear-dev@lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
3:18 p.m.
On Fri, Mar 22, 2013 at 3:07 PM, Summers Pittman <supittma(a)redhat.com>wrote:
From the spec:
A parameter provider API will be provided to that the application
developer can submit any (paging) parameter that the used server requires.
An example would be that the used paging service supports sorting as well.
That is what this class did and is getting renamed to be correct.
You are referring to Paging parameters.
https://github.com/aerogear/aerogear.org/blob/master/docs/specs/aerogear-...
On 03/22/2013 10:05 AM, Matthias Wessendorf wrote:
parameter provider, is used to specify the "query" (e.g. limit/offset ,
page. per-page) etc
Is that waht it does ?
On Fri, Mar 22, 2013 at 2:55 PM, Summers Pittman <supittma(a)redhat.com>wrote:
> Y'all,
>
> I noticed that some of the method and class names in AeroGear Android
> around Paging are sub obtimal.
>
> I would like to, before 1.0 is cut, make the following changes
>
> Methods:
> PageConfig.setPageHeaderParser -> PageConfig.setParameterProvider
>
>
> Classed:
>
> PageResultExtractor -> ParameterProvider
> ParameterProvider -> gets merged into Parameter Provider
>
> All implementations are updated
>
> wdyt?
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing
listaerogear-dev@lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
3:26 p.m.
On 03/22/2013 10:18 AM, Matthias Wessendorf wrote:
On Fri, Mar 22, 2013 at 3:07 PM, Summers Pittman <supittma(a)redhat.com
<mailto:supittma@redhat.com>> wrote:
From the spec:
A|parameter provider|API will be provided to that the application
developer can submit any (paging) parameter that the used server
requires. An example would be that the used paging service
supports sorting as well.
That is what this class did and is getting renamed to be correct.
You are referring to Paging parameters.
https://github.com/aerogear/aerogear.org/blob/master/docs/specs/aerogear-...
Hrm. I guess I always read that as default paging parameters since that
is the topic of the entire previous paragraph.
On 03/22/2013 10:05 AM, Matthias Wessendorf wrote:
> parameter provider, is used to specify the "query" (e.g.
> limit/offset , page. per-page) etc
>
> Is that waht it does ?
>
> On Fri, Mar 22, 2013 at 2:55 PM, Summers Pittman
> <supittma(a)redhat.com <mailto:supittma@redhat.com>> wrote:
>
> Y'all,
>
> I noticed that some of the method and class names in AeroGear
> Android around Paging are sub obtimal.
>
> I would like to, before 1.0 is cut, make the following changes
>
> Methods:
> PageConfig.setPageHeaderParser -> PageConfig.setParameterProvider
>
>
> Classed:
>
> PageResultExtractor -> ParameterProvider
> ParameterProvider -> gets merged into Parameter Provider
>
> All implementations are updated
>
> wdyt?
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> <mailto:aerogear-dev@lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
4:04 p.m.
After a quick Hangout with matzew, passos, and cvasilak we decided on this
Reaname the property
PageConfig.pageHeaderParser -> PageConfig.pageParameterExtractor
Rename the interface
PageResultExtractor -> PageParameterExtractor
wdyt?
On 03/22/2013 09:55 AM, Summers Pittman wrote:
Y'all,
I noticed that some of the method and class names in AeroGear Android
around Paging are sub obtimal.
I would like to, before 1.0 is cut, make the following changes
Methods:
PageConfig.setPageHeaderParser -> PageConfig.setParameterProvider
Classed:
PageResultExtractor -> ParameterProvider
ParameterProvider -> gets merged into Parameter Provider
All implementations are updated
wdyt?
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
4060
days inactive
4060
days old
9 comments
4 participants
participants (4)
-
Daniel Passos -
Kris Borchers -
Matthias Wessendorf -
Summers Pittman