12:03 p.m.
Hi,
I just stumbled upon a question on SO [1], which basically is about
whether it's allowed to pass a complete property path (e.g.
"foos[1].bar") to Validator#validateProperty(), or whether only single
properties (e.g. "foos") can be validated using that method.
Based on a quick look into the API doc and the spec, I'd say only
single properties are supported here right now (the doc of the
parameter "propertyName" describes it as "property to validate"), but
I'm not really sure. WDYT?
If this is not supported as of BV 1.0, do you think it should be in 1.1?
--Gunnar
[1]
http://stackoverflow.com/questions/10835595/hibernate-validator-calling-v...
12:09 p.m.
It is my understanding that any path expression should be supported;
this is certainly how Apache BVal operates. Note that validations are
still not cascaded, although Apache BVal provides a special
implementation-specific interface that permits this.
Matt
On Fri, Jun 1, 2012 at 12:03 PM, Gunnar Morling <gunnar(a)hibernate.org> wrote:
Hi,
I just stumbled upon a question on SO [1], which basically is about
whether it's allowed to pass a complete property path (e.g.
"foos[1].bar") to Validator#validateProperty(), or whether only single
properties (e.g. "foos") can be validated using that method.
Based on a quick look into the API doc and the spec, I'd say only
single properties are supported here right now (the doc of the
parameter "propertyName" describes it as "property to validate"),
but
I'm not really sure. WDYT?
If this is not supported as of BV 1.0, do you think it should be in 1.1?
--Gunnar
[1]
http://stackoverflow.com/questions/10835595/hibernate-validator-calling-v...
_______________________________________________
beanvalidation-dev mailing list
beanvalidation-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/beanvalidation-dev
12:15 p.m.
Actually... ;)
Going back to the spec now I can see how you arrived at your
conclusion, Gunnar. Specifically the spec says "JavaBeans property
name (as defined by the JavaBeans Introspector class)." I consider
validating an entire property path to be a perfectly valid use case
and would support expanding the definition of the propertyName
parameter of #validateProperty() and #validateValue() to an expression
compatible with the Path interface.
Further, I would suggest making some gesture toward providing
overloaded forms of these methods that took Path objects explicitly,
perhaps even as an alternative to requiring that an implementation
support @propertyName-as-expression.
Matt
On Fri, Jun 1, 2012 at 12:09 PM, Matt Benson <mbenson(a)apache.org> wrote:
It is my understanding that any path expression should be supported;
this is certainly how Apache BVal operates. Note that validations are
still not cascaded, although Apache BVal provides a special
implementation-specific interface that permits this.
Matt
On Fri, Jun 1, 2012 at 12:03 PM, Gunnar Morling <gunnar(a)hibernate.org> wrote:
> Hi,
>
> I just stumbled upon a question on SO [1], which basically is about
> whether it's allowed to pass a complete property path (e.g.
> "foos[1].bar") to Validator#validateProperty(), or whether only single
> properties (e.g. "foos") can be validated using that method.
>
> Based on a quick look into the API doc and the spec, I'd say only
> single properties are supported here right now (the doc of the
> parameter "propertyName" describes it as "property to validate"),
but
> I'm not really sure. WDYT?
>
> If this is not supported as of BV 1.0, do you think it should be in 1.1?
>
> --Gunnar
>
> [1]
http://stackoverflow.com/questions/10835595/hibernate-validator-calling-v...
> _______________________________________________
> beanvalidation-dev mailing list
> beanvalidation-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/beanvalidation-dev
6:46 a.m.
Hi,
It was meant to be supported in a future version and to let implementors experiment with
such a support first.
If we officially support it we need to:
- standardize the String representation of a Path, which is something we shied away from
in 1.0
- offer an alternative methods accepting Path ; we would also need to offer a PathBuilder
of sort
If people are interested in contributing, please open a BVAL issue number and start
forking.
On 1 juin 2012, at 19:03, Gunnar Morling wrote:
Hi,
I just stumbled upon a question on SO [1], which basically is about
whether it's allowed to pass a complete property path (e.g.
"foos[1].bar") to Validator#validateProperty(), or whether only single
properties (e.g. "foos") can be validated using that method.
Based on a quick look into the API doc and the spec, I'd say only
single properties are supported here right now (the doc of the
parameter "propertyName" describes it as "property to validate"),
but
I'm not really sure. WDYT?
If this is not supported as of BV 1.0, do you think it should be in 1.1?
--Gunnar
[1]
http://stackoverflow.com/questions/10835595/hibernate-validator-calling-v...
_______________________________________________
beanvalidation-dev mailing list
beanvalidation-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/beanvalidation-dev
7:02 a.m.
On Jun 4, 2012, at 1:46 PM, Emmanuel Bernard wrote:
Hi,
It was meant to be supported in a future version and to let implementors experiment with
such a support first.
If we officially support it we need to:
- standardize the String representation of a Path, which is something we shied away from
in 1.0
In this context we also need to think about how to represent method level validation
paths.
Property paths are relative straight forward (based on users experience with EL) and I
have not come across
a case where someone had problems with the approach taken for example in Hibernate
Validator.
Finding a good path representation for method level validation is harder though.
- offer an alternative methods accepting Path ; we would also need to
offer a PathBuilder of sort
The more I think about it the more I like the idea of having a #validateProperty and
#validateValue
which take a Path instance as parameter.
--Hardy
1:53 p.m.
2012/6/4 Hardy Ferentschik <hardy(a)hibernate.org>:
On Jun 4, 2012, at 1:46 PM, Emmanuel Bernard wrote:
> Hi,
>
> It was meant to be supported in a future version and to let implementors experiment
with such a support first.
> If we officially support it we need to:
>
> - standardize the String representation of a Path, which is something we shied away
from in 1.0
In this context we also need to think about how to represent method level validation
paths.
Property paths are relative straight forward (based on users experience with EL) and I
have not come across
a case where someone had problems with the approach taken for example in Hibernate
Validator.
Finding a good path representation for method level validation is harder though.
Yepp, that's tricky indeed, in particular for return value constraints.
> - offer an alternative methods accepting Path ; we would also need to offer a
PathBuilder of sort
The more I think about it the more I like the idea of having a #validateProperty and
#validateValue
which take a Path instance as parameter.
+1. Maybe this would even avoid the need for specifying path String
representations. validateValue(String propertyName) would support
single properties as before, while complete paths could be validated
using the new methods.
I'm also starting to see Emmanuel's point about pushing the method
validation methods to another interface to avoid too many methods on
j.v.Validator :)
I've created https://hibernate.onjira.com/browse/BVAL-294, just in
case someone feels like giving this some more thoughts.
--Gunnar
--Hardy
_______________________________________________
beanvalidation-dev mailing list
beanvalidation-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/beanvalidation-dev
4589
days inactive
4592
days old
beanvalidation-dev@lists.jboss.org
5 comments
4 participants
participants (4)
-
Emmanuel Bernard -
Gunnar Morling -
Hardy Ferentschik -
Matt Benson