Re: [bv-dev] Hosting of method validation methods

Hi, Am 27.08.2012 15:37 schrieb "Emmanuel Bernard" <emmanuel(a)hibernate.org&gt;: ValidatorFactory, right? At least that was the original idea. negative I could see are: environments `MethodValidator` Hmmm, you're right about 1. and 2. No biggie though IMO. I'm not sure about getConstraintsForClass(). Would it really be duplicated? I think the following options would be possible: * Validator#getConstraintsForClass() could return a descriptor describing all (bean and method) constraints. No getConstraintsForClass() on MethodValidator. * Validator#getConstraintsForClass() returns a descriptor of the bean constraints, MethodValidator#getConstraintsForClass() returns a descriptor representing the method level constraints. Which one did you have in mind? Regarding unwrap(), I'm tempted to say we should have it anyways on MethodValidator, or did you mean to unwrap via an implementation-specific Validator interface? Also in the fluent approach, I think I'd slightly prefer MyMethodValidator mv = myValidator.getMethodValidator().unwrap(MyMethodValidator.class); over MyMethodValidator mv = myValidator.unwrap(MyValidator.class).getMethodValidator(); The main reason being, that it is more obvious and one doesn't need a specific Validator interface if one only wants to expose a specific MethodValidator interface. It doesn't make a huge difference, though. wonder if that's the right approach. requires one extra method call. Any other? I'd just find it more natural to retrieve a (method) validator from a validator factory instead from another validator. That way it's more regular IMO. --Gunnar