Please still use a fork and send pull requests from that.
We usually don't have feature branches in the "blessed" upstream repos,
only if several people happen to work together on a single "thing" for a
longer period of time.
2016-09-02 13:57 GMT+02:00 Hendrik Ebbers <hendrik.ebbers(a)me.com>:
Cool!
Question: Should we still use forks or can we work with features branches
directly in then bean validation repos?
Hendrik
Am 02.09.2016 um 09:27 schrieb Gunnar Morling <gunnar(a)hibernate.org>:
Hi Hendrik,
Great ideas! Further details inline.
2016-09-01 16:30 GMT+02:00 Hendrik Ebbers <hendrik.ebbers(a)me.com>:
> Hi all,
>
> currently all JBV repos are part of
https://github.com/beanvalidation
> which is really great. 3 people are part of this team at GitHub and I
> asked myself if I can become member of the team, too.
>
I've set up a new team "eg-members" under the Bean Validation GitHub
organization and sent you an invite for it (other EG members give me your
GitHub handle if you want to be in there, too). This will show you under
the list of org members and also allows to summon other experts's input on
commits/PRs using the "@eg-members" alias.
I've also granted write access to that team for the relevant repos. But
please *never* push your own commits, instead always go through pull
requests reviewed by other members. Collective code review is one of our
core principles really.
In addition I think that we need a logo for the JSR :) We could use this
> at Github, Twitter &
beanvalidation.org. I know an illustrator that did
> a lot of Java-related images for me. If you know the JavaOne voting
> machines: He created all the duke animations (
>
http://www.guigarage.com/2016/01/the-javaone-voting-machine/). I would
> love to ask him for a logo for the JRS. Currently I’m thinking about a Duke
> that stamps beans. What do you think?
>
Yes, personally I'd love to have a log, the lack of one has been bugging
me for quite a while. I'll reply to you off-list to sort out some details.
Cheers,
>
> Hendrik
>
--Gunnar
>
> _______________________________________________
> beanvalidation-dev mailing list
> beanvalidation-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/beanvalidation-dev
>
_______________________________________________
beanvalidation-dev mailing list
beanvalidation-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/beanvalidation-dev
_______________________________________________
beanvalidation-dev mailing list
beanvalidation-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/beanvalidation-dev