[hibernate-commits] [hibernate/hibernate-search] bd915a: HSEARCH-4579 Add a few missing @Override annotations

Branch: refs/heads/main Home: https://github.com/hibernate/hibernate-search Commit: bd915a966f0196f1d4dc75d27de4a82a217400a9 https://github.com/hibernate/hibernate-search/commit/bd915a966f0196f1d4dc... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-16 (Tue, 16 Aug 2022) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/AbstractHibernateOrmTypeContext.java Log Message: ----------- HSEARCH-4579 Add a few missing @Override annotations Commit: 99b3841acf95494245b8d3f26dd4413d7f61458c https://github.com/hibernate/hibernate-search/commit/99b3841acf95494245b8... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-16 (Tue, 16 Aug 2022) Changed paths: M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/SearchProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryFetchIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryResultLoadingOrTransformingIT.java Log Message: ----------- HSEARCH-4579 Move tests unrelated to loading out of SearchQueryResultLoadingOrTransformingIT It does not make sense to test "hit transformers" there anymore, as that's a completely orthogonal feature nowadays. Reference projections are already tested in SearchProjectionIT. As to fetchTotalHitCount(), it's completely unrelated to projections in general, and loading in particular. Commit: 71a0b9c4570e73409012f610a3260c83aecdd0aa https://github.com/hibernate/hibernate-search/commit/71a0b9c4570e73409012... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-16 (Tue, 16 Aug 2022) Changed paths: M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/SearchProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryResultLoadingOrTransformingIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryScrollResultLoadingIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/stub/MapperMockUtils.java R integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/stub/StubDocumentReferenceConverter.java Log Message: ----------- HSEARCH-4579 Remove unused "DocumentReferenceConverter" mocks from loading ITs Commit: 3093b5a278eff0e3bcb5d990aaeb307687224910 https://github.com/hibernate/hibernate-search/commit/3093b5a278eff0e3bcb5... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-16 (Tue, 16 Aug 2022) Changed paths: M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/testsupport/util/ElasticsearchTckBackendHelper.java M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/testsupport/util/LuceneTckBackendHelper.java A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/AbstractEntityProjectionIT.java A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/AbstractEntityReferenceProjectionIT.java A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/EntityProjectionIT.java A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/EntityReferenceProjectionIT.java R integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryResultLoadingOrTransformingIT.java A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQuerySelectIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/TckBackendHelper.java Log Message: ----------- HSEARCH-4579 Test .entity()/.entityReference() projections more thoroughly Commit: 783b7b38056351d1067512a89564c9662c2aefe0 https://github.com/hibernate/hibernate-search/commit/783b7b38056351d10675... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-16 (Tue, 16 Aug 2022) Changed paths: M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/AbstractCompositeProjectionFromAsIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/CompositeProjectionBaseIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/ObjectProjectionBaseIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/rule/SearchSetupHelper.java M integrationtest/performance/backend/base/src/main/java/org/hibernate/search/integrationtest/performance/backend/base/testsupport/index/AbstractBackendHolder.java M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMapper.java M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMapping.java A util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappingFixture.java M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappingImpl.java M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappingInitiator.java M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappingPartialBuildState.java Log Message: ----------- HSEARCH-4579 Set the projection registry locally in methods that need it in backend TCK So that it's simpler to use a common SearchMapping for multiple, unrelated tests. Commit: 27b76097d0e924774bd20df2f94ef0870774ade2 https://github.com/hibernate/hibernate-search/commit/27b76097d0e924774bd2... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-16 (Tue, 16 Aug 2022) Changed paths: M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/AbstractEntityProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/AbstractEntityReferenceProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/SearchProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryLoadingOptionsIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryScrollResultLoadingIT.java M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/GenericStubMappingScope.java M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappedIndex.java M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappingScope.java Log Message: ----------- HSEARCH-4579 Simplify creation of generic scopes in the stub mapping Pass the loading context when creating the scope instead of when creating the query. It's technically less correct, but considering this makes testing easier (especially in the next commits), I think we can afford that. Commit: 6eccb15843c8c5c7b22bef783b932804748ffd4a https://github.com/hibernate/hibernate-search/commit/6eccb15843c8c5c7b22b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-16 (Tue, 16 Aug 2022) Changed paths: M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/AbstractEntityProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/AbstractEntityReferenceProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/SearchProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryLoadingOptionsIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryScrollResultLoadingIT.java A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/stub/StubEntity.java R integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/stub/StubLoadedObject.java Log Message: ----------- HSEARCH-4579 Rename StubLoadedObject to StubEntity So that it makes sense to use it when .entity() relies on a projection rather than loading. Commit: e8770033f4369dfdc74b45c082965c8abf03b9c9 https://github.com/hibernate/hibernate-search/commit/e8770033f4369dfdc74b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-16 (Tue, 16 Aug 2022) Changed paths: M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryLoadingOptionsIT.java Log Message: ----------- HSEARCH-4579 Add missing assertions to SearchQueryLoadingOptionsIT Commit: 8d28762f1be225afe0fbff214569c7d0fb4373f1 https://github.com/hibernate/hibernate-search/commit/8d28762f1be225afe0fb... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-16 (Tue, 16 Aug 2022) Changed paths: A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchEntityLoadingProjection.java R backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchEntityProjection.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchSearchProjectionBuilderFactory.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/dsl/impl/ElasticsearchSearchQuerySelectStepImpl.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/LuceneEntityLoadingProjection.java R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/LuceneEntityProjection.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/LuceneSearchProjectionBuilderFactory.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/dsl/impl/LuceneSearchQuerySelectStepImpl.java M engine/src/main/java/org/hibernate/search/engine/search/projection/dsl/impl/EntityProjectionOptionsStepImpl.java M engine/src/main/java/org/hibernate/search/engine/search/projection/spi/SearchProjectionBuilderFactory.java M engine/src/main/java/org/hibernate/search/engine/search/query/dsl/impl/DefaultSearchQuerySelectStep.java A util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubEntityLoadingProjection.java R util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubEntityProjection.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubSearchProjectionBuilderFactory.java Log Message: ----------- HSEARCH-4579 Clarify that the current implementations of "entity" projections are about entity *loading* Commit: 46ca9b35e71c38bc532ed4a5d7ea1a486de94529 https://github.com/hibernate/hibernate-search/commit/46ca9b35e71c38bc532e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-16 (Tue, 16 Aug 2022) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchSearchProjectionBuilderFactory.java A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchThrowingProjection.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/dsl/impl/ElasticsearchSearchQuerySelectStepImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/LuceneSearchProjectionBuilderFactory.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/LuceneThrowingProjection.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/dsl/impl/LuceneSearchQuerySelectStepImpl.java M engine/src/main/java/org/hibernate/search/engine/backend/mapping/spi/BackendMappingContext.java A engine/src/main/java/org/hibernate/search/engine/backend/mapping/spi/BackendMappingHints.java M engine/src/main/java/org/hibernate/search/engine/backend/scope/spi/AbstractSearchIndexScope.java M engine/src/main/java/org/hibernate/search/engine/logging/impl/Log.java M engine/src/main/java/org/hibernate/search/engine/search/common/spi/SearchIndexScope.java M engine/src/main/java/org/hibernate/search/engine/search/projection/definition/spi/ProjectionRegistry.java M engine/src/main/java/org/hibernate/search/engine/search/projection/dsl/impl/EntityProjectionOptionsStepImpl.java M engine/src/main/java/org/hibernate/search/engine/search/projection/dsl/spi/AbstractSearchProjectionFactory.java A engine/src/main/java/org/hibernate/search/engine/search/projection/spi/ProjectionMappedTypeContext.java M engine/src/main/java/org/hibernate/search/engine/search/projection/spi/SearchProjectionBuilderFactory.java M engine/src/main/java/org/hibernate/search/engine/search/projection/spi/SearchProjectionIndexScope.java M engine/src/main/java/org/hibernate/search/engine/search/query/dsl/impl/DefaultSearchQuerySelectStep.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/AbstractEntityProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/AbstractEntityReferenceProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/EntityProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/SearchProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryLoadingOptionsIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryScrollResultLoadingIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQuerySelectIT.java A integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/search/loading/SearchQueryEntityLoadingFallbackToProjectionConstructorIT.java M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/testsupport/loading/StubLoadingContext.java M jqassistant/rules.xml A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/logging/impl/HibernateOrmMappingHints.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmIndexedTypeContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMapping.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/AbstractPojoMappingImplementor.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/search/definition/impl/PojoSearchQueryElementRegistry.java A mapper/pojo-standalone/src/main/java/org/hibernate/search/mapper/pojo/standalone/log/impl/StandalonePojoMappingHints.java M mapper/pojo-standalone/src/main/java/org/hibernate/search/mapper/pojo/standalone/mapping/impl/StandalonePojoIndexedTypeContext.java M mapper/pojo-standalone/src/main/java/org/hibernate/search/mapper/pojo/standalone/mapping/impl/StandalonePojoMapping.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubSearchProjectionBuilderFactory.java A util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubThrowingProjection.java M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappedIndex.java M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappingFixture.java A util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappingHints.java M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappingImpl.java Log Message: ----------- HSEARCH-4579 Default to constructor projection when possible for default and entity() projections Commit: 1631bb06f35e8e8d9dd1f4359952755f01d4e8f0 https://github.com/hibernate/hibernate-search/commit/1631bb06f35e8e8d9dd1... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-16 (Tue, 16 Aug 2022) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchByMappedTypeProjection.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchSearchProjectionBuilderFactory.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/SearchProjectionBackendContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/LuceneByMappedTypeProjection.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/LuceneSearchProjectionBuilderFactory.java M engine/src/main/java/org/hibernate/search/engine/search/projection/dsl/impl/EntityProjectionOptionsStepImpl.java M engine/src/main/java/org/hibernate/search/engine/search/projection/spi/SearchProjectionBuilderFactory.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/AbstractEntityProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/EntityProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQuerySelectIT.java M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/search/loading/SearchQueryEntityLoadingFallbackToProjectionConstructorIT.java A util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubByMappedTypeProjection.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubSearchProjectionBuilderFactory.java Log Message: ----------- HSEARCH-4579 Support entity projection for multi-index search with heterogeneous configuration I.e. when some types targeted by the search have loading support and others rely on @ProjectionConstructor. Commit: cc8504f15d772a2aa8ee9932eeda52bff9bd02ca https://github.com/hibernate/hibernate-search/commit/cc8504f15d772a2aa8ee... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-16 (Tue, 16 Aug 2022) Changed paths: A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchRootContextProjection.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchSearchProjectionBuilderFactory.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/FieldProjectionRequestContext.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ProjectionRequestContext.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchSearchQueryRequestContext.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/LuceneRootContextProjection.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/LuceneSearchProjectionBuilderFactory.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/ProjectionRequestContext.java M engine/src/main/java/org/hibernate/search/engine/search/projection/dsl/impl/EntityProjectionOptionsStepImpl.java M engine/src/main/java/org/hibernate/search/engine/search/projection/spi/SearchProjectionBuilderFactory.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/AbstractEntityProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/EntityProjectionIT.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubSearchProjectionBuilderFactory.java Log Message: ----------- HSEARCH-4579 Ensure entity() projections can be used within object() projections even when relying on projection constructors Commit: 43324952acaf0bbade34de894ec44020cec67389 https://github.com/hibernate/hibernate-search/commit/43324952acaf0bbade34... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-16 (Tue, 16 Aug 2022) Changed paths: M documentation/src/main/asciidoc/reference/mapper-pojo-standalone.asciidoc M documentation/src/main/asciidoc/reference/search-dsl-projection.asciidoc M documentation/src/main/asciidoc/reference/search-dsl-query.asciidoc Log Message: ----------- HSEARCH-4579 Document that the entity() projection falls back to projection constructors for the Standalone POJO Mapper Compare: https://github.com/hibernate/hibernate-search/compare/8bd485f0175e...4332...