[hibernate-commits] [hibernate/hibernate-orm] c718a4: improve some error messages

Branch: refs/heads/main Home: https://github.com/hibernate/hibernate-orm Commit: c718a462850d781c5842a76f61f3b016459fc9dd https://github.com/hibernate/hibernate-orm/commit/c718a462850d781c5842a76... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/boot/model/internal/AnnotatedColumn.java M hibernate-core/src/main/java/org/hibernate/mapping/Formula.java M hibernate-core/src/main/java/org/hibernate/sql/Template.java Log Message: ----------- improve some error messages Commit: abb89a32b1abc0e4b41b82fe02469319fcf07385 https://github.com/hibernate/hibernate-orm/commit/abb89a32b1abc0e4b41b82f... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/boot/model/internal/EntityBinder.java M hibernate-core/src/main/java/org/hibernate/boot/model/internal/TableBinder.java M hibernate-core/src/main/java/org/hibernate/mapping/Table.java Log Message: ----------- minor change to code Commit: 1657c22aca5b8a68bd844b34ab5466103a32ccb1 https://github.com/hibernate/hibernate-orm/commit/1657c22aca5b8a68bd844b3... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M documentation/src/test/java/org/hibernate/userguide/schema/CheckTest.java M hibernate-core/src/main/java/org/hibernate/annotations/Check.java A hibernate-core/src/main/java/org/hibernate/annotations/Checks.java M hibernate-core/src/main/java/org/hibernate/annotations/Table.java M hibernate-core/src/main/java/org/hibernate/annotations/Tables.java M hibernate-core/src/main/java/org/hibernate/boot/model/internal/AnnotatedColumn.java M hibernate-core/src/main/java/org/hibernate/boot/model/internal/ClassPropertyHolder.java M hibernate-core/src/main/java/org/hibernate/boot/model/internal/CollectionBinder.java M hibernate-core/src/main/java/org/hibernate/boot/model/internal/EntityBinder.java M hibernate-core/src/main/java/org/hibernate/boot/model/internal/OneToOneSecondPass.java M hibernate-core/src/main/java/org/hibernate/mapping/AggregateColumn.java M hibernate-core/src/main/java/org/hibernate/mapping/BasicValue.java A hibernate-core/src/main/java/org/hibernate/mapping/CheckConstraint.java M hibernate-core/src/main/java/org/hibernate/mapping/Column.java M hibernate-core/src/main/java/org/hibernate/mapping/Join.java M hibernate-core/src/main/java/org/hibernate/mapping/PersistentClass.java M hibernate-core/src/main/java/org/hibernate/mapping/Table.java M hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/MappingMetamodelImpl.java M hibernate-core/src/main/java/org/hibernate/sql/Template.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/ColumnDefinitions.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/StandardTableExporter.java Log Message: ----------- automatically detect when a @Check refers to a @SecondaryTable - also support named check constraints (multiple of them) - also support check constraints on collection tables Commit: 117851e4a4ed7ff119c469882ae7b7ae2bae9e70 https://github.com/hibernate/hibernate-orm/commit/117851e4a4ed7ff119c4698... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/annotations/Comment.java M hibernate-core/src/main/java/org/hibernate/binder/AttributeBinder.java M hibernate-core/src/main/java/org/hibernate/binder/TypeBinder.java Log Message: ----------- add example to @Comment Commit: 1eba25a4663b60562acb22908a82406166f74f5b https://github.com/hibernate/hibernate-orm/commit/1eba25a4663b60562acb229... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/mapping/AttributeContainer.java Log Message: ----------- add some doc to AttributeContainer Commit: 7aa92a7c0585b83229c39474dd7da25fad08b2f0 https://github.com/hibernate/hibernate-orm/commit/7aa92a7c0585b83229c3947... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M documentation/src/test/java/org/hibernate/userguide/schema/CheckTest.java M hibernate-core/src/main/java/org/hibernate/Metamodel.java M hibernate-core/src/main/java/org/hibernate/annotations/IndexColumn.java M hibernate-core/src/main/java/org/hibernate/annotations/NamedNativeQueries.java M hibernate-core/src/main/java/org/hibernate/annotations/NamedQueries.java M hibernate-core/src/main/java/org/hibernate/boot/model/internal/ClassPropertyHolder.java M hibernate-core/src/main/java/org/hibernate/internal/SessionFactoryImpl.java M hibernate-core/src/main/java/org/hibernate/internal/util/LockModeConverter.java M hibernate-core/src/main/java/org/hibernate/mapping/AttributeContainer.java M hibernate-core/src/main/java/org/hibernate/mapping/Join.java M hibernate-core/src/main/java/org/hibernate/mapping/PersistentClass.java M hibernate-core/src/main/java/org/hibernate/mapping/Subclass.java M hibernate-core/src/main/java/org/hibernate/metamodel/ValueClassification.java M hibernate-core/src/main/java/org/hibernate/metamodel/internal/RuntimeMetamodelsImpl.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/MappingModelCreationProcess.java M hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/MappingMetamodelImpl.java M hibernate-core/src/main/java/org/hibernate/metamodel/spi/MetamodelImplementor.java M hibernate-core/src/main/java/org/hibernate/metamodel/spi/RuntimeModelCreationContext.java M hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java M hibernate-core/src/main/java/org/hibernate/persister/spi/PersisterCreationContext.java M hibernate-core/src/main/java/org/hibernate/sql/Template.java M hibernate-core/src/main/java/org/hibernate/type/spi/TypeConfiguration.java M hibernate-core/src/test/java/org/hibernate/orm/test/mapping/collections/SortNaturalByDefaultTests.java M hibernate-testing/src/main/java/org/hibernate/testing/boot/MetadataBuildingContextTestingImpl.java M tooling/metamodel-generator/src/main/java/org/hibernate/jpamodelgen/annotation/MetaAttributeGenerationVisitor.java Log Message: ----------- allow @Formulas to refer to columns of @SecondaryTables (this is something that was previously only possible using hbm.xml) also attempt a partial fixup of the initialization process where SessionFactoryImpl constructor leaked out an uninitialized reference to itself (it still leaks, but not as badly) Commit: 102ef2f469e3df12f8a90f0df4ac89206ac24580 https://github.com/hibernate/hibernate-orm/commit/102ef2f469e3df12f8a90f0... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/boot/internal/MetadataImpl.java M hibernate-core/src/main/java/org/hibernate/boot/internal/SessionFactoryBuilderImpl.java A hibernate-core/src/main/java/org/hibernate/boot/internal/SessionFactoryObserverForNamedQueryValidation.java A hibernate-core/src/main/java/org/hibernate/boot/internal/SessionFactoryObserverForRegistration.java A hibernate-core/src/main/java/org/hibernate/boot/internal/SessionFactoryObserverForSchemaExport.java M hibernate-core/src/main/java/org/hibernate/boot/internal/SessionFactoryOptionsBuilder.java M hibernate-core/src/main/java/org/hibernate/internal/SessionFactoryImpl.java M hibernate-core/src/main/java/org/hibernate/query/internal/NamedObjectRepositoryImpl.java M hibernate-core/src/main/java/org/hibernate/query/named/NamedObjectRepository.java M hibernate-core/src/main/java/org/hibernate/query/spi/QueryEngine.java M hibernate-core/src/main/java/org/hibernate/type/spi/TypeConfiguration.java Log Message: ----------- refactor some functionality out of constructor SessionFactoryImpl into observers Commit: 822153948c857e5a6e2b4bf561a3f039c9419d3d https://github.com/hibernate/hibernate-orm/commit/822153948c857e5a6e2b4bf... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/dialect/temptable/TemporaryTable.java M hibernate-core/src/main/java/org/hibernate/internal/SessionFactoryImpl.java M hibernate-core/src/main/java/org/hibernate/mapping/Property.java M hibernate-core/src/main/java/org/hibernate/metamodel/internal/EmbeddableRepresentationStrategyPojo.java M hibernate-core/src/main/java/org/hibernate/metamodel/internal/EntityRepresentationStrategyPojoStandard.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/AbstractEmbeddableMapping.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/DiscriminatedAssociationMapping.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/DiscriminatedCollectionPart.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/EmbeddableMappingTypeImpl.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/IdClassEmbeddable.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/ManyToManyCollectionPart.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/MappingModelCreationHelper.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/SimpleNaturalIdMapping.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/VirtualIdRepresentationStrategy.java M hibernate-core/src/main/java/org/hibernate/metamodel/spi/RuntimeModelCreationContext.java M hibernate-core/src/main/java/org/hibernate/persister/collection/AbstractCollectionPersister.java M hibernate-core/src/main/java/org/hibernate/persister/collection/OneToManyPersister.java M hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java M hibernate-core/src/main/java/org/hibernate/persister/entity/JoinedSubclassEntityPersister.java M hibernate-core/src/main/java/org/hibernate/persister/entity/SingleTableEntityPersister.java M hibernate-core/src/main/java/org/hibernate/persister/entity/UnionSubclassEntityPersister.java M hibernate-core/src/main/java/org/hibernate/query/sqm/mutation/internal/SqmMutationStrategyHelper.java M hibernate-core/src/main/java/org/hibernate/query/sqm/mutation/internal/cte/CteInsertStrategy.java M hibernate-core/src/main/java/org/hibernate/query/sqm/mutation/internal/cte/CteMutationStrategy.java M hibernate-core/src/main/java/org/hibernate/tuple/entity/EntityMetamodel.java M hibernate-core/src/main/java/org/hibernate/type/Type.java Log Message: ----------- further reduce direct use of SessionFactory during metamodel building Commit: aeabc0e48e5ecd5b96c60576ede86ba3e5ae9e12 https://github.com/hibernate/hibernate-orm/commit/aeabc0e48e5ecd5b96c6057... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/mapping/PersistentClass.java Log Message: ----------- eliminate SQL parsing when there are no secondary tables Commit: f385fa063ac16a4cb76b0d0b84beda9b84358348 https://github.com/hibernate/hibernate-orm/commit/f385fa063ac16a4cb76b0d0... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/annotations/Check.java M hibernate-core/src/main/java/org/hibernate/annotations/Checks.java M hibernate-core/src/main/java/org/hibernate/annotations/Comment.java M hibernate-core/src/main/java/org/hibernate/annotations/Formula.java M hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java M hibernate-core/src/main/java/org/hibernate/boot/model/internal/AnnotatedColumn.java M hibernate-core/src/main/java/org/hibernate/boot/model/internal/CollectionBinder.java M hibernate-core/src/main/java/org/hibernate/boot/model/internal/EntityBinder.java M hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/RelationalObjectBinder.java M hibernate-core/src/main/java/org/hibernate/mapping/AggregateColumn.java M hibernate-core/src/main/java/org/hibernate/mapping/BasicValue.java M hibernate-core/src/main/java/org/hibernate/mapping/Column.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/ManyToManyCollectionPart.java M hibernate-core/src/main/java/org/hibernate/query/internal/NamedObjectRepositoryImpl.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/ColumnDefinitions.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/StandardTableExporter.java Log Message: ----------- consistently allow multiple @Check constraints + improvements to jdoc of @Formula and @Check Commit: b7f34795df817055080126b19e75bf862cad6ff6 https://github.com/hibernate/hibernate-orm/commit/b7f34795df817055080126b... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/mapping/CheckConstraint.java M hibernate-core/src/main/java/org/hibernate/mapping/Column.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/ColumnDefinitions.java Log Message: ----------- fix for databases which don't like multiple 'check' keywords - also check for dupe constraints (for some reason they get added) Compare: https://github.com/hibernate/hibernate-orm/compare/90c767681e1f...b7f3479...