[hibernate-commits] [hibernate/hibernate-orm] d72856: HHH-17406 Retrieve arbitrary on-execution generate...

Branch: refs/heads/main Home: https://github.com/hibernate/hibernate-orm Commit: d72856fef02cdc173ca8c81ef02c61118904020b https://github.com/hibernate/hibernate-orm/commit/d72856fef02cdc173ca8c81... Author: Marco Belladelli <marco(a)hibernate.org&gt; Date: 2023-12-22 (Fri, 22 Dec 2023) Changed paths: M hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DB2LegacySqlAstTranslator.java M hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/H2LegacySqlAstTranslator.java M hibernate-core/src/main/java/org/hibernate/action/internal/AbstractEntityInsertAction.java M hibernate-core/src/main/java/org/hibernate/action/internal/EntityIdentityInsertAction.java M hibernate-core/src/main/java/org/hibernate/action/internal/EntityInsertAction.java M hibernate-core/src/main/java/org/hibernate/action/internal/EntityUpdateAction.java M hibernate-core/src/main/java/org/hibernate/dialect/DB2Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/DB2SqlAstTranslator.java M hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/H2Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/H2SqlAstTranslator.java M hibernate-core/src/main/java/org/hibernate/dialect/MariaDBDialect.java M hibernate-core/src/main/java/org/hibernate/dialect/identity/IdentityColumnSupport.java M hibernate-core/src/main/java/org/hibernate/dialect/identity/IdentityColumnSupportImpl.java A hibernate-core/src/main/java/org/hibernate/dialect/identity/MariaDBIdentityColumnSupport.java M hibernate-core/src/main/java/org/hibernate/dialect/identity/Oracle12cGetGeneratedKeysDelegate.java M hibernate-core/src/main/java/org/hibernate/dialect/identity/Oracle12cIdentityColumnSupport.java M hibernate-core/src/main/java/org/hibernate/dialect/identity/SybaseJconnIdentityColumnSupport.java M hibernate-core/src/main/java/org/hibernate/engine/internal/StatefulPersistenceContext.java M hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/HighlightingFormatter.java M hibernate-core/src/main/java/org/hibernate/engine/jdbc/mutation/MutationExecutor.java M hibernate-core/src/main/java/org/hibernate/engine/jdbc/mutation/internal/AbstractMutationExecutor.java M hibernate-core/src/main/java/org/hibernate/engine/jdbc/mutation/internal/ModelMutationHelper.java R hibernate-core/src/main/java/org/hibernate/engine/jdbc/mutation/internal/MutationExecutorPostInsert.java R hibernate-core/src/main/java/org/hibernate/engine/jdbc/mutation/internal/MutationExecutorPostInsertSingleTable.java M hibernate-core/src/main/java/org/hibernate/engine/jdbc/mutation/internal/MutationExecutorSingleNonBatched.java M hibernate-core/src/main/java/org/hibernate/engine/jdbc/mutation/internal/MutationExecutorStandard.java M hibernate-core/src/main/java/org/hibernate/engine/jdbc/mutation/internal/PreparedStatementGroupSingleTable.java M hibernate-core/src/main/java/org/hibernate/engine/jdbc/mutation/internal/PreparedStatementGroupStandard.java M hibernate-core/src/main/java/org/hibernate/engine/jdbc/mutation/internal/StandardMutationExecutorService.java M hibernate-core/src/main/java/org/hibernate/engine/spi/PersistenceContext.java M hibernate-core/src/main/java/org/hibernate/generator/OnExecutionGenerator.java A hibernate-core/src/main/java/org/hibernate/generator/values/AbstractGeneratedValuesMutationDelegate.java A hibernate-core/src/main/java/org/hibernate/generator/values/GeneratedValueBasicResultBuilder.java A hibernate-core/src/main/java/org/hibernate/generator/values/GeneratedValues.java A hibernate-core/src/main/java/org/hibernate/generator/values/GeneratedValuesMutationDelegate.java A hibernate-core/src/main/java/org/hibernate/generator/values/internal/GeneratedValuesHelper.java A hibernate-core/src/main/java/org/hibernate/generator/values/internal/GeneratedValuesImpl.java A hibernate-core/src/main/java/org/hibernate/generator/values/internal/GeneratedValuesMappingProducer.java A hibernate-core/src/main/java/org/hibernate/generator/values/internal/TableUpdateReturningBuilder.java A hibernate-core/src/main/java/org/hibernate/generator/values/package-info.java M hibernate-core/src/main/java/org/hibernate/id/IdentifierGeneratorHelper.java M hibernate-core/src/main/java/org/hibernate/id/IdentityGenerator.java M hibernate-core/src/main/java/org/hibernate/id/PostInsertIdentityPersister.java M hibernate-core/src/main/java/org/hibernate/id/insert/AbstractReturningDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/AbstractSelectingDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/BasicSelectingDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/GetGeneratedKeysDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/InsertGeneratedIdentifierDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/InsertReturningDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/InsertSelectIdentityInsert.java M hibernate-core/src/main/java/org/hibernate/id/insert/SybaseJConnGetGeneratedKeysDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/TableInsertReturningBuilder.java M hibernate-core/src/main/java/org/hibernate/id/insert/UniqueKeySelectingDelegate.java M hibernate-core/src/main/java/org/hibernate/internal/StatelessSessionImpl.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/BasicValuedModelPart.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/EntityRowIdMapping.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/ModelPart.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/EntityRowIdMappingImpl.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/GeneratedValuesProcessor.java M hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java M hibernate-core/src/main/java/org/hibernate/persister/entity/EntityPersister.java M hibernate-core/src/main/java/org/hibernate/persister/entity/JoinedSubclassEntityPersister.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/EntityMutationTarget.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/InsertCoordinator.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/MergeCoordinator.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/UpdateCoordinator.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/UpdateCoordinatorNoOp.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/UpdateCoordinatorStandard.java M hibernate-core/src/main/java/org/hibernate/query/results/ResultsHelper.java M hibernate-core/src/main/java/org/hibernate/query/sqm/mutation/internal/temptable/InsertExecutionDelegate.java M hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java M hibernate-core/src/main/java/org/hibernate/sql/model/EntityMutationOperationGroup.java M hibernate-core/src/main/java/org/hibernate/sql/model/PreparableMutationOperation.java M hibernate-core/src/main/java/org/hibernate/sql/model/ast/TableInsert.java M hibernate-core/src/main/java/org/hibernate/sql/model/ast/TableUpdate.java M hibernate-core/src/main/java/org/hibernate/sql/model/ast/builder/CollectionRowDeleteByUpdateSetNullBuilder.java M hibernate-core/src/main/java/org/hibernate/sql/model/ast/builder/TableUpdateBuilderStandard.java M hibernate-core/src/main/java/org/hibernate/sql/model/internal/TableUpdateCustomSql.java M hibernate-core/src/main/java/org/hibernate/sql/model/internal/TableUpdateNoSet.java M hibernate-core/src/main/java/org/hibernate/sql/model/internal/TableUpdateStandard.java M hibernate-core/src/test/java/org/hibernate/orm/test/cfg/persister/GoofyPersisterClassProvider.java M hibernate-core/src/test/java/org/hibernate/orm/test/jpa/ejb3configuration/PersisterClassProviderTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/legacy/CustomPersister.java A hibernate-core/src/test/java/org/hibernate/orm/test/mapping/generated/delegate/MutationDelegateIdentityTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/mapping/generated/delegate/MutationDelegateJoinedInheritanceTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/mapping/generated/delegate/MutationDelegateTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/rowid/RowIdUpdateAndDeleteTest.java Log Message: ----------- HHH-17406 Retrieve arbitrary on-execution generated values efficiently Commit: 599be8930854db246931db72eab06493a3ddbabb https://github.com/hibernate/hibernate-orm/commit/599be8930854db246931db7... Author: Marco Belladelli <marco(a)hibernate.org&gt; Date: 2023-12-22 (Fri, 22 Dec 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/action/internal/EntityDeleteAction.java M hibernate-core/src/main/java/org/hibernate/action/internal/EntityInsertAction.java M hibernate-core/src/main/java/org/hibernate/action/internal/EntityUpdateAction.java M hibernate-core/src/main/java/org/hibernate/id/insert/UniqueKeySelectingDelegate.java M hibernate-core/src/main/java/org/hibernate/internal/StatelessSessionImpl.java M hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java M hibernate-core/src/main/java/org/hibernate/persister/entity/EntityPersister.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/AbstractDeleteCoordinator.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/DeleteCoordinator.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/InsertCoordinator.java A hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/InsertCoordinatorStandard.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/MergeCoordinator.java A hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/MutationCoordinator.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/UpdateCoordinator.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/UpdateCoordinatorNoOp.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/UpdateCoordinatorStandard.java M hibernate-core/src/test/java/org/hibernate/orm/test/boot/database/qualfiedTableNaming/DefaultCatalogAndSchemaTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/cfg/persister/GoofyPersisterClassProvider.java M hibernate-core/src/test/java/org/hibernate/orm/test/jpa/ejb3configuration/PersisterClassProviderTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/legacy/CustomPersister.java M hibernate-core/src/test/java/org/hibernate/orm/test/persister/entity/CustomSqlSchemaResolvingIdentityTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/persister/entity/CustomSqlSchemaResolvingTest.java Log Message: ----------- HHH-17406 Change EntityPersister mutation api to expose coordinators Commit: 3ac0b8cb5e6b1234139f10c860fa72c166b714ed https://github.com/hibernate/hibernate-orm/commit/3ac0b8cb5e6b1234139f10c... Author: Marco Belladelli <marco(a)hibernate.org&gt; Date: 2023-12-22 (Fri, 22 Dec 2023) Changed paths: M hibernate-core/src/main/java/org/hibernate/boot/query/HbmResultSetMappingDescriptor.java M hibernate-core/src/main/java/org/hibernate/boot/query/SqlResultSetMappingDescriptor.java M hibernate-core/src/main/java/org/hibernate/loader/ast/internal/LoaderSelectBuilder.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/MappingModelHelper.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/AbstractDomainPath.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/ManyToManyCollectionPart.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/MappingModelCreationHelper.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/SimpleForeignKeyDescriptor.java M hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java M hibernate-core/src/main/java/org/hibernate/query/internal/ImplicitModelPartResultMemento.java M hibernate-core/src/main/java/org/hibernate/query/internal/ResultMementoEntityJpa.java M hibernate-core/src/main/java/org/hibernate/query/results/Builders.java M hibernate-core/src/main/java/org/hibernate/query/results/dynamic/DynamicFetchBuilderStandard.java M hibernate-core/src/main/java/org/hibernate/query/sqm/mutation/internal/inline/InPredicateRestrictionProducer.java M hibernate-core/src/main/java/org/hibernate/query/sqm/sql/BaseSqmToSqlAstConverter.java M hibernate-core/src/main/java/org/hibernate/query/sqm/sql/internal/BasicValuedPathInterpretation.java M hibernate-core/src/main/java/org/hibernate/query/sqm/sql/internal/EntityValuedPathInterpretation.java Log Message: ----------- HHH-17406 Remove instanceof / cast usages of `BasicValuedModelPart` This should help with type pollution, though it's not strictly needed for the scope of the generated values change. Compare: https://github.com/hibernate/hibernate-orm/compare/58173f92eef2...3ac0b8c...