[hibernate-commits] [hibernate/hibernate-search] 83da2d: HSEARCH-2742 Make JsonAccessor capable of retrievi...

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-search Commit: 83da2d036deb127615cee1c8443af5c0bff2c452 https://github.com/hibernate/hibernate-search/commit/83da2d036deb127615ce... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-05-30 (Tue, 30 May 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/dialect/impl/DefaultElasticsearchDialectFactory.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/ArrayElementJsonAccessor.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/CrawlingJsonAccessor.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/JsonAccessor.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/JsonArrayAccessor.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/JsonArrayAccessorImpl.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/JsonBooleanAccessorImpl.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/JsonCompositeAccessor.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/JsonDoubleAccessorImpl.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/JsonElementType.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/JsonFloatAccessorImpl.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/JsonIntegerAccessorImpl.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/JsonLongAccessorImpl.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/JsonObjectAccessor.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/JsonObjectAccessorImpl.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/JsonStringAccessorImpl.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/NonRootJsonAccessor.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/ObjectPropertyJsonAccessor.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/RootJsonAccessor.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/TypingJsonAccessor.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/UnexpectedJsonElementTypeException.java A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/UnknownTypeJsonAccessor.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexWorkVisitor.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/JsonAccessorBuilder.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/work/impl/DefaultElasticsearchRequestSuccessAssessor.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/work/impl/SearchWork.java M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/testutil/ElasticsearchBackendTestHelper.java Log Message: ----------- HSEARCH-2742 Make JsonAccessor capable of retrieving primitive values directly ... so that we avoid NPEs when we call getAsString() on a JsonPrimitive that in fact is null. After this patch, the same situation will simply result in a null String. Commit: 5cf1700fa1e9cb2ff3987b05d3585aa7554ca129 https://github.com/hibernate/hibernate-search/commit/5cf1700fa1e9cb2ff398... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2017-05-30 (Tue, 30 May 2017) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/dialect/impl/DefaultElasticsearchDialectFactory.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/CrawlingJsonAccessor.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/JsonAccessor.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/RootJsonAccessor.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/gson/impl/TypingJsonAccessor.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/work/impl/DefaultElasticsearchRequestSuccessAssessor.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/work/impl/SearchWork.java M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/testutil/ElasticsearchBackendTestHelper.java Log Message: ----------- HSEARCH-2742 Make JsonAccessor.get return an Optional ... so that we always handle missing values explicitly, in particular throwing exceptions only if a missing value is actually a problem. Compare: https://github.com/hibernate/hibernate-search/compare/a4699341cf58...5cf1...