[hibernate-commits] [hibernate/hibernate-orm] d23dff: HHH-19266 fix multiple bugs and inconsistencies in...

Branch: refs/heads/main Home: https://github.com/hibernate/hibernate-orm Commit: d23dff82737e678bd061126fe7441b7ed9b75879 https://github.com/hibernate/hibernate-orm/commit/d23dff82737e678bd061126... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2025-03-18 (Tue, 18 Mar 2025) Changed paths: M hibernate-core/src/main/java/org/hibernate/ScrollMode.java M hibernate-core/src/main/java/org/hibernate/ScrollableResults.java M hibernate-core/src/main/java/org/hibernate/internal/FetchingScrollableResultsImpl.java M hibernate-core/src/main/java/org/hibernate/internal/ScrollableResultsImpl.java M hibernate-core/src/main/java/org/hibernate/query/SelectionQuery.java M hibernate-core/src/test/java/org/hibernate/orm/test/hql/ScrollableCollectionFetchingTest.java Log Message: ----------- HHH-19266 fix multiple bugs and inconsistencies in ScrollableResults impls 1. fix setRowNumber(-n) 2. number rows from 1 instead of 0 3. fix position() Item 2 is a change to the documented behavior, but the documented behavior was already inconsistently implemented. Commit: 9a7b95b627aa5c698d9c39724591acff7554fdfd https://github.com/hibernate/hibernate-orm/commit/9a7b95b627aa5c698d9c397... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2025-03-18 (Tue, 18 Mar 2025) Changed paths: M hibernate-core/src/main/java/org/hibernate/query/spi/AbstractSelectionQuery.java M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/ConcreteSqmSelectQueryPlan.java M hibernate-core/src/main/java/org/hibernate/sql/exec/internal/JdbcSelectExecutorStandardImpl.java Log Message: ----------- misc code cleanups Commit: 74ecc8bf7ff02d9e53a68bd837616cc4c6f012bf https://github.com/hibernate/hibernate-orm/commit/74ecc8bf7ff02d9e53a68bd... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2025-03-18 (Tue, 18 Mar 2025) Changed paths: M hibernate-core/src/main/java/org/hibernate/ScrollableResults.java M hibernate-core/src/main/java/org/hibernate/internal/EmptyScrollableResults.java M hibernate-core/src/main/java/org/hibernate/internal/FetchingScrollableResultsImpl.java M hibernate-core/src/main/java/org/hibernate/internal/ScrollableResultsImpl.java M hibernate-core/src/main/java/org/hibernate/sql/results/jdbc/internal/JdbcValuesCacheHit.java M hibernate-core/src/main/java/org/hibernate/sql/results/jdbc/internal/JdbcValuesResultSetImpl.java M hibernate-core/src/test/java/org/hibernate/orm/test/hql/ScrollableCollectionFetchingTest.java Log Message: ----------- HHH-19266 add getPosition() and deprecate get/setRowNumber() since position() was a dupe of setRowNumber() Commit: b74e76d23f1f8f191ce74cebd44259a35e0ca373 https://github.com/hibernate/hibernate-orm/commit/b74e76d23f1f8f191ce74ce... Author: Gavin King <gavin(a)hibernate.org&gt; Date: 2025-03-18 (Tue, 18 Mar 2025) Changed paths: M hibernate-core/src/main/java/org/hibernate/ScrollableResults.java M hibernate-core/src/main/java/org/hibernate/internal/EmptyScrollableResults.java M hibernate-core/src/main/java/org/hibernate/internal/FetchingScrollableResultsImpl.java M hibernate-core/src/main/java/org/hibernate/internal/ScrollableResultsImpl.java M hibernate-core/src/test/java/org/hibernate/orm/test/hql/ScrollableCollectionFetchingTest.java Log Message: ----------- HHH-19266 make getRowNumber() return getPosition() - 1 for better backward-compatibility Compare: https://github.com/hibernate/hibernate-orm/compare/b485b74631b7...b74e76d... To unsubscribe from these emails, change your notification settings at https://github.com/hibernate/hibernate-orm/settings/notifications