On 8/24/11 4:08 PM, Stuart Douglas wrote:
Hi Guys,
While looking at some EJB3 stuff I began to wonder just how much stuff
from the JBoss EJB3 maven artefacts we actually use. Even though there
is a lot of artefacts, it turns out that we use around 75 classes from
EJB3, and more than half of them are timer service related (It looks
like a lot of the stuff in the EJB3 package is either legacy stuff that
is just hanging around).
Given that the majority of the actual EJB logic / implementation is in
the AS modules (in the EJB and EE modules), I was wondering if it would
be worth merging the whole of EJB into AS7 and dumping the EJB3
aggregator project altogether.
I have a branch that does this here (although this branch has not
migrated any tests yet):
https://github.com/stuartwdouglas/jboss-as/tree/remove
Personally I think this would make it much easier to refactor, and would
also allow us to remove some adaptor classes between AS7 and EJB3 (e.g.
AS7 has to sub class the EJB3 interceptors, rather than EJB3 providing
real jboss invocation interceptors).
I agree 1000% on this. In the past we had already decided to keep the
ejb3 impl in the AS tree, so I think we should avoid splitting off
components that are purely ejb3 specific and don't have use elsewhere.
I haven't reviewed all of this patch, but one thing that I had noticed
earlier is that we have some code that was just copied over and not
really in use (e.g. some broken pool implementations). IMO if we aren't
using / supporting stuff in AS we should just not carry it over.
--
Jason T. Greene
JBoss AS Lead / EAP Platform Architect
JBoss, a division of Red Hat