Re: [jboss-as7-dev] Request for review of DomainServletApi bridge
On 06/08/2011 10:06 PM, Scott Stark wrote:
This is not a pull request, just a review request.
Yeah we are just reviewing if making the management APIs available
through JBoss Web fits with the decisions / approach already taken ;-) -
so far we have been able to consider the management APIs isolated from
the actual AS.
Do you have any idea of the timescale for this? Is this something you
are looking to have in 7.0.0 or 7.1.0?
Reviewing the code I am not sure if the following line is really
applicable: -
if (welcome && defaultWebModule != null)
throw new XMLStreamException("The domain-api can not be enabled on a
host that has a default web module", reader.getLocation());
The purpose of this in the welcome context was to ensure that there are
not two apps deployed to the root context.
I'll be testing stuff
out on my own branch as part of the openshift testing before creating
anything to merge. The DomainServletApi and /domain-api context are not
added by default in this set of changes for review.
So, I ran into at first choosing the wrong service name for the source
of the ModelController being
org.jboss.as.domain.controller.DomainController.SERVICE_NAME vs
org.jboss.as.server.Services.JBOSS_SERVER_CONTROLLER. Is it correct that
the former is only available when running in domain mode and the lack of
a Services.JBOSS_SERVER_CONTROLLER indicates that standalone mode is not
active?
On 6/8/11 1:39 PM, Brian Stansberry wrote:
>
> I'll defer to Darran on the security aspects of this; i.e. how to ensure
> that this webapp integrates with management layer's security configuration.
>
> If we do this, it shouldn't be enabled by default for the reasons Darran
> mentioned. But the patch doesn't seem to have it on by default.
>
> We'll need to disable this capability for a server running in domain
> mode, as a domain mode server is not meant to expose a
> directly-accessible-to-the-end-user management interface. The host
> controller exposes that.
>
_______________________________________________
jboss-as7-dev mailing list
jboss-as7-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev