Re: [jboss-as7-dev] What to do about jboss-common-core?
On 03/07/2012 02:58 PM, Brian Stansberry wrote:
Absolutely this stuff can't go into the controller module.
That's
completely out of the question. Nothing should go in controller that
isn't related to core management. A subsystem is not core management. If
something is only needed for a subsystem, it doesn't go into controller.
I don't want it in server either, although that module is a closer fit
since it has a bunch of stuff that subsystems need (e.g. the deployment
processing infrastructure.) Ideally we'd have split that "needed by
subsystems stuff" out from "needed to run a core server" stuff before
7.0.0, but we didn't have time. I see the split as an AS 8 thing. But I
don't want to make the server module a complete dumping ground.
I would also say avoid server - that also pops up in the cyclic
dependencies I keep hitting that need splitting - the split you describe
for server is probably the same split I need so probably better not to
increase the dependencies on it.
I am also against a common or varia style module but not so much that we
break existing dependencies by overloading an existing module.
On 3/7/12 8:40 AM, Darran Lofthouse wrote:
> I have already started to run into circular dependency issues with the
> controller module when trying to connect together security from multiple
> area - I am planning soon to review these dependencies again but I think
> at this stage turning it into another common is just going to make it worse.
>
> Regards,
> Darran Lofthouse.
>
>
> On 03/07/2012 02:35 PM, Brian Stansberry wrote:
>> We need to decide what we want to do about usage of the
>> jboss-common-core library.
>>
>> A pull request[1] has come in that brings a bunch of jboss-common-core
>> classes into the AS 7 codebase.
>>
>> I know in the past we've discouraged use of jboss-common-core for
>> various reasons, the biggest AIUI being:
>>
>> 1) It's a dumping ground that brings in a lot of unnecessary classes.
>> 2) Some of the stuff in there may not be well suited to AS 7 but is well
>> suited to earlier, supported releases. So to use it in both basically
>> means a semi-fork (i.e. branch it.) Forks increase maintenance burdens.
>>
>> But pulling a bunch of classes out of it and into the AS itself is just
>> going to turn some module of the AS into a dumping ground. And it's
>> essentially a fork, but one where the forked code is in completely
>> separate code bases. I'd rather have people use jboss-common-core than
>> do that.
>>
>>
>> [1] https://github.com/jbossas/jboss-as/pull/1739
>>
>>
>>
> _______________________________________________
> jboss-as7-dev mailing list
> jboss-as7-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev