10:04 a.m.
Done. However I don't think we can use your testsuite structure as it is
now. You keep the test sources in testsuite/integration/src but
introduce a number of new maven modules that refer to those sources.
This breaks maven convention and the IDE gets confused. The maven source
artefacts would also not contain the expected sources. If possible
please move the test sources to their respective modules.
If test sources really need to get shared between maven modules, you
could have a look at the demos. I believe those sources are reused by
the testsuite (at least in the past). Hence you could have a module
'testsuite/shared' or something similar.
cheers
-thomas
On 11/18/2011 09:46 AM, Thomas Diesler wrote:
yes, I can do this today.
On 11/18/2011 09:47 AM, Ondřej Žižka wrote:
> Hi Thomas,
>
> could you please update the OSGi tests to use the jboss.ts.integ.dir
> property instead of assuming it runs in testsuite/integration?
> The working dir will change.
> I'd change it myself but it's outside of AS project.
>
> Also, I need it get fixed to get the updated testsuite merged ASAP,
> so I'd be very happy if you had a minute for this before monday.
>
> Thanks,
> Ondra
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
12:23 p.m.
Hi,
If the IDE was correctly programmed, it would honour
<testSourceDirectory>.
Since maven convention is not described anywhere, it's subjective, so we
can say it only breaks Eclipse's integration - In NetBeans it works
pretty fine :)
Also, I'm quite sure we will never ship testsuite source artifacts -
there's no sense in that.
But anyway, taken pragmatically - if it causes real troubles, I'll move
the sources.
But first we need to merge PR 697, I will base all further changes on
it.
Ondra
Thomas Diesler píše v Pá 18. 11. 2011 v 17:04 +0100:
Done. However I don't think we can use your testsuite structure
as it
is now. You keep the test sources in testsuite/integration/src but
introduce a number of new maven modules that refer to those sources.
This breaks maven convention and the IDE gets confused. The maven
source artefacts would also not contain the expected sources. If
possible please move the test sources to their respective modules.
If test sources really need to get shared between maven modules, you
could have a look at the demos. I believe those sources are reused by
the testsuite (at least in the past). Hence you could have a module
'testsuite/shared' or something similar.
cheers
-thomas
On 11/18/2011 09:46 AM, Thomas Diesler wrote:
> yes, I can do this today.
>
> On 11/18/2011 09:47 AM, Ondřej Žižka wrote:
>
> > Hi Thomas,
> >
> > could you please update the OSGi tests to use the
> > jboss.ts.integ.dir property instead of assuming it runs in
> > testsuite/integration?
> > The working dir will change.
> > I'd change it myself but it's outside of AS project.
> >
> > Also, I need it get fixed to get the updated testsuite merged
> > ASAP, so I'd be very happy if you had a minute for this before
> > monday.
> >
> > Thanks,
> > Ondra
>
>
>
> --
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Thomas Diesler
> JBoss OSGi Lead
> JBoss, a division of Red Hat
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
2:01 a.m.
Doing things 'pragmatically' would mean you put the sources in the
modules where they are used. Otherwise this just creates entropy and
confusion.
-thomas
On 11/22/2011 07:23 PM, Ondřej Žižka wrote:
Hi,
If the IDE was correctly programmed, it would honour
<testSourceDirectory>.
Since maven convention is not described anywhere, it's subjective, so
we can say it only breaks Eclipse's integration - In NetBeans it works
pretty fine :)
Also, I'm quite sure we will never ship testsuite source artifacts -
there's no sense in that.
But anyway, taken pragmatically - if it causes real troubles, I'll
move the sources.
But first we need to merge PR 697, I will base all further changes on it.
Ondra
Thomas Diesler píše v Pá 18. 11. 2011 v 17:04 +0100:
> Done. However I don't think we can use your testsuite structure as it
> is now. You keep the test sources in testsuite/integration/src but
> introduce a number of new maven modules that refer to those sources.
> This breaks maven convention and the IDE gets confused. The maven
> source artefacts would also not contain the expected sources. If
> possible please move the test sources to their respective modules.
>
> If test sources really need to get shared between maven modules, you
> could have a look at the demos. I believe those sources are reused by
> the testsuite (at least in the past). Hence you could have a module
> 'testsuite/shared' or something similar.
>
> cheers
> -thomas
>
> On 11/18/2011 09:46 AM, Thomas Diesler wrote:
>> yes, I can do this today.
>>
>> On 11/18/2011 09:47 AM, Ondřej Žižka wrote:
>>> Hi Thomas,
>>>
>>> could you please update the OSGi tests to use the
>>> jboss.ts.integ.dir property instead of assuming it runs in
>>> testsuite/integration?
>>> The working dir will change.
>>> I'd change it myself but it's outside of AS project.
>>>
>>> Also, I need it get fixed to get the updated testsuite merged ASAP,
>>> so I'd be very happy if you had a minute for this before monday.
>>>
>>> Thanks,
>>> Ondra
>>
>> --
>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>> Thomas Diesler
>> JBoss OSGi Lead
>> JBoss, a division of Red Hat
>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>
> --
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Thomas Diesler
> JBoss OSGi Lead
> JBoss, a division of Red Hat
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
9:41 a.m.
On Nov 22, 2011, at 19:23, Ondřej Žižka wrote:
Hi,
If the IDE was correctly programmed, it would honour <testSourceDirectory>.
Since maven convention is not described anywhere, it's subjective, so we can say it
only breaks Eclipse's integration - In NetBeans it works pretty fine :)
Then go fix Eclipse m2e integration - which btw. is written by those defining the maven
conventions :)
Just because one IDE allows it doesn't make it right.
And I know Eclipse has issues (i.e. only one classpath per project) but thats unfortunate
and something that isn't changing anytime soon.
/max
Also, I'm quite sure we will never ship testsuite source
artifacts - there's no sense in that.
But anyway, taken pragmatically - if it causes real troubles, I'll move the sources.
But first we need to merge PR 697, I will base all further changes on it.
Ondra
Thomas Diesler píše v Pá 18. 11. 2011 v 17:04 +0100:
> Done. However I don't think we can use your testsuite structure as it is now. You
keep the test sources in testsuite/integration/src but introduce a number of new maven
modules that refer to those sources. This breaks maven convention and the IDE gets
confused. The maven source artefacts would also not contain the expected sources. If
possible please move the test sources to their respective modules.
>
> If test sources really need to get shared between maven modules, you could have a
look at the demos. I believe those sources are reused by the testsuite (at least in the
past). Hence you could have a module 'testsuite/shared' or something similar.
>
> cheers
> -thomas
>
> On 11/18/2011 09:46 AM, Thomas Diesler wrote:
>> yes, I can do this today.
>>
>> On 11/18/2011 09:47 AM, Ondřej Žižka wrote:
>>> Hi Thomas,
>>>
>>> could you please update the OSGi tests to use the jboss.ts.integ.dir property
instead of assuming it runs in testsuite/integration?
>>> The working dir will change.
>>> I'd change it myself but it's outside of AS project.
>>>
>>> Also, I need it get fixed to get the updated testsuite merged ASAP, so
I'd be very happy if you had a minute for this before monday.
>>>
>>> Thanks,
>>> Ondra
>>
>> --
>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>> Thomas Diesler
>> JBoss OSGi Lead
>> JBoss, a division of Red Hat
>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>>
>
> --
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Thomas Diesler
> JBoss OSGi Lead
> JBoss, a division of Red Hat
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>
_______________________________________________
jboss-as7-dev mailing list
jboss-as7-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
/max
http://about.me/maxandersen
5064
days inactive
5069
days old
3 comments
3 participants
participants (3)
-
Max Rydahl Andersen -
Ondřej Žižka -
Thomas Diesler