[jboss-jira] [JBoss JIRA] Issue Comment Edited: (JBLOGGING-57) Logic for selecting a provider is too fragile

[ https://issues.jboss.org/browse/JBLOGGING-57?page=com.atlassian.jira.plug... ] Dan Allen edited comment on JBLOGGING-57 at 3/23/11 3:37 PM: ------------------------------------------------------------- I just think it would be cleaner to have a single try/catch, but I guess that is a style choice. In general, though, the check for the class alone is really not sufficient, as you pointed out. I think returning an incompatible version is itself a failure (enough to force the use of the JDK14 logger). So I stick to my original guns and say that this logic is too frail in its current form. And that goes for even the slf4j and log4j checks (assuming API incompatibilities are a possibility there too). was (Author: dan.j.allen): I just think it would be cleaner to have a single try/catch, but I guess that is a style choice. In general, though, the check for the class alone is really not sufficient, as you pointed out. I think returning an incompatible version is itself a failure (enough to force the use of the JDK14 logger). So I stick to my original guns and say that this logic is too frail in it's current form. And that goes for even the slf4j and log4j checks (assuming API incompatibilities are a possibility there too). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira