[
https://issues.redhat.com/browse/WFLY-12815?page=com.atlassian.jira.plugi...
]
Matěj Novotný commented on WFLY-12815:
--------------------------------------
Looks like this issue got snowed under, sorry for that.
Re-reading it, I think it also depends on what exactly is supposed to happen if a session
lifecycle listener throws an exception - do you process other listener(s) or not? Looking
at [servlet
specification|https://jakarta.ee/specifications/servlet/5.0/servlet-spec-5.0-SNAPSHOT.html#listener-exceptions],
I get the feeling you stop processing listeners with the first one that throws an
exception (which is what you see happening). Weld has the last listener which tears down
context and if you don't get there, it will stay active leading to the error you are
seeing. Notably the specification also says:
{quote}bq. Developers wishing normal processing to occur after a listener generates an
exception must handle their own exceptions within the notification methods.
{quote}
So the safest workflow here is to simply catch your exceptions inside listeners.
What we can do on Weld side is that we check if destruction context is active while trying
to activate a standard one (which
happens [here|https://github.com/weld/core/blob/master/modules/web/src/ma...)
and if that's the case, we deactivate it and perform some logging. That should return
the thread to non-corrupted state although I can't say it if won't break anything
else. I will try to compose a PR for that a test it with CDI and then WFLY tests. If that
passes, I will let you know so that you can try that with your setup which corrupts all
threads, would that work for you [~nuno.godinhomatos]?
Wildfly 13 - Thread local state corrupted by deployed application
explosion during session timeout leading to WELD-001304 - More than one context active
for scope type javax.enterprise.context.SessionScoped
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: WFLY-12815
URL:
https://issues.redhat.com/browse/WFLY-12815
Project: WildFly
Issue Type: Bug
Components: CDI / Weld
Affects Versions: 13.0.0.Final
Environment: Environment independent the issue, it is purely a logical problem
Reporter: NUNO GODINHO DE MATOS
Assignee: Matěj Novotný
Priority: Major
Attachments: sourceCodeToSendToWildfly.7z
The full description of the problem can be seen in stack overflow.
Please consulder the issue:
https://stackoverflow.com/questions/58930939/wildflt-13-weld-001304-more-...
SUMMARY:
(1) Setup you wildfly to have a session timeout of 1 minute - so that you can esaily make
your http sessions timeout
(2) Program in your WAR application a sessionDestroyed listener that will be broken.
In our case whenever the session is timing out, we have some code that explodes in
wildfly and not in weblogic because it expected for the RequestScope context to be active,
but apparently in wildfly when Undertow to start killing of a session the request scope
context is not made active so that caused our session destroyed handling to break
(3) Do this sufficient amount of times to corrupted as may threads in the thread pool as
possible
(4) Now try to interact with your application making use of some session scoped beans .
If you travel to ay sort of view that makes use of a session scoped bean that thread will
be broken with the exception that multiple session scope context implementation are
active.
But this exception will only come out and aply if the thread handling the HTTP request is
one of the threads that in the past were used by undertow to handle the session timeout.
The only threads that have been corrupted forever are those that had a broken sessin
timeout
Explanation for the issue:
- When the session timeout is being orchestrated by underdow, wildfly is activating a
special HttpSessionDescrutionContext and making it active.
This ACTIVE TRUE/FALSE flag is a ThreadLocal variable.
So the activation of the scope context is marked on the thread itself.
- When the thread blows up the thread context will remain for as long at the thread
lives
- in a future request the flag had that thread local variable active already.
So when the BeanManagaerImpl is hunting to the one and only active http session context
it finds the traditional happy path http session context active plust the
DestructionSession context that was activated in a previous call.
All of the illustrative stack traces that facilitate the comprehention of the issue are
shown in the stack overflow thread.
I am of the oppinion that errors like this can happen in the deployed applications.
It would not hurt if wildfly would somehow be able to ensure that the thread that hand an
explosion in a previous request is not corrupted when it is used to handle new requests.
Many thanks for having a look.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)