[
http://jira.jboss.com/jira/browse/JBPORTAL-1346?page=comments#action_1236... ]
Matt Wringe commented on JBPORTAL-1346:
---------------------------------------
So are you just suggesting just removing the get() method from the parent class and adding
it to the child classes (changing the return value for the MultiValuedTestParameterValue
to Collection instead of Object):
MonoValuedTestParameterValue { public Object get() { return value;}}
MultiValuedTestParameterValue { public Collection get() { return value;}}
Is this all that all that is required (and of course altering the code that relies on
these methods)? or am I missing something else here?
I am just a bit confused since a Collection is an Object anyways
Improve the parameter value handling
------------------------------------
Key: JBPORTAL-1346
URL:
http://jira.jboss.com/jira/browse/JBPORTAL-1346
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal QA
Reporter: Julien Viet
Assigned To: Matt Wringe
Fix For: 2.8 Final
we have :
MonoValuedTestParameterValue extends TestParameterValue
MultiValuedTestParameterValue extends TestParameterValue
and
TestParameterValue { public abstract Object getValue(); }
the method getValue() should not be here : a value is either mono valued or multi valued
and both have nothing in common, the code client of that needs to deal with both of them
explicitely.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira