7:25 a.m.
Usability: modifing configuration significantly changes the xml
---------------------------------------------------------------
Key: AS7-1840
URL: https://issues.jboss.org/browse/AS7-1840
Project: Application Server 7
Issue Type: Enhancement
Components: Server
Affects Versions: 7.0.1.Final, 7.0.0.Final
Reporter: Radoslav Husar
Assignee: Jason Greene
Related to AS7-442, there are multiple things that rapidly change from the standard
shipped XML.
This is major usability issue for people who try to figure out what are the changes in the
original XML and the current one. Here is a diff after adding just a sample DS:
The items are:
* indentation
* comments AS7-442
* whitespaces (" />" VS "/>")
* defaults implicit Vs explicit (i.e. autoflush="true")
* No newline at end of file
* attribute ordering (ie interface="management" port="8090" VS
port="8090" interface="management")
{code}
1c1,23
< <?xml version='1.0' encoding='UTF-8'?>
---
26,32c48,54
< <security-realms>
< <security-realm name="PropertiesMgmtSecurityRealm">
< <authentication>
< <properties path="mgmt-users.properties"
relative-to="jboss.server.config.dir"/>
< </authentication>
< </security-realm>
< </security-realms>
---
40c63
< <console-handler name="CONSOLE"
autoflush="true">
---
> <periodic-rotating-file-handler
name="FILE">
53d76
< <append value="true"/>
54a78
63a88
74,80c99,102
< <datasource jndi-name="java:jboss/datasources/ExampleDS"
pool-name="H2DS">
< <connection-url>
< jdbc:h2:mem:test;DB_CLOSE_DELAY=-1
< </connection-url>
< <driver>
< h2
< </driver>
---
> <!-- Session bean configurations -->
125,129c134
< <pools>
< <bean-instance-pools>
< <strict-max-pool name="slsb-strict-max-pool"
max-pool-size="20" instance-acquisition-timeout="5"
instance-acquisition-timeout-unit="MINUTES"/>
< </bean-instance-pools>
< </pools>
---
148,149c153,154
< <archive-validation enabled="false"/>
< <bean-validation enabled="false"/>
---
260c277
< <inet-address value="${jboss.bind.address:127.0.0.1}"/>
---
266,267c284,285
< <socket-binding name="jmx-connector-registry"
port="1090" interface="management"/>
< <socket-binding name="jmx-connector-server"
port="1091" interface="management"/>
---
> </server>
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
<!--
~ JBoss, Home of Professional Open Source.
~ Copyright 2011, Red Hat, Inc., and individual contributors
~ as indicated by the @author tags. See the copyright.txt file in the
~ distribution for a full listing of individual contributors.
~
~ This is free software; you can redistribute it and/or modify it
~ under the terms of the GNU Lesser General Public License as
~ published by the Free Software Foundation; either version 2.1 of
~ the License, or (at your option) any later version.
~
~ This software is distributed in the hope that it will be useful,
~ but WITHOUT ANY WARRANTY; without even the implied warranty of
~ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
~ Lesser General Public License for more details.
~
~ You should have received a copy of the GNU Lesser General Public
~ License along with this software; if not, write to the Free
~ Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
~ 02110-1301 USA, or see the FSF site: http://www.fsf.org.
-->
<server xmlns="urn:jboss:domain:1.0">
3d24
< <server name="rhusar.brq.redhat.com"
xmlns="urn:jboss:domain:1.0">
22,23c43,44
< <extension module="org.jboss.as.web"/>
< <extension module="org.jboss.as.weld"/>
---
<extension module="org.jboss.as.web" />
<extension module="org.jboss.as.weld" />
24a46
<security-realms>
<security-realm name="PropertiesMgmtSecurityRealm">
<authentication>
<properties path="mgmt-users.properties"
relative-to="jboss.server.config.dir" />
</authentication>
</security-realm>
</security-realms>
34,35c56,57
< <native-interface interface="management"
port="9999"/>
< <http-interface interface="management"
port="9990"/>
---
<native-interface interface="management"
port="9999" />
<http-interface interface="management" port="9990"/>
37a60
<console-handler name="CONSOLE">
46c69,70
< <periodic-rotating-file-handler name="FILE"
autoflush="true">
---
<datasource
jndi-name="java:jboss/datasources/ExampleDS" enabled="true"
use-java-context="true" pool-name="H2DS">
<connection-url>jdbc:h2:mem:test;DB_CLOSE_DELAY=-1</connection-url>
<driver>h2</driver>
<pool></pool>
82,103c104,105
< <user-name>
< sa
< </user-name>
< <password>
< sa
< </password>
< </security>
< </datasource>
< <datasource jndi-name="asdsadasd"
pool-name="asdasdasd_Pool">
< <connection-url>
< asda
< </connection-url>
< <driver>
< h2
< </driver>
< <security>
< <user-name>
< sdas
< </user-name>
< <password>
< dasd
< </password>
---
<user-name>sa</user-name>
<password>sa</password>
108,110c110
< <xa-datasource-class>
< org.h2.jdbcx.JdbcDataSource
< </xa-datasource-class>
---
<xa-datasource-class>org.h2.jdbcx.JdbcDataSource</xa-datasource-class>
116c116
< <deployment-scanner name="default"
path="deployments" scan-enabled="true" scan-interval="5000"
relative-to="jboss.server.base.dir" deployment-timeout="60"/>
---
<deployment-scanner scan-interval="5000"
relative-to="jboss.server.base.dir" path="deployments" />
118c118
< <subsystem xmlns="urn:jboss:domain:ee:1.0"/>
---
<subsystem xmlns="urn:jboss:domain:ee:1.0" />
119a120,128
> <!-- EJB3 pools -->
> <pools>
> <bean-instance-pools>
> <strict-max-pool name="slsb-strict-max-pool"
max-pool-size="20" instance-acquisition-timeout="5"
>
instance-acquisition-timeout-unit="MINUTES"/>
> </bean-instance-pools>
> </pools>
<archive-validation enabled="false" />
<bean-validation enabled="false" />
151,155c156,160
< <short-running-threads blocking="true"
allow-core-timeout="false">
< <core-threads count="10"
per-cpu="20"/>
< <queue-length count="10"
per-cpu="20"/>
< <max-threads count="10" per-cpu="20"/>
< <keepalive-time time="10"
unit="SECONDS"/>
---
<short-running-threads
blocking="true">
<core-threads count="10"
per-cpu="20"/>
<queue-length count="10"
per-cpu="20"/>
<max-threads count="10" per-cpu="20"/>
<keepalive-time time="10"
unit="seconds"/>
157,161c162,166
< <long-running-threads blocking="true"
allow-core-timeout="false">
< <core-threads count="10"
per-cpu="20"/>
< <queue-length count="10"
per-cpu="20"/>
< <max-threads count="10" per-cpu="20"/>
< <keepalive-time time="10"
unit="SECONDS"/>
---
<long-running-threads
blocking="true">
<core-threads count="10"
per-cpu="20"/>
<queue-length count="10"
per-cpu="20"/>
<max-threads count="10" per-cpu="20"/>
<keepalive-time time="10"
unit="seconds"/>
166c171
< <jmx-connector server-binding="jmx-connector-server"
registry-binding="jmx-connector-registry"/>
---
<jmx-connector
registry-binding="jmx-connector-registry"
server-binding="jmx-connector-server" />
171,172c176,177
< <subsystem xmlns="urn:jboss:domain:naming:1.0"/>
< <subsystem xmlns="urn:jboss:domain:pojo:1.0"/>
---
<subsystem xmlns="urn:jboss:domain:naming:1.0"
/>
<subsystem xmlns="urn:jboss:domain:pojo:1.0" />
175,177c180
< <property name="manager.root">
< jboss-osgi
< </property>
---
<property
name="manager.root">jboss-osgi</property>
179a183,188
<!--
A comma seperated list of module identifiers. Each system module
is added as a dependency to the OSGi framework module. The packages
from these system modules can be made visible as framework system
packages.
http://www.osgi.org/javadoc/r4v42/org/osgi/framework/Constants.html#FRAME...
-->
181,187c190,193
< org.apache.commons.logging,
< org.apache.log4j,
< org.jboss.as.osgi,
< org.slf4j,
< </property>
< <property
name="org.osgi.framework.startlevel.beginning">
< 1
---
org.apache.commons.logging,
org.apache.log4j,
org.jboss.as.osgi,
org.slf4j,
188a195,198
<!--
Framework environment property identifying extra packages which the
system bundle
must export from the current execution environment
-->
190,198c200,208
< org.apache.commons.logging;version=1.1.1,
< org.apache.log4j;version=1.2,
< org.jboss.as.osgi.service;version=7.0,
<
org.jboss.osgi.deployment.interceptor;version=1.0,
< org.jboss.osgi.spi.capability;version=1.0,
< org.jboss.osgi.spi.util;version=1.0,
< org.jboss.osgi.testing;version=1.0,
< org.jboss.osgi.vfs;version=1.0,
< org.slf4j;version=1.5.10,
---
org.apache.commons.logging;version=1.1.1,
org.apache.log4j;version=1.2,
org.jboss.as.osgi.service;version=7.0,
org.jboss.osgi.deployment.interceptor;version=1.0,
org.jboss.osgi.spi.capability;version=1.0,
org.jboss.osgi.spi.util;version=1.0,
org.jboss.osgi.testing;version=1.0,
org.jboss.osgi.vfs;version=1.0,
org.slf4j;version=1.5.10,
199a210,211
<!-- Specifies the beginning start level of the
framework -->
<property
name="org.osgi.framework.startlevel.beginning">1</property>
201a214
<!-- modules registered with the OSGi layer on
startup -->
203a217
<!-- bundles installed on startup -->
206a221
<!-- bundles started in startlevel 1 -->
210a226
<!-- bundles started in startlevel 2 -->
217a234
<!-- bundles started in startlevel 3 -->
226c243
< <subsystem xmlns="urn:jboss:domain:security:1.1">
---
<subsystem
xmlns="urn:jboss:domain:security:1.0">
236a254
<recovery-environment
socket-binding="txn-recovery-environment"
status-socket-binding="txn-status-manager"/>
239c257
< <uuid/>
---
<uuid />
242d259
< <recovery-environment
socket-binding="txn-recovery-environment"
status-socket-binding="txn-status-manager"/>
244d260
< <object-store/>
247c263
< <connector name="http" protocol="HTTP/1.1"
socket-binding="http" scheme="http"/>
---
<connector name="http"
scheme="http" protocol="HTTP/1.1" socket-binding="http"/>
249,250c265,266
< <alias name="localhost"/>
< <alias name="example.com"/>
---
<alias name="localhost" />
<alias name="example.com" />
253c269
< <subsystem xmlns="urn:jboss:domain:weld:1.0"/>
---
<subsystem xmlns="urn:jboss:domain:weld:1.0"
/>
254a271
<inet-address
value="${jboss.bind.address:127.0.0.1}"/>
262a280
<socket-binding name="jmx-connector-registry"
interface="management" port="1090"/>
<socket-binding name="jmx-connector-server"
interface="management" port="1091"/>
269c287
< <socket-binding name="osgi-http" port="8090"
interface="management"/>
---
<socket-binding name="osgi-http"
interface="management" port="8090"/>
274c292,293
< </server>
\ No newline at end of file
---