[jboss-jira] [JBoss JIRA] (WFLY-10256) [JDK9+] shaded client jars with MR overlays do not have defined Multi-Release in Manifest

[ https://issues.jboss.org/browse/WFLY-10256?page=com.atlassian.jira.plugin... ] Rostislav Svoboda updated WFLY-10256: ------------------------------------- Description: Shaded client jars should have Manifest entry * bin/client/jboss-cli-client.jar * bin/client/jboss-client.jar WFCOM-40 tracks effort for WildFly Common ELY-1567 tracks effort for wildfly-elytron-tool jar *Full / older details* Several jars with MR overlays do not have defined Multi-Release in Manifest Results with WildFly master from 2018-04-18: {code} DistributionTestCase.checkOverlayDirectoryAndManifestEntryForExpectedMRJars:93 The following 4 assertions failed: 1) [Artifact /Users/rsvoboda/git/wildfly/dist/target/wildfly-13.0.0.Alpha1-SNAPSHOT/bin/wildfly-elytron-tool.jar is expected to be Multi-Release JAR, jar.isMultiReleaseJar() returns false] expected:<[tru]e> but was:<[fals]e> at DistributionTestCase.lambda$checkOverlayDirectoryAndManifestEntryForExpectedMRJars$8(DistributionTestCase.java:90) expected:<[tru]e> but was:<[fals]e> 2) [Artifact /Users/rsvoboda/git/wildfly/dist/target/wildfly-13.0.0.Alpha1-SNAPSHOT/bin/client/jboss-cli-client.jar is expected to be Multi-Release JAR, jar.isMultiReleaseJar() returns false] expected:<[tru]e> but was:<[fals]e> at DistributionTestCase.lambda$checkOverlayDirectoryAndManifestEntryForExpectedMRJars$8(DistributionTestCase.java:90) expected:<[tru]e> but was:<[fals]e> 3) [Artifact /Users/rsvoboda/git/wildfly/dist/target/wildfly-13.0.0.Alpha1-SNAPSHOT/bin/client/jboss-client.jar is expected to be Multi-Release JAR, jar.isMultiReleaseJar() returns false] expected:<[tru]e> but was:<[fals]e> at DistributionTestCase.lambda$checkOverlayDirectoryAndManifestEntryForExpectedMRJars$8(DistributionTestCase.java:90) expected:<[tru]e> but was:<[fals]e> 4) [Artifact /Users/rsvoboda/git/wildfly/dist/target/wildfly-13.0.0.Alpha1-SNAPSHOT/modules/system/layers/base/org/wildfly/common/main/wildfly-common-1.3.1.Final.jar is expected to be Multi-Release JAR, jar.isMultiReleaseJar() returns false] expected:<[tru]e> but was:<[fals]e> at DistributionTestCase.lambda$checkOverlayDirectoryAndManifestEntryForExpectedMRJars$8(DistributionTestCase.java:90) expected:<[tru]e> but was:<[fals]e> {code} According MR JAR Support in JBoss Parent proposal WildFly Common should have Manifest entry * modules/system/layers/base/org/wildfly/common/main/wildfly-common-1.3.1.Final.jar I believe shaded jars should also have Manifest entry * bin/wildfly-elytron-tool.jar * bin/client/jboss-cli-client.jar * bin/client/jboss-client.jar Using https://github.com/jboss-eap-qe/jarest/pull/3/files ++ mvn test -Djarest.input.dir=/Users/rsvoboda/git/wildfly/dist/target/wildfly-13.0.0.Alpha1-SNAPSHOT was: Several jars with MR overlays do not have defined Multi-Release in Manifest Results with WildFly master from 2018-04-18: {code} DistributionTestCase.checkOverlayDirectoryAndManifestEntryForExpectedMRJars:93 The following 4 assertions failed: 1) [Artifact /Users/rsvoboda/git/wildfly/dist/target/wildfly-13.0.0.Alpha1-SNAPSHOT/bin/wildfly-elytron-tool.jar is expected to be Multi-Release JAR, jar.isMultiReleaseJar() returns false] expected:<[tru]e> but was:<[fals]e> at DistributionTestCase.lambda$checkOverlayDirectoryAndManifestEntryForExpectedMRJars$8(DistributionTestCase.java:90) expected:<[tru]e> but was:<[fals]e> 2) [Artifact /Users/rsvoboda/git/wildfly/dist/target/wildfly-13.0.0.Alpha1-SNAPSHOT/bin/client/jboss-cli-client.jar is expected to be Multi-Release JAR, jar.isMultiReleaseJar() returns false] expected:<[tru]e> but was:<[fals]e> at DistributionTestCase.lambda$checkOverlayDirectoryAndManifestEntryForExpectedMRJars$8(DistributionTestCase.java:90) expected:<[tru]e> but was:<[fals]e> 3) [Artifact /Users/rsvoboda/git/wildfly/dist/target/wildfly-13.0.0.Alpha1-SNAPSHOT/bin/client/jboss-client.jar is expected to be Multi-Release JAR, jar.isMultiReleaseJar() returns false] expected:<[tru]e> but was:<[fals]e> at DistributionTestCase.lambda$checkOverlayDirectoryAndManifestEntryForExpectedMRJars$8(DistributionTestCase.java:90) expected:<[tru]e> but was:<[fals]e> 4) [Artifact /Users/rsvoboda/git/wildfly/dist/target/wildfly-13.0.0.Alpha1-SNAPSHOT/modules/system/layers/base/org/wildfly/common/main/wildfly-common-1.3.1.Final.jar is expected to be Multi-Release JAR, jar.isMultiReleaseJar() returns false] expected:<[tru]e> but was:<[fals]e> at DistributionTestCase.lambda$checkOverlayDirectoryAndManifestEntryForExpectedMRJars$8(DistributionTestCase.java:90) expected:<[tru]e> but was:<[fals]e> {code} According MR JAR Support in JBoss Parent proposal WildFly Common should have Manifest entry * modules/system/layers/base/org/wildfly/common/main/wildfly-common-1.3.1.Final.jar I believe shaded jars should also have Manifest entry * bin/wildfly-elytron-tool.jar * bin/client/jboss-cli-client.jar * bin/client/jboss-client.jar Using https://github.com/jboss-eap-qe/jarest/pull/3/files ++ mvn test -Djarest.input.dir=/Users/rsvoboda/git/wildfly/dist/target/wildfly-13.0.0.Alpha1-SNAPSHOT -- This message was sent by Atlassian JIRA (v7.5.0#75005)