]
Farah Juma resolved ELY-2043.
-----------------------------
Fix Version/s: 1.15.0.CR1
Resolution: Done
Incorrect and confusing trace message
-------------------------------------
Key: ELY-2043
URL:
https://issues.redhat.com/browse/ELY-2043
Project: WildFly Elytron
Issue Type: Bug
Components: HTTP
Affects Versions: 1.14.0.Final
Reporter: Mike Douglass
Assignee: Sonia Zaldana
Priority: Minor
Fix For: 1.15.0.CR1
org.wildfly.security.http.util.AggregateServerMechanismFactory
has one incorrect trace message and one which could be more helpful:
getMechanismNames has
{color:#0033b3}if {color}(log.isTraceEnabled()) {
log.tracef({color:#067d17}"No %s provided by factories in %s: %s"{color},
HttpServerAuthenticationMechanismFactory.{color:#0033b3}class{color}.getSimpleName(),
getClass().getSimpleName(), Arrays.toString(factories));
}
{color:#0033b3}return {color}names.toArray({color:#0033b3}new
{color}String[names.size()]);
should that be
{color:#0033b3}if {color}(log.isTraceEnabled()) {
log.tracef({color:#067d17}"%s factories in %s: %s"{color},
HttpServerAuthenticationMechanismFactory.{color:#0033b3}class{color}.getSimpleName(),
getClass().getSimpleName(), Arrays.toString(factories));
}
{color:#0033b3}return {color}names.toArray({color:#0033b3}new
{color}String[names.size()]);
?
Same message in createAuthenticationMechanism
{color:#0033b3}if {color}(log.isTraceEnabled()) {
log.tracef({color:#067d17}"No %s provided by factories in %s: %s"{color},
HttpServerAuthenticationMechanismFactory.{color:#0033b3}class{color}.getSimpleName(),
getClass().getSimpleName(), Arrays.toString(factories));
}
It would be useful if it supplied the mechanism e.g:
{color:#0033b3}if {color}(log.isTraceEnabled()) {
log.tracef({color:#067d17}"Mechanism %s not %s provided by factories in %s:
%s"{color}, mechanism,
HttpServerAuthenticationMechanismFactory.{color:#0033b3}class{color}.getSimpleName(),
getClass().getSimpleName(), Arrays.toString(factories));
}