9:46 p.m.
Improve the parameter value handling
------------------------------------
Key: JBPORTAL-1346
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1346
Project: JBoss Portal
Issue Type: Task
Security Level: Public (Everyone can see)
Components: Portal QA
Reporter: Julien Viet
Fix For: 2.8 Final
we have :
MonoValuedTestParameterValue extends TestParameterValue
MultiValuedTestParameterValue extends TestParameterValue
and
TestParameterValue { public abstract Object getValue(); }
the method getValue() should not be here : a value is either mono valued or multi valued
and both have nothing in common, the code client of that needs to deal with both of them
explicitely.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:35 p.m.
New subject: [JBoss JIRA] Updated: (JBPORTAL-1346) Improve the parameter value handling
[ http://jira.jboss.com/jira/browse/JBPORTAL-1346?page=all ]
Julien Viet updated JBPORTAL-1346:
----------------------------------
Assignee: Matt Wringe
Improve the parameter value handling
------------------------------------
Key: JBPORTAL-1346
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1346
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal QA
Reporter: Julien Viet
Assigned To: Matt Wringe
Fix For: 2.8 Final
we have :
MonoValuedTestParameterValue extends TestParameterValue
MultiValuedTestParameterValue extends TestParameterValue
and
TestParameterValue { public abstract Object getValue(); }
the method getValue() should not be here : a value is either mono valued or multi valued
and both have nothing in common, the code client of that needs to deal with both of them
explicitely.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:27 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-1346) Improve the parameter value handling
[ http://jira.jboss.com/jira/browse/JBPORTAL-1346?page=comments#action_1236... ]
Matt Wringe commented on JBPORTAL-1346:
---------------------------------------
So are you just suggesting just removing the get() method from the parent class and adding
it to the child classes (changing the return value for the MultiValuedTestParameterValue
to Collection instead of Object):
MonoValuedTestParameterValue { public Object get() { return value;}}
MultiValuedTestParameterValue { public Collection get() { return value;}}
Is this all that all that is required (and of course altering the code that relies on
these methods)? or am I missing something else here?
I am just a bit confused since a Collection is an Object anyways
Improve the parameter value handling
------------------------------------
Key: JBPORTAL-1346
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1346
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal QA
Reporter: Julien Viet
Assigned To: Matt Wringe
Fix For: 2.8 Final
we have :
MonoValuedTestParameterValue extends TestParameterValue
MultiValuedTestParameterValue extends TestParameterValue
and
TestParameterValue { public abstract Object getValue(); }
the method getValue() should not be here : a value is either mono valued or multi valued
and both have nothing in common, the code client of that needs to deal with both of them
explicitely.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:34 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-1346) Improve the parameter value handling
[ http://jira.jboss.com/jira/browse/JBPORTAL-1346?page=comments#action_1236... ]
Julien Viet commented on JBPORTAL-1346:
---------------------------------------
actually re reading the code, it is something in between:
the get() implementation on the multi value instead of returning the collection should
rather return null if the collection is empty or the first element of the collection if it
is not empty.
Improve the parameter value handling
------------------------------------
Key: JBPORTAL-1346
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1346
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal QA
Reporter: Julien Viet
Assigned To: Matt Wringe
Fix For: 2.8 Final
we have :
MonoValuedTestParameterValue extends TestParameterValue
MultiValuedTestParameterValue extends TestParameterValue
and
TestParameterValue { public abstract Object getValue(); }
the method getValue() should not be here : a value is either mono valued or multi valued
and both have nothing in common, the code client of that needs to deal with both of them
explicitely.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:01 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-1346) Improve the parameter value handling
[ http://jira.jboss.com/jira/browse/JBPORTAL-1346?page=comments#action_1236... ]
Matt Wringe commented on JBPORTAL-1346:
---------------------------------------
should it only ever get the first element, or should it act like an iterators .next()?
Improve the parameter value handling
------------------------------------
Key: JBPORTAL-1346
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1346
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal QA
Reporter: Julien Viet
Assigned To: Matt Wringe
Fix For: 2.8 Final
we have :
MonoValuedTestParameterValue extends TestParameterValue
MultiValuedTestParameterValue extends TestParameterValue
and
TestParameterValue { public abstract Object getValue(); }
the method getValue() should not be here : a value is either mono valued or multi valued
and both have nothing in common, the code client of that needs to deal with both of them
explicitely.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:54 a.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-1346) Improve the parameter value handling
[ http://jira.jboss.com/jira/browse/JBPORTAL-1346?page=comments#action_1236... ]
Julien Viet commented on JBPORTAL-1346:
---------------------------------------
it should be idempotent.
Improve the parameter value handling
------------------------------------
Key: JBPORTAL-1346
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1346
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal QA
Reporter: Julien Viet
Assigned To: Matt Wringe
Fix For: 2.8 Final
we have :
MonoValuedTestParameterValue extends TestParameterValue
MultiValuedTestParameterValue extends TestParameterValue
and
TestParameterValue { public abstract Object getValue(); }
the method getValue() should not be here : a value is either mono valued or multi valued
and both have nothing in common, the code client of that needs to deal with both of them
explicitely.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:07 p.m.
New subject: [JBoss JIRA] Resolved: (JBPORTAL-1346) Improve the parameter value handling
[ http://jira.jboss.com/jira/browse/JBPORTAL-1346?page=all ]
Julien Viet resolved JBPORTAL-1346.
-----------------------------------
Resolution: Out of Date
Since it is handled differently by the new framework
Improve the parameter value handling
------------------------------------
Key: JBPORTAL-1346
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1346
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal QA
Reporter: Julien Viet
Assigned To: Matt Wringe
Fix For: 2.8 Final
we have :
MonoValuedTestParameterValue extends TestParameterValue
MultiValuedTestParameterValue extends TestParameterValue
and
TestParameterValue { public abstract Object getValue(); }
the method getValue() should not be here : a value is either mono valued or multi valued
and both have nothing in common, the code client of that needs to deal with both of them
explicitely.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6177
days inactive
6363
days old
6 comments
2 participants
participants (2)
-
Julien Viet (JIRA) -
Matt Wringe (JIRA)