[ http://jira.jboss.com/jira/browse/HIBERNATE-50?page=comments#action_12351301 ] Lajos Gathy commented on HIBERNATE-50: -------------------------------------- I ran into this problem as well and I think it would be nice to do some improvements on this issue. Here is my example: @Embeddable public class EAttrs implements Serializable { private Float x; private Calendar y; private String z; /* getters and setters come here - with mapping annotations, neither of the attributes is mandatory */ @Transient public Boolean checkSomething() { /* do some checking on the attributes */ } @Transient public String calculateSomething() { /* calculate some data from the attribute values */ } } @Entity public class SomeEntity implements Serializable { private String something; private EAttrs someAttributes = new EAttrs(); @NotNull public EAttrs getSomeAttributes() { return someAttributes; } /* the rest of the getters and setters comes here */ } In this example all attributes of EAttrs can be null. But in SomeEntity I annotate the 'someAttributes' property with @NotNull, because I need that object existing always to be able to invoke its property getters or transient methods without checking whether the embedded object is null every time, even if all its attributes are null. But after fetching an entity - lets call it 'e1' - someAttributes will be null if all of its attributes were null and I cannot invoke e1.getSomeAttributes().getX() or e1.getSomeAttributes().checkSomething(). An other problem comes when I change the 'something' attribute of the 'e1' and I try to merge it back to the persistence context, because 'someAttributes' will be null and the entity will fail the not-null validation of that attribute. My proposal is to add a boolean 'mandatory' field to @Embedded annotation and if it is set to true, then the embedded object should be constructed automatically during loading the entity when all its attributes are null. A better way would be to do this if the @NotNull annotation is present on the embedded attribute. What do you think about this? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/HIBERNATE-50?page=comments#action_12352212 ] milan w?lke commented on HIBERNATE-50: -------------------------------------- The workaround I know is to add a property to the embedded object that cannot be set to null, e. g. add an int. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/HIBERNATE-50?page=comments#action_12354973 ] Steve Ebersole commented on HIBERNATE-50: ----------------------------------------- #1, y'all do realize that this is the JIRA for the JBoss-Hibernate integration, right? http://opensource.atlassian.com/projects/hibernate #2, create a patch (attached to the actual Hibernate JIRA!) including appropriate test cases. I'll consider it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/HIBERNATE-50?page=comments#action_12359025 ] Jim Hazen commented on HIBERNATE-50: ------------------------------------ What's old is new again. A little digging yields this very old issue from hibernate core. Perhaps discussion should be moved over here. http://opensource.atlassian.com/projects/hibernate/browse/HB-31 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/HIBERNATE-50?page=comments#action_12401543 ] marcinko commented on HIBERNATE-50: ----------------------------------- If anyone cares, I find it strange that this simple annoyance is being overlooked as something unusual. For instance, I have a User entity with Address embeddable (having city, country...), and in web frameworks that I used, I always have User editing web page having text field bound to some Address field, specified in some expression language in HTML template like: "user.address.city" And if my Address in User is not set, NPE will get raised. So I need to have this Address field always set, even in cases when it is empty (as it is always during User creation). I don't get Gavin's opinion that there is something wrong with empty embeddables. Embeddable in that case is just encapsulated group of optional fields. As said, manually not allowing null embeddables to get set inside setters brings constant dirty state of the entity, which will ultimately lead to constant SQL update, which is annoying at least. As suggested, it would be best if empty/null embeddable values should be configurable, but if that's not possible, I think empty value should be default. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/HIBERNATE-50?page=comments#action_12409677 ] John Lindwall commented on HIBERNATE-50: ---------------------------------------- We have also been bitten by this behavior. I'd love to see some annotation attribute or configuration item to allow the behavior of populating the reference with a new object instead of a null. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/HIBERNATE-50?page=com.atlassian.jira.p... ] Vladimir Kovalyuk commented on HIBERNATE-50: -------------------------------------------- Found this in documentation: The null value semantics of a component are ad hoc. When reloading the containing object, Hibernate will assume that if all component columns are null, then the entire component is null. This should be okay for most purposes. One guy decided that erasure should be ok for most generics use for those days. Are you ok with erasure? Are most people ok with that? I believe you should have a different look at the embeddable nature. You consider embedded object as a depended object. So you just strip regular entity to just entity without identity. It is limited point of view. OOD has the mixin class concept. It is very simple and very useful concept. What you have done is similar to dynamic mixin concept what is the expected echanement of static mixin in dynamic languages (Groovy for near instance). But you haven't started with static mixin concept which implies that all the fields are the part of resulted class. In other words you should have a not-null restriction for the component as default rule. And allow the developer to enable nullability for the component. And just imagine how many side effects we obtain trying to work around this. If we try to force not-null for empty component we obtain pre-update events, useless updates and instance version changes and all the side effects caused by that. But if the component instance contains not-null value we don't have events invoked and updates. If the component has a field of primitive type we don't see any events and updates. Other workarounds causes more problems. "... The null value semantics of a component are ..." completely inconsistent, theoretically not-proven and user-annoying feature. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/HIBERNATE-50?page=com.atlassian.jira.p... ] Vladimir Kovalyuk commented on HIBERNATE-50: -------------------------------------------- Not, didn't have intentions to be vulgar. Sorry for posting here - I didn't realize that Hibernate has its own jira. Trying to find the appropriate issue there. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira