[JBoss JIRA] Closed: (JBRULES-139) TCK is not creating a classloader properly in org.jcp.jsr94.tck.util.TestCaseUtil
by Mark Proctor (JIRA)
[ http://jira.jboss.com/jira/browse/JBRULES-139?page=all ]
Mark Proctor closed JBRULES-139.
--------------------------------
Fix Version/s: 3.0.6
(was: 4.0.0.MR3)
Resolution: Done
> TCK is not creating a classloader properly in org.jcp.jsr94.tck.util.TestCaseUtil
> ---------------------------------------------------------------------------------
>
> Key: JBRULES-139
> URL: http://jira.jboss.com/jira/browse/JBRULES-139
> Project: JBoss Rules
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: JSR94
> Environment: winXP
> Reporter: Michael Frandsen
> Assigned To: Mark Proctor
> Priority: Minor
> Fix For: 3.0.6
>
>
> TCK is not creating a classloader properly in org.jcp.jsr94.tck.util.TestCaseUtil
> Line 147-:
> /** This method complements the previous method. We suppose that the
> * rule provider implementation classes are stored in stand-alone JAR
> * files provided as URLs. The method creates a URLClassLoader, loads
> * the RuleServiceProvider class from the class loader, then registers
> * the object using the class loader.
> *
> * Note: we need to take care about the CLASSPATH when launching
> * this test.
> *
> * @param uri The registration name of this rule service provider.
> * @param urls The URLs which provide the rule service provoider classes.
> *
> * @return The registered provider.
> *
> */
> public static RuleServiceProvider getRuleServiceProvider(String uri,
> URL[] urls)
> throws ClassNotFoundException, ConfigurationException
> {
> if (ruleServiceProvider == null) parseTckConfiguration();
>
> // Fail this test if no provider has been specified.
> if (ruleServiceProvider == null)
> throw new ClassNotFoundException("rule-service-provider not specified");
> ClassLoader cl = new URLClassLoader(urls);
> Class ruleServiceProviderClass = cl.loadClass(ruleServiceProvider);
> TestCase.assertNotNull("[TestCaseUtil] Class loading on " +
> ruleServiceProvider + " failed. ",
> ruleServiceProviderClass);
> // Register the provider.
> RuleServiceProviderManager.registerRuleServiceProvider(uri,
> ruleServiceProviderClass,cl);
> // Retrieve and return the provider
> return RuleServiceProviderManager.getRuleServiceProvider(uri);
> }
> Should take in the constructor of the classloader: Thread.currentThread().getContextClassLoader(), else mvn´s surefire is getting problems:
> public static RuleServiceProvider getRuleServiceProvider(String uri,
> URL[] urls)
> throws ClassNotFoundException, ConfigurationException
> {
> if (ruleServiceProvider == null) parseTckConfiguration();
>
> // Fail this test if no provider has been specified.
> if (ruleServiceProvider == null)
> throw new ClassNotFoundException("rule-service-provider not specified");
> ClassLoader cl = new URLClassLoader(urls,Thread.currentThread().getContextClassLoader());
> Class ruleServiceProviderClass = cl.loadClass(ruleServiceProvider);
> TestCase.assertNotNull("[TestCaseUtil] Class loading on " +
> ruleServiceProvider + " failed. ",
> ruleServiceProviderClass);
> // Register the provider.
> RuleServiceProviderManager.registerRuleServiceProvider(uri,
> ruleServiceProviderClass,cl);
> // Retrieve and return the provider
> return RuleServiceProviderManager.getRuleServiceProvider(uri);
> }
> //This tip was given by "kenney" from #maven
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
17 years, 6 months
[JBoss JIRA] Closed: (JBRULES-275) FunnctionFixer - improve it to use simpler regex
by Mark Proctor (JIRA)
[ http://jira.jboss.com/jira/browse/JBRULES-275?page=all ]
Mark Proctor closed JBRULES-275.
--------------------------------
Resolution: Out of Date
Not neede as we now use static imports for functions.````````````````````````````
> FunnctionFixer - improve it to use simpler regex
> ------------------------------------------------
>
> Key: JBRULES-275
> URL: http://jira.jboss.com/jira/browse/JBRULES-275
> Project: JBoss Rules
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Affects Versions: 3.0-rc3
> Reporter: Michael Neale
> Assigned To: Mark Proctor
> Fix For: 4.0.0.MR3
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> At the moment the FunctionFixer tries to find what it thinks are function calls:
> foo(bar); becomes Foo.foo(bar);
> It does an OK job.
> What would simplify it, was if it worked off a list of known functions for the rules being compiled.
> Then it could do an enhanced "find and replace" with each function name (as long as it doesn't appear in a string).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
17 years, 6 months
[JBoss JIRA] Closed: (JBRULES-232) if variable is bound to multiple columns, that should mean an implicit join on identity
by Mark Proctor (JIRA)
[ http://jira.jboss.com/jira/browse/JBRULES-232?page=all ]
Mark Proctor closed JBRULES-232.
--------------------------------
Fix Version/s: (was: 4.0.0.MR3)
Resolution: Rejected
I'm rejecting this, I believe the code currently throws an error for this.
> if variable is bound to multiple columns, that should mean an implicit join on identity
> ---------------------------------------------------------------------------------------
>
> Key: JBRULES-232
> URL: http://jira.jboss.com/jira/browse/JBRULES-232
> Project: JBoss Rules
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Drl Parser/Builder
> Affects Versions: 3.0-rc2
> Reporter: Michael Neale
> Assigned To: Mark Proctor
>
> This is based on some discussions on the mailling list.
> So:
> m : Message(foo == "bar")
> m : Message(foo != "42")
> should be the same as
> m : Message(foo == "bar", foo != 42)
> this works as the same variable is "bound" each time. At the moment it rebinds.
> The "new" behaviour should be consistent with Jess, and it does indeed make things simpler from a users point of view, and DSLs much more powerful.
> Obviously if nothing it bound, then it is just as normal.
> It *may* be possible to do this entirely in the parser, not sure at this stage... further investigation required.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
17 years, 6 months