[JBoss JIRA] Created: (JBREM-1261) Prevent DOS attack on BisocketServerInvoker$SecondaryServerSocketThread
by Ron Sigal (JIRA)
Prevent DOS attack on BisocketServerInvoker$SecondaryServerSocketThread
-----------------------------------------------------------------------
Key: JBREM-1261
URL: https://issues.jboss.org/browse/JBREM-1261
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 2.2.3.SP3, 2.5.3.SP1
Reporter: Ron Sigal
Assignee: Ron Sigal
Fix For: 2.5.3.SP2, 2.2.3.SP4
>From the original bug report:
Exploiting and thus confirming this vulnerability is extremely simple: Simply
connect to the bisocket control connection (ie. "telnet <jboss-host>
<control-connection-port>") without sending any data on the connection. As long
as this connection is open, no clients can connect to the bisocket control port
because the connections are not accepted at server side.
The cause of this vulnerability is found in method
org.jboss.remoting.transport.bisocket.BisocketServerInvoker$SecondaryServerSocketThread.run(),
which contains the accept-loop for the bisocket control connection. After
having accepted a connection, the accept loop thread reads from the newly
created connection expecting the client to send an action code and a listener
id. If the client sends nothing, the accept loop thread will block in the read
call, causing no other connections to be accepted.
To fix, the accept loop thread should not do the read on the new connection.
Instead it should start a new thread that does the read
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 2 months
[JBoss JIRA] Reopened: (JBAS-8906) Service in START_FAILED state does not transition when mode is changed to REMOVE
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/JBAS-8906?page=com.atlassian.jira.plugin.... ]
Brian Stansberry reopened JBAS-8906:
------------------------------------
Assignee: Brian Stansberry
Reopening as a JBAS bug; cause is illegal behavior shown at http://fpaste.org/vcII/
> Service in START_FAILED state does not transition when mode is changed to REMOVE
> --------------------------------------------------------------------------------
>
> Key: JBAS-8906
> URL: https://issues.jboss.org/browse/JBAS-8906
> Project: JBoss Application Server
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: David Lloyd
> Assignee: Brian Stansberry
> Attachments: forceNPE.patch, w2.war
>
>
> Here's an example service dump:
> ^C13:22:49,405 INFO [org.apache.coyote.http11.Http11Protocol] (MSC service thread 1-2) Stopping Coyote HTTP/1.1 on http-8080
> 13:22:49,425 INFO [org.jboss.as.logging] Restored bootstrap log handlers
> 13:22:49,431 INFO [org.hornetq.core.server.impl.HornetQServerImpl] HornetQ Server version 2.1.2.Final (Colmeia, 120) stopped
> ^C
> 13:27:25,270 INFO [stdout] Services for jboss-as:
> 13:27:25,276 INFO [stdout] Service "jboss.as" (class org.jboss.as.server.ApplicationServerService) mode REMOVE state UP (STOP_REQUESTED)
> 13:27:25,276 INFO [stdout] Service "jboss.as.external-module-service" (class org.jboss.as.server.moduleservice.ExternalModuleService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.as)
> 13:27:25,279 INFO [stdout] Service "jboss.as.server-controller" (class org.jboss.as.server.ServerControllerService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.as) (dependencies: jboss.as.external-module-service, jboss.as.service-module-loader, jboss.deployment-repository)
> 13:27:25,279 INFO [stdout] Service "jboss.as.service-module-loader" (class org.jboss.as.server.moduleservice.ServiceModuleLoader) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.as)
> 13:27:25,280 INFO [stdout] Service "jboss.deployment.chains" (class org.jboss.as.server.deployment.DeployerChainsService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.as.server-controller)
> 13:27:25,280 INFO [stdout] Service "jboss.deployment.unit."test3.jar"" (class org.jboss.as.server.deployment.RootDeploymentUnitService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.as.server-controller) (dependencies: jboss.deployment.chains, jboss.deployment-repository)
> 13:27:25,282 INFO [stdout] Service "jboss.deployment.unit."test3.jar".CONFIGURE_MODULE" (class org.jboss.as.server.deployment.DeploymentUnitPhaseService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.deployment.unit."test3.jar".DEPENDENCIES) (dependencies: jboss.deployment.chains, jboss.deployment.unit."test3.jar".DEPENDENCIES)
> 13:27:25,283 INFO [stdout] Service "jboss.deployment.unit."test3.jar".DEPENDENCIES" (class org.jboss.as.server.deployment.DeploymentUnitPhaseService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.deployment.unit."test3.jar".PARSE) (dependencies: jboss.deployment.unit."test3.jar".PARSE, jboss.deployment.chains)
> 13:27:25,283 INFO [stdout] Service "jboss.deployment.unit."test3.jar".INSTALL" (class org.jboss.as.server.deployment.DeploymentUnitPhaseService) mode REMOVE state START_FAILED (parent: jboss.deployment.unit."test3.jar".POST_MODULE) (dependencies: jboss.deployment.unit."test3.jar".POST_MODULE, jboss.deployment.chains) (has failed dependency)
> 13:27:25,284 INFO [stdout] Service "jboss.deployment.unit."test3.jar".PARSE" (class org.jboss.as.server.deployment.DeploymentUnitPhaseService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.deployment.unit."test3.jar".STRUCTURE) (dependencies: jboss.deployment.unit."test3.jar".STRUCTURE, jboss.deployment.chains)
> 13:27:25,284 INFO [stdout] Service "jboss.deployment.unit."test3.jar".POST_MODULE" (class org.jboss.as.server.deployment.DeploymentUnitPhaseService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.deployment.unit."test3.jar".CONFIGURE_MODULE) (dependencies: module.service."deployment.test3.jar".main, jboss.deployment.unit."test3.jar".CONFIGURE_MODULE, jboss.deployment.chains)
> 13:27:25,285 INFO [stdout] Service "jboss.deployment.unit."test3.jar".STRUCTURE" (class org.jboss.as.server.deployment.DeploymentUnitPhaseService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.deployment.unit."test3.jar") (dependencies: jboss.deployment.chains)
> 13:27:25,285 INFO [stdout] Service "jboss.deployment-repository" (class org.jboss.as.server.deployment.impl.ServerDeploymentRepositoryImpl) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.as)
> 13:27:25,285 INFO [stdout] Service "module.service."deployment.test3.jar".main" (class org.jboss.as.server.moduleservice.ModuleLoadService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.deployment.unit."test3.jar".CONFIGURE_MODULE) (dependencies: jboss.as.service-module-loader, module.spec.service."deployment.test3.jar".main)
> 13:27:25,286 INFO [stdout] Service "module.spec.service."deployment.test3.jar".main" (class org.jboss.msc.service.ValueService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.deployment.unit."test3.jar".CONFIGURE_MODULE) (dependencies: jboss.deployment.unit."test3.jar".CONFIGURE_MODULE, jboss.deployment.unit."test3.jar")
> 13:27:25,286 INFO [stdout] 15 services displayed
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 2 months
[JBoss JIRA] Moved: (JBAS-8906) Service in START_FAILED state does not transition when mode is changed to REMOVE
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/JBAS-8906?page=com.atlassian.jira.plugin.... ]
Brian Stansberry moved MSC-67 to JBAS-8906:
-------------------------------------------
Project: JBoss Application Server (was: Modular Service Container)
Key: JBAS-8906 (was: MSC-67)
Affects Version/s: (was: 1.0.0.Beta6)
Security: Public
> Service in START_FAILED state does not transition when mode is changed to REMOVE
> --------------------------------------------------------------------------------
>
> Key: JBAS-8906
> URL: https://issues.jboss.org/browse/JBAS-8906
> Project: JBoss Application Server
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: David Lloyd
> Attachments: forceNPE.patch, w2.war
>
>
> Here's an example service dump:
> ^C13:22:49,405 INFO [org.apache.coyote.http11.Http11Protocol] (MSC service thread 1-2) Stopping Coyote HTTP/1.1 on http-8080
> 13:22:49,425 INFO [org.jboss.as.logging] Restored bootstrap log handlers
> 13:22:49,431 INFO [org.hornetq.core.server.impl.HornetQServerImpl] HornetQ Server version 2.1.2.Final (Colmeia, 120) stopped
> ^C
> 13:27:25,270 INFO [stdout] Services for jboss-as:
> 13:27:25,276 INFO [stdout] Service "jboss.as" (class org.jboss.as.server.ApplicationServerService) mode REMOVE state UP (STOP_REQUESTED)
> 13:27:25,276 INFO [stdout] Service "jboss.as.external-module-service" (class org.jboss.as.server.moduleservice.ExternalModuleService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.as)
> 13:27:25,279 INFO [stdout] Service "jboss.as.server-controller" (class org.jboss.as.server.ServerControllerService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.as) (dependencies: jboss.as.external-module-service, jboss.as.service-module-loader, jboss.deployment-repository)
> 13:27:25,279 INFO [stdout] Service "jboss.as.service-module-loader" (class org.jboss.as.server.moduleservice.ServiceModuleLoader) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.as)
> 13:27:25,280 INFO [stdout] Service "jboss.deployment.chains" (class org.jboss.as.server.deployment.DeployerChainsService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.as.server-controller)
> 13:27:25,280 INFO [stdout] Service "jboss.deployment.unit."test3.jar"" (class org.jboss.as.server.deployment.RootDeploymentUnitService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.as.server-controller) (dependencies: jboss.deployment.chains, jboss.deployment-repository)
> 13:27:25,282 INFO [stdout] Service "jboss.deployment.unit."test3.jar".CONFIGURE_MODULE" (class org.jboss.as.server.deployment.DeploymentUnitPhaseService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.deployment.unit."test3.jar".DEPENDENCIES) (dependencies: jboss.deployment.chains, jboss.deployment.unit."test3.jar".DEPENDENCIES)
> 13:27:25,283 INFO [stdout] Service "jboss.deployment.unit."test3.jar".DEPENDENCIES" (class org.jboss.as.server.deployment.DeploymentUnitPhaseService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.deployment.unit."test3.jar".PARSE) (dependencies: jboss.deployment.unit."test3.jar".PARSE, jboss.deployment.chains)
> 13:27:25,283 INFO [stdout] Service "jboss.deployment.unit."test3.jar".INSTALL" (class org.jboss.as.server.deployment.DeploymentUnitPhaseService) mode REMOVE state START_FAILED (parent: jboss.deployment.unit."test3.jar".POST_MODULE) (dependencies: jboss.deployment.unit."test3.jar".POST_MODULE, jboss.deployment.chains) (has failed dependency)
> 13:27:25,284 INFO [stdout] Service "jboss.deployment.unit."test3.jar".PARSE" (class org.jboss.as.server.deployment.DeploymentUnitPhaseService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.deployment.unit."test3.jar".STRUCTURE) (dependencies: jboss.deployment.unit."test3.jar".STRUCTURE, jboss.deployment.chains)
> 13:27:25,284 INFO [stdout] Service "jboss.deployment.unit."test3.jar".POST_MODULE" (class org.jboss.as.server.deployment.DeploymentUnitPhaseService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.deployment.unit."test3.jar".CONFIGURE_MODULE) (dependencies: module.service."deployment.test3.jar".main, jboss.deployment.unit."test3.jar".CONFIGURE_MODULE, jboss.deployment.chains)
> 13:27:25,285 INFO [stdout] Service "jboss.deployment.unit."test3.jar".STRUCTURE" (class org.jboss.as.server.deployment.DeploymentUnitPhaseService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.deployment.unit."test3.jar") (dependencies: jboss.deployment.chains)
> 13:27:25,285 INFO [stdout] Service "jboss.deployment-repository" (class org.jboss.as.server.deployment.impl.ServerDeploymentRepositoryImpl) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.as)
> 13:27:25,285 INFO [stdout] Service "module.service."deployment.test3.jar".main" (class org.jboss.as.server.moduleservice.ModuleLoadService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.deployment.unit."test3.jar".CONFIGURE_MODULE) (dependencies: jboss.as.service-module-loader, module.spec.service."deployment.test3.jar".main)
> 13:27:25,286 INFO [stdout] Service "module.spec.service."deployment.test3.jar".main" (class org.jboss.msc.service.ValueService) mode REMOVE state UP (STOP_REQUESTED) (parent: jboss.deployment.unit."test3.jar".CONFIGURE_MODULE) (dependencies: jboss.deployment.unit."test3.jar".CONFIGURE_MODULE, jboss.deployment.unit."test3.jar")
> 13:27:25,286 INFO [stdout] 15 services displayed
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 2 months
[JBoss JIRA] Created: (JBRULES-2895) Strip all author tags from java files
by Geoffrey De Smet (JIRA)
Strip all author tags from java files
-------------------------------------
Key: JBRULES-2895
URL: https://issues.jboss.org/browse/JBRULES-2895
Project: Drools
Issue Type: Task
Security Level: Public (Everyone can see)
Reporter: Geoffrey De Smet
Assignee: Geoffrey De Smet
Asked by Mark. Took me a while to accept it, but it's true that we need to do it.
The author tags in the java files are a maintenance nightmare:
- A large percentage is wrong, incomplete or inaccurate.
- Most of the time, it only contains the original author. Many files are completely refactored/expanded by other authors.
- Git is accurate, that is the canonical source to find the correct author.
- To find the correct author of a piece of code, you always have to double check with git, you cannot suppose the author on the author tag alone.
- Author tags promote "code ownership", which is bad in the long run.
- If people work on a piece they perceive as being owned by someone else, they tend to:
-- only fix what they are assigned to fix, not everything that's broken.
-- discard responsibility if that code doesn't work properly.
-- be scared of stepping of the feet of the owner
-- Instead of "code ownership", we need "module leadership" and "peer reviews".
- More info: How to get a healthy open source project? http://video.google.com/videoplay?docid=-4216011961522818645#
Credit to the author of peices of code is given:
- on the team page: http://www.jboss.org/drools/team
-- Please contact Geoffrey (or any of us) if you want to change/expand your entry in the team page. Don't be shy!
- on the blog: http://blog.athico.com
-- Just ask write permission if you don't have them and want to write an article.
- with ohloh: https://www.ohloh.net/p/jboss-drools/contributors
- in the github web interface
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 2 months