[JBoss JIRA] (AS7-4784) Unify generic AttributeDefinition implementations
by Tomaz Cerar (JIRA)
Tomaz Cerar created AS7-4784:
--------------------------------
Summary: Unify generic AttributeDefinition implementations
Key: AS7-4784
URL: https://issues.jboss.org/browse/AS7-4784
Project: Application Server 7
Issue Type: Enhancement
Affects Versions: 7.1.2.Final (EAP), 7.1.1.Final
Reporter: Tomaz Cerar
Assignee: Tomaz Cerar
Fix For: 7.2.0.Alpha1
The objective of this task is to cleanup AttributeDefinition implementations as some of them are just implementing the class but not following any conventions they should so they cannot be used in combination with ResourceDefinition.
We also have multiple
- ObjectTypeAttributeDefinition
- PropertiesAttributeDefinition
that are defined in different modules and have bit different implementation.
There are some other generic AttributeDefinition implementations that should be cleaned up and moved to controller module
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 7 months
[JBoss JIRA] (JBJCA-902) Unwanted config properties in a connectiondefinition/adminobject from another connectiondefinition/adminobject in the same resource adapter
by Stefano Maestri (JIRA)
[ https://issues.jboss.org/browse/JBJCA-902?page=com.atlassian.jira.plugin.... ]
Stefano Maestri resolved JBJCA-902.
-----------------------------------
Resolution: Done
> Unwanted config properties in a connectiondefinition/adminobject from another connectiondefinition/adminobject in the same resource adapter
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBJCA-902
> URL: https://issues.jboss.org/browse/JBJCA-902
> Project: IronJacamar
> Issue Type: Bug
> Components: Common
> Affects Versions: 1.0.12.Final, 1.1.0.Beta2
> Reporter: Simone Gotti
> Assignee: Stefano Maestri
> Priority: Critical
> Fix For: 1.0.13.Final, 1.1.0.Beta3
>
>
> With the effects of issue AS7-5644 I noticed that the connection definition with missing system properties, instead of failing, was using properties from another connection definition (with a lot of consequent problems)
> After a lot of analysis the problem is that the org.jboss.jca.common.api.metadata.ra.Connector's system properties are polluted with the merged values of the user specified connectiondefinitions/adminobjects and these system properties's defaults are inserted in the user defined connectiondefinition/adminobject that don't define them.
> I think that the wrong operation is in the start method of org.jboss.as.connector.services.resourceadapters.deployment.ResourceAdapterXmlDeploymentService.java:
> cmd = (new Merger()).mergeConnectorWithCommonIronJacamar(raxml, cmd);
> I think that merging should be between IronJacamar -> Connector and not raxml -> Connector:
> cmd = (new Merger()).mergeConnectorWithCommonIronJacamar(ijmd, cmd);
> After this change I see that the Connector is clean and no unwanted default are added inside my connectiondefinitions/adminobjects
> I'll attach the possible pull request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 7 months
[JBoss JIRA] (AS7-5663) CLONE - System properties are currently unusable for setting a connector's proxy-name
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/AS7-5663?page=com.atlassian.jira.plugin.s... ]
Tomaz Cerar moved JBPAPP-10061 to AS7-5663:
-------------------------------------------
Project: Application Server 7 (was: JBoss Enterprise Application Platform)
Key: AS7-5663 (was: JBPAPP-10061)
Workflow: GIT Pull Request workflow (was: jira)
Affects Version/s: 7.1.1.Final
(was: EAP 6.0.0)
Component/s: Domain Management
Web
(was: Web)
Security: (was: Public)
Docs QE Status: (was: NEW)
> CLONE - System properties are currently unusable for setting a connector's proxy-name
> -------------------------------------------------------------------------------------
>
> Key: AS7-5663
> URL: https://issues.jboss.org/browse/AS7-5663
> Project: Application Server 7
> Issue Type: Enhancement
> Components: Domain Management, Web
> Affects Versions: 7.1.1.Final
> Environment: -JBoss Enterprise Application Platform (EAP) 6.0.0
> Reporter: Aaron Ogburn
> Assignee: Tomaz Cerar
>
> A connector's proxy-name cannot be set through system properties currently in the web subsystem:
> ==domain.xml==
> <subsystem xmlns="urn:jbossomain:web:1.1" default-virtual-server="default-host" instance-id="${jboss.node.name}"
> native="false">
> <connector name="http" protocol="HTTP/1.1" scheme="http" socket-binding="http" proxy-name="${jboss.proxy.name}"/>
> The property is never parsed though and
> request.getServerName() just returns ${jboss.node.name}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 7 months
[JBoss JIRA] (AS7-5661) CLONE - Absolute path in attribute "path" in paging-directory, bindings-directory, journal-directory and large-messages-directory elements is always taken as relative path
by Miroslav Novak (JIRA)
[ https://issues.jboss.org/browse/AS7-5661?page=com.atlassian.jira.plugin.s... ]
Miroslav Novak commented on AS7-5661:
-------------------------------------
You're right. Somehow I missed it when I was looking for it.
Thanks,
Jeff
> CLONE - Absolute path in attribute "path" in paging-directory, bindings-directory, journal-directory and large-messages-directory elements is always taken as relative path
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: AS7-5661
> URL: https://issues.jboss.org/browse/AS7-5661
> Project: Application Server 7
> Issue Type: Bug
> Components: JMS
> Affects Versions: 7.1.3.Final (EAP)
> Reporter: Miroslav Novak
> Assignee: Jeff Mesnil
> Fix For: 7.1.4.Final (EAP)
>
>
> When HornetQ journal is specified using absolute paths then it's treated as relative path:
> {code}
> <hornetq-server>
> ...
> <paging-directory path="/home/jbossqa/hornetq_eap6_testsuite/journal_A/paging"/>
> <bindings-directory path="/home/jbossqa/hornetq_eap6_testsuite/journal_A/bindings"/>
> <journal-directory path="/home/jbossqa/hornetq_eap6_testsuite/journal_A/journal"/>
> <large-messages-directory path="/home/jbossqa/hornetq_eap6_testsuite/journal_A/large-messages"/>
> ...
> </hornetq-server>
> {code}
> Server log:
> {code}
> 15:29:07,418 INFO [org.hornetq.core.server.impl.HornetQServerImpl] (MSC service thread 1-7) live server is starting with configuration HornetQ Configuration (clustered=true,backup=false,sharedStore=true,journalDirectory=/home/jbossqa/hornetq_eap6_testsuite/server1/jboss-eap-6.0/standalone/data//home/jbossqa/hornetq_eap6_testsuite/journal_A/journal,bindingsDirectory=/home/jbossqa/hornetq_eap6_testsuite/server1/jboss-eap-6.0/standalone/data//home/jbossqa/hornetq_eap6_testsuite/journal_A/bindings,largeMessagesDirectory=/home/jbossqa/hornetq_eap6_testsuite/server1/jboss-eap-6.0/standalone/data//home/jbossqa/hornetq_eap6_testsuite/journal_A/large-messages,pagingDirectory=/home/jbossqa/hornetq_eap6_testsuite/server1/jboss-eap-6.0/standalone/data//home/jbossqa/hornetq_eap6_testsuite/journal_A/paging)
> {code}
> Definition of "directoryType" from jboss-as-messaging_1_2.xsd:
> {code}
> <xs:complexType name="directoryType">
> <xs:annotation>
> <xs:documentation>
> <![CDATA[
> A directory location configuration.
> The "path" attribute denotes a relative or absolute filesystem pathname where the directory should be
> located.
> The "relative-to" attribute references a global path configuration in the domain model, defaulting
> to the JBoss Application Server data directory (jboss.server.data.dir). If the value of the "path" attribute
> does not specify an absolute pathname, it will treated as relative to this path.
> ]]>
> </xs:documentation>
> </xs:annotation>
> <xs:attribute name="relative-to" type="xs:string" default="jboss.server.data.dir" />
> <xs:attribute name="path" type="xs:string" />
> </xs:complexType>
> {code}
> It seems that detection that given string in path attribute is absolute path is not correct.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 7 months
[JBoss JIRA] (AS7-5661) CLONE - Absolute path in attribute "path" in paging-directory, bindings-directory, journal-directory and large-messages-directory elements is always taken as relative path
by Jeff Mesnil (JIRA)
[ https://issues.jboss.org/browse/AS7-5661?page=com.atlassian.jira.plugin.s... ]
Jeff Mesnil resolved AS7-5661.
------------------------------
Resolution: Duplicate Issue
this issue has been fixed in AS7-5600
> CLONE - Absolute path in attribute "path" in paging-directory, bindings-directory, journal-directory and large-messages-directory elements is always taken as relative path
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: AS7-5661
> URL: https://issues.jboss.org/browse/AS7-5661
> Project: Application Server 7
> Issue Type: Bug
> Components: JMS
> Affects Versions: 7.1.3.Final (EAP)
> Reporter: Miroslav Novak
> Assignee: Jeff Mesnil
> Fix For: 7.1.4.Final (EAP)
>
>
> When HornetQ journal is specified using absolute paths then it's treated as relative path:
> {code}
> <hornetq-server>
> ...
> <paging-directory path="/home/jbossqa/hornetq_eap6_testsuite/journal_A/paging"/>
> <bindings-directory path="/home/jbossqa/hornetq_eap6_testsuite/journal_A/bindings"/>
> <journal-directory path="/home/jbossqa/hornetq_eap6_testsuite/journal_A/journal"/>
> <large-messages-directory path="/home/jbossqa/hornetq_eap6_testsuite/journal_A/large-messages"/>
> ...
> </hornetq-server>
> {code}
> Server log:
> {code}
> 15:29:07,418 INFO [org.hornetq.core.server.impl.HornetQServerImpl] (MSC service thread 1-7) live server is starting with configuration HornetQ Configuration (clustered=true,backup=false,sharedStore=true,journalDirectory=/home/jbossqa/hornetq_eap6_testsuite/server1/jboss-eap-6.0/standalone/data//home/jbossqa/hornetq_eap6_testsuite/journal_A/journal,bindingsDirectory=/home/jbossqa/hornetq_eap6_testsuite/server1/jboss-eap-6.0/standalone/data//home/jbossqa/hornetq_eap6_testsuite/journal_A/bindings,largeMessagesDirectory=/home/jbossqa/hornetq_eap6_testsuite/server1/jboss-eap-6.0/standalone/data//home/jbossqa/hornetq_eap6_testsuite/journal_A/large-messages,pagingDirectory=/home/jbossqa/hornetq_eap6_testsuite/server1/jboss-eap-6.0/standalone/data//home/jbossqa/hornetq_eap6_testsuite/journal_A/paging)
> {code}
> Definition of "directoryType" from jboss-as-messaging_1_2.xsd:
> {code}
> <xs:complexType name="directoryType">
> <xs:annotation>
> <xs:documentation>
> <![CDATA[
> A directory location configuration.
> The "path" attribute denotes a relative or absolute filesystem pathname where the directory should be
> located.
> The "relative-to" attribute references a global path configuration in the domain model, defaulting
> to the JBoss Application Server data directory (jboss.server.data.dir). If the value of the "path" attribute
> does not specify an absolute pathname, it will treated as relative to this path.
> ]]>
> </xs:documentation>
> </xs:annotation>
> <xs:attribute name="relative-to" type="xs:string" default="jboss.server.data.dir" />
> <xs:attribute name="path" type="xs:string" />
> </xs:complexType>
> {code}
> It seems that detection that given string in path attribute is absolute path is not correct.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 7 months
[JBoss JIRA] (AS7-5661) CLONE - Absolute path in attribute "path" in paging-directory, bindings-directory, journal-directory and large-messages-directory elements is always taken as relative path
by Miroslav Novak (JIRA)
[ https://issues.jboss.org/browse/AS7-5661?page=com.atlassian.jira.plugin.s... ]
Miroslav Novak reassigned AS7-5661:
-----------------------------------
Assignee: Jeff Mesnil (was: Clebert Suconic)
> CLONE - Absolute path in attribute "path" in paging-directory, bindings-directory, journal-directory and large-messages-directory elements is always taken as relative path
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: AS7-5661
> URL: https://issues.jboss.org/browse/AS7-5661
> Project: Application Server 7
> Issue Type: Bug
> Components: JMS
> Affects Versions: 7.1.3.Final (EAP)
> Reporter: Miroslav Novak
> Assignee: Jeff Mesnil
> Fix For: 7.1.4.Final (EAP)
>
>
> When HornetQ journal is specified using absolute paths then it's treated as relative path:
> {code}
> <hornetq-server>
> ...
> <paging-directory path="/home/jbossqa/hornetq_eap6_testsuite/journal_A/paging"/>
> <bindings-directory path="/home/jbossqa/hornetq_eap6_testsuite/journal_A/bindings"/>
> <journal-directory path="/home/jbossqa/hornetq_eap6_testsuite/journal_A/journal"/>
> <large-messages-directory path="/home/jbossqa/hornetq_eap6_testsuite/journal_A/large-messages"/>
> ...
> </hornetq-server>
> {code}
> Server log:
> {code}
> 15:29:07,418 INFO [org.hornetq.core.server.impl.HornetQServerImpl] (MSC service thread 1-7) live server is starting with configuration HornetQ Configuration (clustered=true,backup=false,sharedStore=true,journalDirectory=/home/jbossqa/hornetq_eap6_testsuite/server1/jboss-eap-6.0/standalone/data//home/jbossqa/hornetq_eap6_testsuite/journal_A/journal,bindingsDirectory=/home/jbossqa/hornetq_eap6_testsuite/server1/jboss-eap-6.0/standalone/data//home/jbossqa/hornetq_eap6_testsuite/journal_A/bindings,largeMessagesDirectory=/home/jbossqa/hornetq_eap6_testsuite/server1/jboss-eap-6.0/standalone/data//home/jbossqa/hornetq_eap6_testsuite/journal_A/large-messages,pagingDirectory=/home/jbossqa/hornetq_eap6_testsuite/server1/jboss-eap-6.0/standalone/data//home/jbossqa/hornetq_eap6_testsuite/journal_A/paging)
> {code}
> Definition of "directoryType" from jboss-as-messaging_1_2.xsd:
> {code}
> <xs:complexType name="directoryType">
> <xs:annotation>
> <xs:documentation>
> <![CDATA[
> A directory location configuration.
> The "path" attribute denotes a relative or absolute filesystem pathname where the directory should be
> located.
> The "relative-to" attribute references a global path configuration in the domain model, defaulting
> to the JBoss Application Server data directory (jboss.server.data.dir). If the value of the "path" attribute
> does not specify an absolute pathname, it will treated as relative to this path.
> ]]>
> </xs:documentation>
> </xs:annotation>
> <xs:attribute name="relative-to" type="xs:string" default="jboss.server.data.dir" />
> <xs:attribute name="path" type="xs:string" />
> </xs:complexType>
> {code}
> It seems that detection that given string in path attribute is absolute path is not correct.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 7 months