[JBoss JIRA] (LOGTOOL-44) Make configurable whether @Override annotation shall be added
by Gunnar Morling (JIRA)
Gunnar Morling created LOGTOOL-44:
-------------------------------------
Summary: Make configurable whether @Override annotation shall be added
Key: LOGTOOL-44
URL: https://issues.jboss.org/browse/LOGTOOL-44
Project: Log Tool
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Affects Versions: 1.0.1.Final
Reporter: Gunnar Morling
Assignee: David Lloyd
The annotation processor adds the {{(a)java.lang.Override}} annotation to the methods of generated log or message bundle classes. For methods implementing interface methods this is allowed only in Java 6 and above, while in Java 5 {{@Override}} is only allowed for methods overriding methods from superclasses.
Therefore compilation of the generated classes fails using Java 5. To address this issue, the annotation should be added conditionally based on the current source level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (LOGTOOL-45) Avoid unnecessary calls to String#format()
by Gunnar Morling (JIRA)
Gunnar Morling created LOGTOOL-45:
-------------------------------------
Summary: Avoid unnecessary calls to String#format()
Key: LOGTOOL-45
URL: https://issues.jboss.org/browse/LOGTOOL-45
Project: Log Tool
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Reporter: Gunnar Morling
Assignee: David Lloyd
Generated message bundle methods always contain an invocation of {{String#format()}} also if there actually is no parameter to be replaced, e.g. like this:
{code}
@Override
public final String mustNotBeNull() {
String result = String.format(mustNotBeNull0$str());
return result;
}
{code}
AFAICS the invocation of {{format()}} seems superfluous, instead the String might directly be returned for performance reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (LOGTOOL-51) Logging generation processing breaks APT rules by loading classes via reflection
by David Lloyd (JIRA)
[ https://issues.jboss.org/browse/LOGTOOL-51?page=com.atlassian.jira.plugin... ]
David Lloyd resolved LOGTOOL-51.
--------------------------------
Fix Version/s: 1.1.0.Beta1
Resolution: Done
> Logging generation processing breaks APT rules by loading classes via reflection
> --------------------------------------------------------------------------------
>
> Key: LOGTOOL-51
> URL: https://issues.jboss.org/browse/LOGTOOL-51
> Project: Log Tool
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Environment: JBDS 5.5.0.CR1
> Reporter: Fred Bricon
> Assignee: David Lloyd
> Priority: Blocker
> Fix For: 1.1.0.Beta1
>
> Attachments: codemodel-2.6.jar, jboss-logging-processor-1.1.0.Beta1-SNAPSHOT.jar
>
>
> JBDS 5.5.0.CR1 embeds [m2e-apt|https://github.com/jbosstools/m2e-apt], which automatically enables Eclipse JDT Annotation Processor Toolkit.
> When importing the [server|https://github.com/jbossas/jboss-as/tree/master/server] module from http://github.com/jbossas/jboss-as.git (also happens for other modules), Eclipse starts crashing (see JBIDE-12087) with errors like :
> {noformat}
> javax.xml.parsers.FactoryConfigurationError: Provider __redirected.__DocumentBuilderFactory not found
> at javax.xml.parsers.DocumentBuilderFactory.newInstance(DocumentBuilderFactory.java:127)
> at org.eclipse.jdt.apt.core.internal.util.FactoryPathUtil.decodeFactoryPath(FactoryPathUtil.java:222)
> at org.eclipse.jdt.apt.core.internal.util.FactoryPathUtil.readFactoryPathFile(FactoryPathUtil.java:115)
> at org.eclipse.jdt.apt.core.internal.util.FactoryPathUtil.calculatePath(FactoryPathUtil.java:342)
> at org.eclipse.jdt.apt.core.internal.util.FactoryPathUtil.getFactoryPath(FactoryPathUtil.java:429)
> at org.eclipse.jdt.apt.core.internal.AnnotationProcessorFactoryLoader.getJava6FactoriesAndAttributesForProject(AnnotationProcessorFactoryLoader.java:420)
> at org.eclipse.jdt.internal.apt.pluggable.core.dispatch.IdeAnnotationProcessorManager.processAnnotations(IdeAnnotationProcessorManager.java:130)
> at org.eclipse.jdt.internal.compiler.Compiler.processAnnotations(Compiler.java:813)
> at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:432)
> at org.eclipse.jdt.internal.core.builder.AbstractImageBuilder.compile(AbstractImageBuilder.java:364)
> at org.eclipse.jdt.internal.core.builder.BatchImageBuilder.compile(BatchImageBuilder.java:178)
> at org.eclipse.jdt.internal.core.builder.AbstractImageBuilder.compile(AbstractImageBuilder.java:301)
> at org.eclipse.jdt.internal.core.builder.BatchImageBuilder.build(BatchImageBuilder.java:60)
> at org.eclipse.jdt.internal.core.builder.JavaBuilder.buildAll(JavaBuilder.java:254)
> at org.eclipse.jdt.internal.core.builder.JavaBuilder.build(JavaBuilder.java:173)
> at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:728)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:199)
> at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:239)
> at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:292)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:295)
> at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:351)
> at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:374)
> at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:143)
> at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:241)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
> Caused by: java.lang.ClassNotFoundException: __redirected/__DocumentBuilderFactory
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at javax.xml.parsers.FactoryFinder.getProviderClass(FactoryFinder.java:119)
> at javax.xml.parsers.FactoryFinder.newInstance(FactoryFinder.java:144)
> at javax.xml.parsers.FactoryFinder.find(FactoryFinder.java:185)
> at javax.xml.parsers.DocumentBuilderFactory.newInstance(DocumentBuilderFactory.java:121)
> {noformat}
> It turns out the Eclipse System Properties have been changed to use javax.xml.parsers.SAXParserFactory=__redirected/__DocumentBuilderFactory
> I tracked the code responsible with messing with the properties :
> {noformat}
> Thread [Worker-24] (Suspended (breakpoint at line 779 in System))
> System.setProperty(String, String) line: 779
> __SAXParserFactory.<clinit>() line: 68
> __JAXPRedirected.initAll() line: 80
> Module$1.run() line: 126
> Module$1.run() line: 113
> AccessController.doPrivileged(PrivilegedAction<T>) line: not available [native method]
> Module.<clinit>() line: 113
> Class<T>.forName0(String, boolean, ClassLoader) line: not available [native method]
> Class<T>.forName(String) line: 186 <====== org.jboss.modules.Module
> JCodeModel.ref(String) line: 363
> MessageBundleImplementor(ImplementationClassModel).createBundleMethod(MessageMethod, JMethod, JMethod, JVar) line: 150
> MessageBundleImplementor.generateModel() line: 86
> MessageBundleImplementor(ClassModel).create(JavaFileObject) line: 104
> ImplementationClassGenerator.processTypeElement(TypeElement, TypeElement, MessageInterface) line: 63
> LoggingToolsProcessor.process(Set<TypeElement>, RoundEnvironment) line: 155
> RoundDispatcher.handleProcessor(ProcessorInfo) line: 139
> RoundDispatcher.round() line: 121
> IdeAnnotationProcessorManager(BaseAnnotationProcessorManager).processAnnotations(CompilationUnitDeclaration[], ReferenceBinding[], boolean) line: 159
> IdeAnnotationProcessorManager.processAnnotations(CompilationUnitDeclaration[], ReferenceBinding[], boolean) line: 134
> Compiler.processAnnotations() line: 813
> Compiler.compile(ICompilationUnit[]) line: 432
> BatchImageBuilder(AbstractImageBuilder).compile(SourceFile[], SourceFile[], boolean) line: 364
> BatchImageBuilder.compile(SourceFile[], SourceFile[], boolean) line: 178
> BatchImageBuilder(AbstractImageBuilder).compile(SourceFile[]) line: 301
> BatchImageBuilder.build() line: 60
> JavaBuilder.buildAll() line: 254
> JavaBuilder.build(int, Map, IProgressMonitor) line: 173
> BuildManager$2.run() line: 728
> SafeRunner.run(ISafeRunnable) line: 42
> BuildManager.basicBuild(int, IncrementalProjectBuilder, Map<String,String>, MultiStatus, IProgressMonitor) line: 199
> BuildManager.basicBuild(IBuildConfiguration, int, IBuildContext, ICommand[], MultiStatus, IProgressMonitor) line: 239
> BuildManager$1.run() line: 292
> SafeRunner.run(ISafeRunnable) line: 42
> BuildManager.basicBuild(IBuildConfiguration, int, IBuildContext, MultiStatus, IProgressMonitor) line: 295
> BuildManager.basicBuildLoop(IBuildConfiguration[], IBuildConfiguration[], int, MultiStatus, IProgressMonitor) line: 351
> BuildManager.build(IBuildConfiguration[], IBuildConfiguration[], int, IProgressMonitor) line: 374
> AutoBuildJob.doBuild(IProgressMonitor) line: 143
> AutoBuildJob.run(IProgressMonitor) line: 241
> Worker.run() line: 54
> {noformat}
> That stacktrace represents the processing of https://github.com/jbossas/jboss-as/blob/master/server/src/main/java/org/...
> So basically, whenever a Logger has a dependency to the [org.jboss.modules.Module|https://github.com/jbossas/jboss-modules/blob/ma...] class, stuff starts hitting the fan.
> Classes should not be loaded by reflection during APT processing to avoid such issues - it should use the API provided by APT to iterate over the classes metadata provided by the compiler and not depend on com.sun.*.internal classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (SECURITY-694) ClientLoginModule should be extensible for custom pricipals
by Dennis Kieselhorst (JIRA)
Dennis Kieselhorst created SECURITY-694:
-------------------------------------------
Summary: ClientLoginModule should be extensible for custom pricipals
Key: SECURITY-694
URL: https://issues.jboss.org/browse/SECURITY-694
Project: PicketBox (JBoss Security and Identity Management)
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Components: PicketBox
Affects Versions: PicketBox_v4_0_9.Final
Reporter: Dennis Kieselhorst
Assignee: Anil Saldhana
Currently only a NameCallback is supported. ClientLoginModule should also support callbacks for custom principals.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (AS7-5478) Upgrade Infinispan to 5.1.7.Final
by Radoslav Husar (JIRA)
Radoslav Husar created AS7-5478:
-----------------------------------
Summary: Upgrade Infinispan to 5.1.7.Final
Key: AS7-5478
URL: https://issues.jboss.org/browse/AS7-5478
Project: Application Server 7
Issue Type: Component Upgrade
Components: Clustering
Reporter: Radoslav Husar
Assignee: Radoslav Husar
Fix For: 7.1.3.Final (EAP)
We will probably need a component upgrade in Infinispan incorporating changes in Dan's branch to resolve JBPAPP-9658/AS7-5381 and possibly AS7-5442.
Last release is 5.1.6.Final.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (AS7-5499) Upgrade HornetQ to 2.2.19.Final-build2
by Jeff Mesnil (JIRA)
Jeff Mesnil created AS7-5499:
--------------------------------
Summary: Upgrade HornetQ to 2.2.19.Final-build2
Key: AS7-5499
URL: https://issues.jboss.org/browse/AS7-5499
Project: Application Server 7
Issue Type: Component Upgrade
Components: JMS
Reporter: Jeff Mesnil
Assignee: Jeff Mesnil
Fix For: 7.1.3.Final (EAP)
this version of HornetQ depends on Netty 3.2.2.Final and corresponds to HornetQ 2.2.19.Final minus HORNETQ-819
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (JBWEB-246) Configure Jboss loadbalancing in Window 2008 R2
by Buntha Ly (JIRA)
Buntha Ly created JBWEB-246:
-------------------------------
Summary: Configure Jboss loadbalancing in Window 2008 R2
Key: JBWEB-246
URL: https://issues.jboss.org/browse/JBWEB-246
Project: JBoss Web
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Components: Cluster
Environment: Window Server 2008 R2 configured as clustering and loadbalancing
Reporter: Buntha Ly
Assignee: Remy Maucherat
Priority: Critical
Hi Everyone,
I am very new with Jboss. Could you please share me some document to configure and set up Jboss loadbalancing in Window 2008 R2 configure as clustering?
Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (AS7-4140) Change distribution of -Dmcast through testsuite
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/AS7-4140?page=com.atlassian.jira.plugin.s... ]
Radoslav Husar commented on AS7-4140:
-------------------------------------
Ondro Can you resubmit and link the PR now? Or is there some outstanding issue?
> Change distribution of -Dmcast through testsuite
> ------------------------------------------------
>
> Key: AS7-4140
> URL: https://issues.jboss.org/browse/AS7-4140
> Project: Application Server 7
> Issue Type: Feature Request
> Components: Test Suite
> Affects Versions: 7.1.1.Final
> Reporter: Pavel Janousek
> Assignee: Ondrej Zizka
> Priority: Minor
> Fix For: 7.1.2.Final (EAP)
>
>
> Please change present behavior.
> We need to define only one property -Dmcast (for ex., the name doesn't matter now) as command line parameter - this multicast address is needed to be distributed to every subsystem which manages any multicast communication. It is needed to be unique in every subsystem - JGroups, HornetQ etc. because we must avoid to interfere each other => port assignation must be unique for every a such component.
> This change is needed in both - IPV4 and IPv6...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months