11:52 p.m.
Gunnar Morling created LOGTOOL-45:
-------------------------------------
Summary: Avoid unnecessary calls to String#format()
Key: LOGTOOL-45
URL: https://issues.jboss.org/browse/LOGTOOL-45
Project: Log Tool
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Reporter: Gunnar Morling
Assignee: David Lloyd
Generated message bundle methods always contain an invocation of {{String#format()}} also
if there actually is no parameter to be replaced, e.g. like this:
{code}
@Override
public final String mustNotBeNull() {
String result = String.format(mustNotBeNull0$str());
return result;
}
{code}
AFAICS the invocation of {{format()}} seems superfluous, instead the String might directly
be returned for performance reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:50 a.m.
[
https://issues.jboss.org/browse/LOGTOOL-45?page=com.atlassian.jira.plugin...
]
David Lloyd reassigned LOGTOOL-45:
----------------------------------
Assignee: James Perkins (was: David Lloyd)
Avoid unnecessary calls to String#format()
------------------------------------------
Key: LOGTOOL-45
URL: https://issues.jboss.org/browse/LOGTOOL-45
Project: Log Tool
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Reporter: Gunnar Morling
Assignee: James Perkins
Generated message bundle methods always contain an invocation of {{String#format()}} also
if there actually is no parameter to be replaced, e.g. like this:
{code}
@Override
public final String mustNotBeNull() {
String result = String.format(mustNotBeNull0$str());
return result;
}
{code}
AFAICS the invocation of {{format()}} seems superfluous, instead the String might
directly be returned for performance reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:06 a.m.
[
https://issues.jboss.org/browse/LOGTOOL-45?page=com.atlassian.jira.plugin...
]
James Perkins commented on LOGTOOL-45:
--------------------------------------
This was actually done on purpose. It is possible, I know I've done it, to not require
arguments in a string format, but still use a format. e.g.
{code} String.format("Some messages%n") {code}
The only real way to do this would be to tear apart the message and look for format
arguments that don't require parameters. I'm open to debate whether parsing the
string for values is worth the effort though :-) I don't think the performance would
be a huge disadvantage, but I do realize there is a cost there.
Avoid unnecessary calls to String#format()
------------------------------------------
Key: LOGTOOL-45
URL: https://issues.jboss.org/browse/LOGTOOL-45
Project: Log Tool
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Reporter: Gunnar Morling
Assignee: James Perkins
Generated message bundle methods always contain an invocation of {{String#format()}} also
if there actually is no parameter to be replaced, e.g. like this:
{code}
@Override
public final String mustNotBeNull() {
String result = String.format(mustNotBeNull0$str());
return result;
}
{code}
AFAICS the invocation of {{format()}} seems superfluous, instead the String might
directly be returned for performance reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:39 p.m.
[
https://issues.jboss.org/browse/LOGTOOL-45?page=com.atlassian.jira.plugin...
]
David Lloyd commented on LOGTOOL-45:
------------------------------------
We could maybe add a third formatting option like NOFORMAT for messages, and forbid
arguments from being specified.
Avoid unnecessary calls to String#format()
------------------------------------------
Key: LOGTOOL-45
URL: https://issues.jboss.org/browse/LOGTOOL-45
Project: Log Tool
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Reporter: Gunnar Morling
Assignee: James Perkins
Generated message bundle methods always contain an invocation of {{String#format()}} also
if there actually is no parameter to be replaced, e.g. like this:
{code}
@Override
public final String mustNotBeNull() {
String result = String.format(mustNotBeNull0$str());
return result;
}
{code}
AFAICS the invocation of {{format()}} seems superfluous, instead the String might
directly be returned for performance reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:49 p.m.
[
https://issues.jboss.org/browse/LOGTOOL-45?page=com.atlassian.jira.plugin...
]
Gunnar Morling commented on LOGTOOL-45:
---------------------------------------
We could maybe add a third formatting option like NOFORMAT for
messages, and forbid arguments from being specified.
Ah, I was just about to propose something along these lines :-)
Admittedly, the overhead due to the formatting is not huge, but when profiling Hibernate
Validator, the calls to {{String#format()}} caught my attention.
Avoid unnecessary calls to String#format()
------------------------------------------
Key: LOGTOOL-45
URL: https://issues.jboss.org/browse/LOGTOOL-45
Project: Log Tool
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Reporter: Gunnar Morling
Assignee: James Perkins
Generated message bundle methods always contain an invocation of {{String#format()}} also
if there actually is no parameter to be replaced, e.g. like this:
{code}
@Override
public final String mustNotBeNull() {
String result = String.format(mustNotBeNull0$str());
return result;
}
{code}
AFAICS the invocation of {{format()}} seems superfluous, instead the String might
directly be returned for performance reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:49 p.m.
[
https://issues.jboss.org/browse/LOGTOOL-45?page=com.atlassian.jira.plugin...
]
Gunnar Morling edited comment on LOGTOOL-45 at 3/30/12 9:49 AM:
----------------------------------------------------------------
{quote}
We could maybe add a third formatting option like NOFORMAT for messages, and forbid
arguments from being specified.
{quote}
Ah, I was just about to propose something along these lines :-)
Admittedly, the overhead due to the formatting is not huge, but when profiling Hibernate
Validator, the calls to {{String#format()}} caught my attention.
was (Author: gunnar.morling):
We could maybe add a third formatting option like NOFORMAT for
messages, and forbid arguments from being specified.
Ah, I was just about to propose something along these lines :-)
Admittedly, the overhead due to the formatting is not huge, but when profiling Hibernate
Validator, the calls to {{String#format()}} caught my attention.
Avoid unnecessary calls to String#format()
------------------------------------------
Key: LOGTOOL-45
URL: https://issues.jboss.org/browse/LOGTOOL-45
Project: Log Tool
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Reporter: Gunnar Morling
Assignee: James Perkins
Generated message bundle methods always contain an invocation of {{String#format()}} also
if there actually is no parameter to be replaced, e.g. like this:
{code}
@Override
public final String mustNotBeNull() {
String result = String.format(mustNotBeNull0$str());
return result;
}
{code}
AFAICS the invocation of {{format()}} seems superfluous, instead the String might
directly be returned for performance reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2 p.m.
[
https://issues.jboss.org/browse/LOGTOOL-45?page=com.atlassian.jira.plugin...
]
Hardy Ferentschik commented on LOGTOOL-45:
------------------------------------------
+1 for an option. The overhead for _String#format_ seem considerable. An alternative would
be to cache the strings for method calls w/o parameters. This could eg be done once of at
class initialization.
Avoid unnecessary calls to String#format()
------------------------------------------
Key: LOGTOOL-45
URL: https://issues.jboss.org/browse/LOGTOOL-45
Project: Log Tool
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Reporter: Gunnar Morling
Assignee: James Perkins
Generated message bundle methods always contain an invocation of {{String#format()}} also
if there actually is no parameter to be replaced, e.g. like this:
{code}
@Override
public final String mustNotBeNull() {
String result = String.format(mustNotBeNull0$str());
return result;
}
{code}
AFAICS the invocation of {{format()}} seems superfluous, instead the String might
directly be returned for performance reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:58 p.m.
[
https://issues.jboss.org/browse/LOGTOOL-45?page=com.atlassian.jira.plugin...
]
James Perkins resolved LOGTOOL-45.
----------------------------------
Fix Version/s: 1.0.2.Final
Resolution: Done
Added a NO_FORMAT option to the @Message annotation in JBL.
https://github.com/jboss-logging/jboss-logging-tools/commit/50539c95a6768...
Avoid unnecessary calls to String#format()
------------------------------------------
Key: LOGTOOL-45
URL: https://issues.jboss.org/browse/LOGTOOL-45
Project: Log Tool
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Reporter: Gunnar Morling
Assignee: James Perkins
Fix For: 1.0.2.Final
Generated message bundle methods always contain an invocation of {{String#format()}} also
if there actually is no parameter to be replaced, e.g. like this:
{code}
@Override
public final String mustNotBeNull() {
String result = String.format(mustNotBeNull0$str());
return result;
}
{code}
AFAICS the invocation of {{format()}} seems superfluous, instead the String might
directly be returned for performance reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:58 p.m.
[
https://issues.jboss.org/browse/LOGTOOL-45?page=com.atlassian.jira.plugin...
]
James Perkins closed LOGTOOL-45.
--------------------------------
Avoid unnecessary calls to String#format()
------------------------------------------
Key: LOGTOOL-45
URL: https://issues.jboss.org/browse/LOGTOOL-45
Project: Log Tool
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Reporter: Gunnar Morling
Assignee: James Perkins
Fix For: 1.0.2.Final
Generated message bundle methods always contain an invocation of {{String#format()}} also
if there actually is no parameter to be replaced, e.g. like this:
{code}
@Override
public final String mustNotBeNull() {
String result = String.format(mustNotBeNull0$str());
return result;
}
{code}
AFAICS the invocation of {{format()}} seems superfluous, instead the String might
directly be returned for performance reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:47 p.m.
[
https://issues.jboss.org/browse/LOGTOOL-45?page=com.atlassian.jira.plugin...
]
David Lloyd resolved LOGTOOL-45.
--------------------------------
Fix Version/s: 1.1.0.Beta1
Resolution: Done
Avoid unnecessary calls to String#format()
------------------------------------------
Key: LOGTOOL-45
URL: https://issues.jboss.org/browse/LOGTOOL-45
Project: Log Tool
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Reporter: Gunnar Morling
Assignee: James Perkins
Fix For: 1.1.0.Beta1, 1.0.2.Final
Generated message bundle methods always contain an invocation of {{String#format()}} also
if there actually is no parameter to be replaced, e.g. like this:
{code}
@Override
public final String mustNotBeNull() {
String result = String.format(mustNotBeNull0$str());
return result;
}
{code}
AFAICS the invocation of {{format()}} seems superfluous, instead the String might
directly be returned for performance reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:47 p.m.
[
https://issues.jboss.org/browse/LOGTOOL-45?page=com.atlassian.jira.plugin...
]
David Lloyd reopened LOGTOOL-45:
--------------------------------
Reopening for edits
Avoid unnecessary calls to String#format()
------------------------------------------
Key: LOGTOOL-45
URL: https://issues.jboss.org/browse/LOGTOOL-45
Project: Log Tool
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Reporter: Gunnar Morling
Assignee: James Perkins
Fix For: 1.0.2.Final, 1.1.0.Beta1
Generated message bundle methods always contain an invocation of {{String#format()}} also
if there actually is no parameter to be replaced, e.g. like this:
{code}
@Override
public final String mustNotBeNull() {
String result = String.format(mustNotBeNull0$str());
return result;
}
{code}
AFAICS the invocation of {{format()}} seems superfluous, instead the String might
directly be returned for performance reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4300
days inactive
4463
days old
10 comments
4 participants
participants (4)
-
David Lloyd (JIRA) -
Gunnar Morling (JIRA)
-
Hardy Ferentschik (JIRA)
-
James Perkins (JIRA)