[JBoss JIRA] (JGRP-1762) Util.loadClass(): do we use the correct ClassLoader ?
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-1762?page=com.atlassian.jira.plugin.... ]
Bela Ban updated JGRP-1762:
---------------------------
Fix Version/s: 3.4.2
> Util.loadClass(): do we use the correct ClassLoader ?
> -----------------------------------------------------
>
> Key: JGRP-1762
> URL: https://issues.jboss.org/browse/JGRP-1762
> Project: JGroups
> Issue Type: Task
> Reporter: Bela Ban
> Assignee: Bela Ban
> Fix For: 3.4.2, 3.5
>
>
> Investigate whether the code below uses the right classloader. Perhaps we should try to get the classloader of the instances passed to us *before* attempting to use the calling thread's class loader ?
> The current code is:
> {noformat}
> public static Class loadClass(String classname, Class clazz) throws ClassNotFoundException {
> ClassLoader loader;
> try {
> loader=Thread.currentThread().getContextClassLoader();
> if(loader != null) {
> return loader.loadClass(classname);
> }
> }
> catch(Throwable t) {
> }
> if(clazz != null) {
> try {
> loader=clazz.getClassLoader();
> if(loader != null) {
> return loader.loadClass(classname);
> }
> }
> catch(Throwable t) {
> }
> }
> try {
> loader=ClassLoader.getSystemClassLoader();
> if(loader != null) {
> return loader.loadClass(classname);
> }
> }
> catch(Throwable t) {
> }
> throw new ClassNotFoundException(classname);
> }
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (JGRP-1762) Util.loadClass(): do we use the correct ClassLoader ?
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-1762?page=com.atlassian.jira.plugin.... ]
Bela Ban commented on JGRP-1762:
--------------------------------
Comments:
Andre Dietlisheim:
{quote}
>From what I have in mind when packaging libraries to bundles (long time ago, sorry) 1.) will cause havoc to most classpath partitioning frameworks (osgi, jboss modules etc). The code snippet in JGRP-1762 is very likely to fail if bundled. The current thread, your util class and the class you're trying to load may reside in different modules/bundles and visibility rules apply. It is thus is very likely that current thread classloader wont be able to load your class. You should start with 2), the classloader that is accessible via the class you try to load (clazz.getClassLoader() in your snippet).
There are most likely further hints that I have forgotten from those times that others here may come up. Jason Green wrote a nice blog that is describing best practices for module-aware classloading: https://community.jboss.org/wiki/ModuleCompatibleClassloadingGuide
{quote}
Jason Greene:
{quote}
What I can say is the TCCL lookups only make sense if
A) you have a separate API module that discovers a pluggable implementation that the user provides and is discovered lazily during a call from the user's application (e.g. JAXP DOM and STAX)
And
B) You have a reliable convention that says the TCCL will point to something reliable (like a Java EE container which sets it to the deployment)
{quote}
James Livingston:
{quote}
The correct answer is usually "it depends on what is loading the class
and why".
Is it some shared framework code (JGroups here) which is loading an EE
application class passed to it by name? Is it loading a class from a
name passed over the network to deserialise an object that's about to
follow? Something else? The problem with things like your
Util.loadClass() is that you don't know how it's being used so anything
you do will be wrong in some situations.
Often the best thing to do is to have the API take the classloader to
use as a parameter, and push the decision upwards to the caller who
either knows the search order or can push the decision upwards to their
caller.
{quote}
> Util.loadClass(): do we use the correct ClassLoader ?
> -----------------------------------------------------
>
> Key: JGRP-1762
> URL: https://issues.jboss.org/browse/JGRP-1762
> Project: JGroups
> Issue Type: Task
> Reporter: Bela Ban
> Assignee: Bela Ban
> Fix For: 3.5
>
>
> Investigate whether the code below uses the right classloader. Perhaps we should try to get the classloader of the instances passed to us *before* attempting to use the calling thread's class loader ?
> The current code is:
> {noformat}
> public static Class loadClass(String classname, Class clazz) throws ClassNotFoundException {
> ClassLoader loader;
> try {
> loader=Thread.currentThread().getContextClassLoader();
> if(loader != null) {
> return loader.loadClass(classname);
> }
> }
> catch(Throwable t) {
> }
> if(clazz != null) {
> try {
> loader=clazz.getClassLoader();
> if(loader != null) {
> return loader.loadClass(classname);
> }
> }
> catch(Throwable t) {
> }
> }
> try {
> loader=ClassLoader.getSystemClassLoader();
> if(loader != null) {
> return loader.loadClass(classname);
> }
> }
> catch(Throwable t) {
> }
> throw new ClassNotFoundException(classname);
> }
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (JGRP-1755) TP: dropping message to wrong destination in a shared transport
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-1755?page=com.atlassian.jira.plugin.... ]
Bela Ban updated JGRP-1755:
---------------------------
Summary: TP: dropping message to wrong destination in a shared transport (was: TP: dropping message to wrong destination)
> TP: dropping message to wrong destination in a shared transport
> ---------------------------------------------------------------
>
> Key: JGRP-1755
> URL: https://issues.jboss.org/browse/JGRP-1755
> Project: JGroups
> Issue Type: Bug
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Minor
> Fix For: 3.4.2, 3.5
>
> Attachments: bla3.java, shared.xml
>
>
> TP has a check whether the dest of incoming unicast messages matches its local address (or the local address in the ProtocolAdapter if a shared transport is used). Messages whose dest != local address are dropped.
> However, in the following scenario, we can have spurious warnings for 2 minutes (by default):
> * 2 processes with 2 members on a shared transport each (see attached shared.xml and bla3.java)
> ** Start 2 bla2 instances on the same box
> * On the second instance, a member leaves and immediately rejoins (press [2] on the second member)
> * For some reason, the leaving member didn't receive the {{LEAVE_RSP}} unicast message from the coordinator (first member)
> * The newly joined member now receives the {{LEAVE_RSP}} unicast from the coordinator, but now it is a different member and therefore has a different local address, so we see the warning
> * This will continue for 2 minutes, until the connection to the unknown member is closed by the coordinator (configurable)
> TODOs:
> * Investigate why the {{LEAVE_RSP}} unicast is not received by the leaving member
> * In the warning, add the sender's address and print the headers of the message so it's easier to find the culprit
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (JGRP-1755) TP: dropping message to wrong destination in a shared transport
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-1755?page=com.atlassian.jira.plugin.... ]
Bela Ban edited comment on JGRP-1755 at 12/23/13 4:00 AM:
----------------------------------------------------------
Note that this only occurs when a *shared transport is used*.
Hmm, the {{LEAVE_RSP}} *is* actually received quickly, so the question is why the coordinator keeps resending it. Perhaps the leaver hasn't yet acked it ?
was (Author: belaban):
Hmm, the {{LEAVE_RSP}} *is* actually received quickly, so the question is why the coordinator keeps resending it. Perhaps the leaver hasn't yet acked it ?
> TP: dropping message to wrong destination in a shared transport
> ---------------------------------------------------------------
>
> Key: JGRP-1755
> URL: https://issues.jboss.org/browse/JGRP-1755
> Project: JGroups
> Issue Type: Bug
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Minor
> Fix For: 3.4.2, 3.5
>
> Attachments: bla3.java, shared.xml
>
>
> TP has a check whether the dest of incoming unicast messages matches its local address (or the local address in the ProtocolAdapter if a shared transport is used). Messages whose dest != local address are dropped.
> However, in the following scenario, we can have spurious warnings for 2 minutes (by default):
> * 2 processes with 2 members on a shared transport each (see attached shared.xml and bla3.java)
> ** Start 2 bla2 instances on the same box
> * On the second instance, a member leaves and immediately rejoins (press [2] on the second member)
> * For some reason, the leaving member didn't receive the {{LEAVE_RSP}} unicast message from the coordinator (first member)
> * The newly joined member now receives the {{LEAVE_RSP}} unicast from the coordinator, but now it is a different member and therefore has a different local address, so we see the warning
> * This will continue for 2 minutes, until the connection to the unknown member is closed by the coordinator (configurable)
> TODOs:
> * Investigate why the {{LEAVE_RSP}} unicast is not received by the leaving member
> * In the warning, add the sender's address and print the headers of the message so it's easier to find the culprit
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (WFLY-2680) java:comp/DefaultDataSource doesn't work in persistence.xml
by jaikiran pai (JIRA)
[ https://issues.jboss.org/browse/WFLY-2680?page=com.atlassian.jira.plugin.... ]
jaikiran pai updated WFLY-2680:
-------------------------------
Assignee: David Lloyd
Affects Version/s: 8.0.0.CR1
Component/s: EE
JPA / Hibernate
> java:comp/DefaultDataSource doesn't work in persistence.xml
> -----------------------------------------------------------
>
> Key: WFLY-2680
> URL: https://issues.jboss.org/browse/WFLY-2680
> Project: WildFly
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: EE, JPA / Hibernate
> Affects Versions: 8.0.0.CR1
> Reporter: arjan tijms
> Assignee: David Lloyd
> Labels: javaee7, jdbc
>
> Having a persistence.xml with the following content fails the deployment on WildFly 8 CR1:
> {code:xml}
> <?xml version="1.0" encoding="UTF-8"?>
> <persistence version="2.1" xmlns="http://xmlns.jcp.org/xml/ns/persistence" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/persistence http://xmlns.jcp.org/xml/ns/persistence/persistence_2_1.xsd">
>
> <persistence-unit name="testPU">
> <jta-data-source>java:comp/DefaultDataSource</jta-data-source>
> </persistence-unit>
> </persistence>
> {code}
> It results in the following error:
> {noformat}
> 13:51:40,367 ERROR [org.jboss.as.controller.management-operation] (DeploymentScanner-threads - 2) JBAS014613: Operation ("deploy") failed - address: ([("deployment" => "dynamic-named-query.war")]) - failure description: {"JBAS014771: Services with missing/unavailable dependencies" => ["jboss.persistenceunit.\"dynamic-named-query.war#testPU\".__FIRST_PHASE__ is missing [jboss.naming.context.java.module.dynamic-named-query.dynamic-named-query.DefaultDataSource]"]}
> {noformat}
> When I proposed the feature for the default data source over at the Java EE JIRA (https://java.net/jira/browse/JAVAEE_SPEC-4) I intended this to work. In the description I hinted that the standard JNDI name would be the standard alternative for {{java:jboss/datasources/ExampleDS}} on JBoss. The latter indeed does work in {{persistence.xml}} using WildFly 8 CR1.
> Omitting the {{jta-data-source}} element altogether *does* work, which is great. However, I foresee a lot of users tripping over this in the future and just giving up the idea of using a default data source, especially since the error message is very cryptic for new developers.
> In GlassFish 4 using {{java:comp/DefaultDataSource}} in {{persistence.xml}} does work.
> See also WFLY-2027 and WFLY-2158
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (WFLY-2533) Add ability to set default character encoding on a subsystem level
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/WFLY-2533?page=com.atlassian.jira.plugin.... ]
Tomaz Cerar updated WFLY-2533:
------------------------------
Comment: was deleted
(was: Vielen Dank für Ihre Nachricht. Ich bin aktuell nicht im Büro und werde am Montag, den 13. Januar 2014 zurückkehren. Nachrichten die eine Antwort benötigen werde ich dann beantworten.
Markus Karnik
===
Thank you for your email. I am away from the office and will return on Monday, January 13, 2014. If your message requires a reply, I will respond when I return.
Markus Karnik
)
> Add ability to set default character encoding on a subsystem level
> ------------------------------------------------------------------
>
> Key: WFLY-2533
> URL: https://issues.jboss.org/browse/WFLY-2533
> Project: WildFly
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Web (Undertow)
> Reporter: Stuart Douglas
> Assignee: Tomaz Cerar
> Fix For: 8.0.0.CR1
>
>
> Stuart: the charset one should be pretty simple, just an attribute on <servlet-container?
> Stuart: ideally we would also have it in jboss-web.xml as well
> Stuart: I should also add an option to use the connector encoding
> Stuart: as connectors have their own encoding set
> Stuart: that is used to decode the URL
> Stuart: we should have an option to use the connector encoding as the default encoding
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (WFLY-2533) Add ability to set default character encoding on a subsystem level
by Markus Karnik (JIRA)
[ https://issues.jboss.org/browse/WFLY-2533?page=com.atlassian.jira.plugin.... ]
Markus Karnik commented on WFLY-2533:
-------------------------------------
Vielen Dank für Ihre Nachricht. Ich bin aktuell nicht im Büro und werde am Montag, den 13. Januar 2014 zurückkehren. Nachrichten die eine Antwort benötigen werde ich dann beantworten.
Markus Karnik
===
Thank you for your email. I am away from the office and will return on Monday, January 13, 2014. If your message requires a reply, I will respond when I return.
Markus Karnik
> Add ability to set default character encoding on a subsystem level
> ------------------------------------------------------------------
>
> Key: WFLY-2533
> URL: https://issues.jboss.org/browse/WFLY-2533
> Project: WildFly
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Web (Undertow)
> Reporter: Stuart Douglas
> Assignee: Tomaz Cerar
> Fix For: 8.0.0.CR1
>
>
> Stuart: the charset one should be pretty simple, just an attribute on <servlet-container?
> Stuart: ideally we would also have it in jboss-web.xml as well
> Stuart: I should also add an option to use the connector encoding
> Stuart: as connectors have their own encoding set
> Stuart: that is used to decode the URL
> Stuart: we should have an option to use the connector encoding as the default encoding
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months