[JBoss JIRA] (WFLY-2643) JBOSS_LOG_DIR is checked but not used to set jboss.server.log.dir
by Stian Lund (JIRA)
[ https://issues.jboss.org/browse/WFLY-2643?page=com.atlassian.jira.plugin.... ]
Stian Lund edited comment on WFLY-2643 at 12/12/13 4:06 PM:
------------------------------------------------------------
Thanks - maybe I should change to an enhancement request? As it's not a bug.
I don't have much experience with Git (if that's what you mean by PR) i'm afraid but maybe it's time to learn ;)
EDIT; Ah, you did, thanks!
was (Author: pathduck):
Thanks - maybe I should change to an enhancement request? As it's not a bug.
I don't have much experience with Git (if that's what you mean by PR) i'm afraid but maybe it's time to learn ;)
> JBOSS_LOG_DIR is checked but not used to set jboss.server.log.dir
> -----------------------------------------------------------------
>
> Key: WFLY-2643
> URL: https://issues.jboss.org/browse/WFLY-2643
> Project: WildFly
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: Logging, Server
> Affects Versions: JBoss AS7 7.1.1.Final, 8.0.0.Beta1
> Environment: All
> Reporter: Stian Lund
> Priority: Optional
> Labels: jbossas, logging, wildfly
>
> In standalone/domain start scripts (standalone.sh/bat) the value of environment variable JBOSS_LOG_DIR is checked for:
> {code}
> # determine the default log dir, if not set
> if [ "x$JBOSS_LOG_DIR" = "x" ]; then
> JBOSS_LOG_DIR="$JBOSS_BASE_DIR/log"
> fi
> {code}
> However, this is not actually used to set the value of Java property jboss.server.log.dir.
> {code}
> -Djboss.home.dir="$JBOSS_HOME"
> -Djboss.server.base.dir="$JBOSS_BASE_DIR"
> "$SERVER_OPTS"
> {code}
> (It should be set at the same place)
> This leads Jboss/Wildfly/EAP to assume the default value of $JBOSS_BASE_DIR/log.
> This is a problem for those who want to override the location of the server.log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (WFLY-2643) JBOSS_LOG_DIR is checked but not used to set jboss.server.log.dir
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/WFLY-2643?page=com.atlassian.jira.plugin.... ]
James Perkins updated WFLY-2643:
--------------------------------
Issue Type: Enhancement (was: Bug)
> JBOSS_LOG_DIR is checked but not used to set jboss.server.log.dir
> -----------------------------------------------------------------
>
> Key: WFLY-2643
> URL: https://issues.jboss.org/browse/WFLY-2643
> Project: WildFly
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: Logging, Server
> Affects Versions: JBoss AS7 7.1.1.Final, 8.0.0.Beta1
> Environment: All
> Reporter: Stian Lund
> Labels: jbossas, logging, wildfly
>
> In standalone/domain start scripts (standalone.sh/bat) the value of environment variable JBOSS_LOG_DIR is checked for:
> {code}
> # determine the default log dir, if not set
> if [ "x$JBOSS_LOG_DIR" = "x" ]; then
> JBOSS_LOG_DIR="$JBOSS_BASE_DIR/log"
> fi
> {code}
> However, this is not actually used to set the value of Java property jboss.server.log.dir.
> {code}
> -Djboss.home.dir="$JBOSS_HOME"
> -Djboss.server.base.dir="$JBOSS_BASE_DIR"
> "$SERVER_OPTS"
> {code}
> (It should be set at the same place)
> This leads Jboss/Wildfly/EAP to assume the default value of $JBOSS_BASE_DIR/log.
> This is a problem for those who want to override the location of the server.log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (WFLY-2643) JBOSS_LOG_DIR is checked but not used to set jboss.server.log.dir
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/WFLY-2643?page=com.atlassian.jira.plugin.... ]
James Perkins reopened WFLY-2643:
---------------------------------
Assignee: (was: James Perkins)
> JBOSS_LOG_DIR is checked but not used to set jboss.server.log.dir
> -----------------------------------------------------------------
>
> Key: WFLY-2643
> URL: https://issues.jboss.org/browse/WFLY-2643
> Project: WildFly
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Logging, Server
> Affects Versions: JBoss AS7 7.1.1.Final, 8.0.0.Beta1
> Environment: All
> Reporter: Stian Lund
> Labels: jbossas, logging, wildfly
>
> In standalone/domain start scripts (standalone.sh/bat) the value of environment variable JBOSS_LOG_DIR is checked for:
> {code}
> # determine the default log dir, if not set
> if [ "x$JBOSS_LOG_DIR" = "x" ]; then
> JBOSS_LOG_DIR="$JBOSS_BASE_DIR/log"
> fi
> {code}
> However, this is not actually used to set the value of Java property jboss.server.log.dir.
> {code}
> -Djboss.home.dir="$JBOSS_HOME"
> -Djboss.server.base.dir="$JBOSS_BASE_DIR"
> "$SERVER_OPTS"
> {code}
> (It should be set at the same place)
> This leads Jboss/Wildfly/EAP to assume the default value of $JBOSS_BASE_DIR/log.
> This is a problem for those who want to override the location of the server.log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (WFLY-2643) JBOSS_LOG_DIR is checked but not used to set jboss.server.log.dir
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/WFLY-2643?page=com.atlassian.jira.plugin.... ]
James Perkins updated WFLY-2643:
--------------------------------
Priority: Optional (was: Major)
> JBOSS_LOG_DIR is checked but not used to set jboss.server.log.dir
> -----------------------------------------------------------------
>
> Key: WFLY-2643
> URL: https://issues.jboss.org/browse/WFLY-2643
> Project: WildFly
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: Logging, Server
> Affects Versions: JBoss AS7 7.1.1.Final, 8.0.0.Beta1
> Environment: All
> Reporter: Stian Lund
> Priority: Optional
> Labels: jbossas, logging, wildfly
>
> In standalone/domain start scripts (standalone.sh/bat) the value of environment variable JBOSS_LOG_DIR is checked for:
> {code}
> # determine the default log dir, if not set
> if [ "x$JBOSS_LOG_DIR" = "x" ]; then
> JBOSS_LOG_DIR="$JBOSS_BASE_DIR/log"
> fi
> {code}
> However, this is not actually used to set the value of Java property jboss.server.log.dir.
> {code}
> -Djboss.home.dir="$JBOSS_HOME"
> -Djboss.server.base.dir="$JBOSS_BASE_DIR"
> "$SERVER_OPTS"
> {code}
> (It should be set at the same place)
> This leads Jboss/Wildfly/EAP to assume the default value of $JBOSS_BASE_DIR/log.
> This is a problem for those who want to override the location of the server.log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (WFLY-2643) JBOSS_LOG_DIR is checked but not used to set jboss.server.log.dir
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/WFLY-2643?page=com.atlassian.jira.plugin.... ]
James Perkins commented on WFLY-2643:
-------------------------------------
Fair enough. I'll reopen it and feel free to submit a PR for it :)
> JBOSS_LOG_DIR is checked but not used to set jboss.server.log.dir
> -----------------------------------------------------------------
>
> Key: WFLY-2643
> URL: https://issues.jboss.org/browse/WFLY-2643
> Project: WildFly
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Logging, Server
> Affects Versions: JBoss AS7 7.1.1.Final, 8.0.0.Beta1
> Environment: All
> Reporter: Stian Lund
> Assignee: James Perkins
> Labels: jbossas, logging, wildfly
>
> In standalone/domain start scripts (standalone.sh/bat) the value of environment variable JBOSS_LOG_DIR is checked for:
> {code}
> # determine the default log dir, if not set
> if [ "x$JBOSS_LOG_DIR" = "x" ]; then
> JBOSS_LOG_DIR="$JBOSS_BASE_DIR/log"
> fi
> {code}
> However, this is not actually used to set the value of Java property jboss.server.log.dir.
> {code}
> -Djboss.home.dir="$JBOSS_HOME"
> -Djboss.server.base.dir="$JBOSS_BASE_DIR"
> "$SERVER_OPTS"
> {code}
> (It should be set at the same place)
> This leads Jboss/Wildfly/EAP to assume the default value of $JBOSS_BASE_DIR/log.
> This is a problem for those who want to override the location of the server.log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (WFLY-2643) JBOSS_LOG_DIR is checked but not used to set jboss.server.log.dir
by Stian Lund (JIRA)
[ https://issues.jboss.org/browse/WFLY-2643?page=com.atlassian.jira.plugin.... ]
Stian Lund commented on WFLY-2643:
----------------------------------
Fair enough, thanks for the clarification James, it's appreciated :)
However, wouldn't you agree adding just
-Djboss.server.log.dir="$JBOSS_LOG_DIR"
to standalone.sh would be a pretty quick solution for most?
I am not going to push it any further, just noting that the same issue existed with JBOSS_BASE_DIR at 7.1 and was fixed in 7.1.2 in the case below :)
https://issues.jboss.org/browse/AS7-3800
> JBOSS_LOG_DIR is checked but not used to set jboss.server.log.dir
> -----------------------------------------------------------------
>
> Key: WFLY-2643
> URL: https://issues.jboss.org/browse/WFLY-2643
> Project: WildFly
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Logging, Server
> Affects Versions: JBoss AS7 7.1.1.Final, 8.0.0.Beta1
> Environment: All
> Reporter: Stian Lund
> Assignee: James Perkins
> Labels: jbossas, logging, wildfly
>
> In standalone/domain start scripts (standalone.sh/bat) the value of environment variable JBOSS_LOG_DIR is checked for:
> {code}
> # determine the default log dir, if not set
> if [ "x$JBOSS_LOG_DIR" = "x" ]; then
> JBOSS_LOG_DIR="$JBOSS_BASE_DIR/log"
> fi
> {code}
> However, this is not actually used to set the value of Java property jboss.server.log.dir.
> {code}
> -Djboss.home.dir="$JBOSS_HOME"
> -Djboss.server.base.dir="$JBOSS_BASE_DIR"
> "$SERVER_OPTS"
> {code}
> (It should be set at the same place)
> This leads Jboss/Wildfly/EAP to assume the default value of $JBOSS_BASE_DIR/log.
> This is a problem for those who want to override the location of the server.log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (WFLY-2648) Review/move the per-logging deployment tests
by James Perkins (JIRA)
James Perkins created WFLY-2648:
-----------------------------------
Summary: Review/move the per-logging deployment tests
Key: WFLY-2648
URL: https://issues.jboss.org/browse/WFLY-2648
Project: WildFly
Issue Type: Task
Security Level: Public (Everyone can see)
Components: Test Suite
Reporter: James Perkins
Assignee: James Perkins
Priority: Minor
The {{org.jboss.as.logging.per-deployment}} property has been deprecated. There are two tests {{LoggingPerDeployFalseTestCase}} and {{LoggingPreferencesPerDeployFalseTestCase}} that use this property. They need to be copied and/or moved to the manualmode tests and modified to use the new attribute.
Also these tests appear not to work correctly. Breaking the system property during the patch, the tests still seemed to pass. They need to be reviewed and tested when working on this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (WFLY-2643) JBOSS_LOG_DIR is checked but not used to set jboss.server.log.dir
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/WFLY-2643?page=com.atlassian.jira.plugin.... ]
James Perkins commented on WFLY-2643:
-------------------------------------
I'm positive :). The reason the shell variable is checked is because a valid log directory is needed to define the property for the server.log. Look at the property {{-Dorg.jboss.boot.log.file=$JBOSS_LOG_DIR/server.log}}. That is used at boot time in the {{logging.properties}} (at first boot at this point) to determine the file to use for the log handler.
Adding the system property is the correct way just as it would be for the {{jboss.server.data.dir}} or {{jboss.server.tmp.dir}} directories. You could add {{-Djboss.server.log.dir=$LOG_DIR}} to the {{standalone.conf}}.
> JBOSS_LOG_DIR is checked but not used to set jboss.server.log.dir
> -----------------------------------------------------------------
>
> Key: WFLY-2643
> URL: https://issues.jboss.org/browse/WFLY-2643
> Project: WildFly
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Logging, Server
> Affects Versions: JBoss AS7 7.1.1.Final, 8.0.0.Beta1
> Environment: All
> Reporter: Stian Lund
> Assignee: James Perkins
> Labels: jbossas, logging, wildfly
>
> In standalone/domain start scripts (standalone.sh/bat) the value of environment variable JBOSS_LOG_DIR is checked for:
> {code}
> # determine the default log dir, if not set
> if [ "x$JBOSS_LOG_DIR" = "x" ]; then
> JBOSS_LOG_DIR="$JBOSS_BASE_DIR/log"
> fi
> {code}
> However, this is not actually used to set the value of Java property jboss.server.log.dir.
> {code}
> -Djboss.home.dir="$JBOSS_HOME"
> -Djboss.server.base.dir="$JBOSS_BASE_DIR"
> "$SERVER_OPTS"
> {code}
> (It should be set at the same place)
> This leads Jboss/Wildfly/EAP to assume the default value of $JBOSS_BASE_DIR/log.
> This is a problem for those who want to override the location of the server.log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months