[JBoss JIRA] (JASSIST-196) Dont use ==, instead use .equals() for strings
by Shigeru Chiba (JIRA)
[ https://issues.jboss.org/browse/JASSIST-196?page=com.atlassian.jira.plugi... ]
Shigeru Chiba resolved JASSIST-196.
-----------------------------------
Fix Version/s: 3.17.1-GA
Resolution: Rejected
The use of == is not a bug but specification.
Please see the javadoc of that method javassist.compiler.AccessorMaker#getMethodAccessor.
> Dont use ==, instead use .equals() for strings
> ----------------------------------------------
>
> Key: JASSIST-196
> URL: https://issues.jboss.org/browse/JASSIST-196
> Project: Javassist
> Issue Type: Quality Risk
> Affects Versions: 3.17.1-GA
> Reporter: oliver z
> Assignee: Shigeru Chiba
> Fix For: 3.17.1-GA
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> I just used a code quality tool to scan my application which uses javassist.
> It is complaining about a few "==" instead of .equals().
> Occurance at least in: AccessorMaker.java:127
> Would be nice if this could be fixed because as its a very little change.
> Thanks!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (WFLY-962) Unable to combine Resource Archive (RAR) <dependencies> and <exclusions> directives in jboss-deployment-structure.xml without <exclusions> being ignored
by Stuart Douglas (JIRA)
[ https://issues.jboss.org/browse/WFLY-962?page=com.atlassian.jira.plugin.s... ]
Stuart Douglas reassigned WFLY-962:
-----------------------------------
Assignee: Stuart Douglas (was: David Lloyd)
> Unable to combine Resource Archive (RAR) <dependencies> and <exclusions> directives in jboss-deployment-structure.xml without <exclusions> being ignored
> --------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: WFLY-962
> URL: https://issues.jboss.org/browse/WFLY-962
> Project: WildFly
> Issue Type: Bug
> Components: Class Loading
> Environment: Linux (CentOS 6.3), JDK 1.6.0_37
> Reporter: Matthew White
> Assignee: Stuart Douglas
> Attachments: jbossas-bugexample.zip
>
>
> I have an EAR file where for a WAR sub-deployment I want to declare a startup dependency on another Resource Archive (RAR) deployment (in my application's case, the WebSphere MQ RAR - but I have recreated this with other Resource Archives) and also have a module exclusion (in this case, on the org.apache.log4j module so that my application can use internally defined Log4J configuration).
> The jboss-deployment-structure.xml for the EAR looks like this :-
> {code:xml}
> <jboss-deployment-structure>
> <sub-deployment name="application.war">
> <dependencies>
> <module name="deployment.wmq.jmsra.rar" />
> </dependencies>
> <exclusions>
> <module name="org.apache.log4j" />
> </exclusions>
> </sub-deployment>
> </jboss-deployment-structure>
> {code}
> When I startup the EAR, the <dependencies> directive for the sub-deployment takes effect - the WAR is not started until the WebSphere MQ RAR is available. However, my <exclusions> directive is ignored and the application Log4J configuration is not used.
> If I restructure the jboss-deployment-structure.xml and remove the <dependencies> directive from the sub-deployment :-
> {code:xml}
> <jboss-deployment-structure>
> <sub-deployment name="application.war">
> <exclusions>
> <module name="org.apache.log4j" />
> </exclusions>
> </sub-deployment>
> </jboss-deployment-structure>
> {code}
> The <exclusions> directive is interpreted correctly and the application Log4J configuration is used.
> Also, if I go the other way and remove the <exclusions> directive and put the the <dependencies> directive back :-
> {code:xml}
> <jboss-deployment-structure>
> <sub-deployment name="application.war">
> <dependencies>
> <module name="deployment.wmq.jmsra.rar" />
> </dependencies>
> </sub-deployment>
> </jboss-deployment-structure>
> {code}
> The <dependencies> continues to be interpreted correctly and the WAR does not start until the dependency is available.
> It would just seem that I can't combine the two directives and have them both be interpreted correctly. I have tried changing the order of defining them in the file but that (unsurprisingly) didn't make a lot of difference.
> I have also tried this with the dependency being any other type of deployment - EAR, WAR, JAR, etc - and in those cases everything works correctly. It seems to only be an issue if the dependency is a Resource Archive.
> I've also given it a go on a recent 7.2.0 Nightly (3 Jan 2013) and it is also exhibiting the same behaviour.
> I have attached a sample application to replicate this behaviour. It uses the Apache Jackrabbit RAR (since the WebSphere MQ one is not distributable) as the Resource Archive dependency and creates 2 EAR files that are trying to use log4j to log to a file - one with just the <exclusions> directive and one with both the <dependencies> and <exclusions> directives. See the README file in the zip for more details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (WFLY-254) tomcatAuthentication attribute on the AJP connector
by Matthias W (JIRA)
[ https://issues.jboss.org/browse/WFLY-254?page=com.atlassian.jira.plugin.s... ]
Matthias W commented on WFLY-254:
---------------------------------
Is it possible to add the parameter requiredSecret via System-Properties?
ie. org.apache.coyote.ajp.AprProcessor.REQUIREDSECRET
Thanks
> tomcatAuthentication attribute on the AJP connector
> ---------------------------------------------------
>
> Key: WFLY-254
> URL: https://issues.jboss.org/browse/WFLY-254
> Project: WildFly
> Issue Type: Feature Request
> Components: Web (JBoss Web)
> Environment: Windows Server 2003 32 bit, IIS 6, tomcat connector 1.2.28 used as an extension
> Reporter: Brett Prucha
> Assignee: Jean-Frederic Clere
> Priority: Minor
> Fix For: 8.0.0.Alpha1
>
>
> In JBoss 5.1.0 I could set the tomcatAuthentication attribute of the AJP connector to false to allow IIS to handle the authentication and pass that along to JBoss. I'm wanting to upgrade to JBoss 7 but unable to set this attribute in version 7.0.0 final to make this work. This attribute is descibed in the tomcat documentation at http://tomcat.apache.org/tomcat-7.0-doc/config/ajp.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (JASSIST-196) Dont use ==, instead use .equals() for strings
by oliver z (JIRA)
oliver z created JASSIST-196:
--------------------------------
Summary: Dont use ==, instead use .equals() for strings
Key: JASSIST-196
URL: https://issues.jboss.org/browse/JASSIST-196
Project: Javassist
Issue Type: Quality Risk
Affects Versions: 3.17.1-GA
Reporter: oliver z
Assignee: Shigeru Chiba
I just used a code quality tool to scan my application which uses javassist.
It is complaining about a few "==" instead of .equals().
Occurance at least in: AccessorMaker.java:127
Would be nice if this could be fixed because as its a very little change.
Thanks!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (WFLY-1293) Update License Header for KDCServerAnnotationProcessor
by Darran Lofthouse (JIRA)
Darran Lofthouse created WFLY-1293:
--------------------------------------
Summary: Update License Header for KDCServerAnnotationProcessor
Key: WFLY-1293
URL: https://issues.jboss.org/browse/WFLY-1293
Project: WildFly
Issue Type: Task
Components: Test Suite
Reporter: Darran Lofthouse
Assignee: Darran Lofthouse
Fix For: 8.0.0.Alpha1
The purpose of KDCServerAnnotationProcessor is to work around an initialisation problem using Apache Directory Server - however the class is actually based on an implementation in the Apache Directory Server project so the license needs updating to reflect this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months