[JBoss JIRA] (WFLY-3943) There is no testing of the messaging subsystem integration with the JGroups subsystem
by Brian Stansberry (JIRA)
Brian Stansberry created WFLY-3943:
--------------------------------------
Summary: There is no testing of the messaging subsystem integration with the JGroups subsystem
Key: WFLY-3943
URL: https://issues.jboss.org/browse/WFLY-3943
Project: WildFly
Issue Type: Task
Components: JMS
Affects Versions: 9.0.0.Alpha1
Reporter: Brian Stansberry
Assignee: Jeff Mesnil
Priority: Critical
HornetQServerAdd and HornetQServerService have integration with the JGroups subsystem in order to add a dependency on a ChannelFactory for use with broadcast and discovery groups. But it seems there is no testing of this integration.
Looks like it's currently broken. That problem is likely a clustering bug, as there was a recent major change in this area, and this works in the 6.x branch.
This JIRA is about the fact lack of testing that would have caught the bug. Also, https://github.com/wildfly/wildfly/pull/6725 passed the testsuite with a code change that was binary incompatible with the version of HQ that was integrated at the time.
I'll file a separate issue for the problem I'm referring to. To reproduce it change the bg-group1 element in standalone-full-ha.xml to replace the socket-binding element with the following:
{code}
<jgroups-stack>udp</jgroups-stack>
<jgroups-channel>hq-bg</jgroups-channel>
<!--<socket-binding>messaging-group</socket-binding>-->
{code}
At boot this appears in the logs:
{code}
10:00:58,707 ERROR [org.jboss.as.controller.management-operation] (Controller Boot Thread) WFLYCTL0013: Operation ("add") failed - address: ([
("subsystem" => "messaging"),
("hornetq-server" => "default")
]) - failure description: {"WFLYCTL0180: Services with missing/unavailable dependencies" => ["jboss.messaging.default is missing [jboss.jgroups.stack.udp]"]}
10:00:58,930 INFO [org.jboss.as.controller] (Controller Boot Thread) WFLYCTL0183: Service status report
WFLYCTL0184: New missing/unsatisfied dependencies:
service jboss.jgroups.stack.udp (missing) dependents: [service jboss.messaging.default]
{code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 9 months
[JBoss JIRA] (WFLY-3262) WebServiceRef injection without explicit wsdl file fails during Servlet initialization
by Alessio Soldano (JIRA)
[ https://issues.jboss.org/browse/WFLY-3262?page=com.atlassian.jira.plugin.... ]
Alessio Soldano updated WFLY-3262:
----------------------------------
Fix Version/s: 9.0.0.CR1
> WebServiceRef injection without explicit wsdl file fails during Servlet initialization
> --------------------------------------------------------------------------------------
>
> Key: WFLY-3262
> URL: https://issues.jboss.org/browse/WFLY-3262
> Project: WildFly
> Issue Type: Bug
> Components: Web Services
> Affects Versions: 8.1.0.CR1
> Reporter: Matus Abaffy
> Assignee: Alessio Soldano
> Fix For: 9.0.0.CR1
>
>
> Reproducer test available at https://github.com/bafco/wildfly/commits/wsServletInjection
> I have the following servlet
> {code}
> @WebServlet(/*..., */ loadOnStartup = 1)
> public class ServletLoadOnStartup extends HttpServlet {
> @WebServiceRef(value = EndpointService.class)
> private EndpointInterface endpoint1;
> //...
> {code}
> (It is located in the package org.jboss.as.test.integration.ws.serviceref. There you can find more info about the other classes.)
> And i get the following exception:
> {code}
> org.jboss.arquillian.container.spi.client.container.DeploymentException: Cannot deploy: ws-servlet-test.war
> ...
> Caused by: java.lang.Exception: {"JBAS014671: Failed services" => {"jboss.undertow.deployment.default-server.default-host./ws-servlet-test" => "org.jboss.msc.service.StartException in service jboss.undertow.deployment.default-server.default-host./ws-servlet-test: javax.servlet.ServletException: UT010013: Could not instantiate ServletLoadOnStartup
> Caused by: javax.servlet.ServletException: UT010013: Could not instantiate ServletLoadOnStartup
> Caused by: java.lang.IllegalStateException: JBAS011048: Failed to construct component instance
> Caused by: java.lang.RuntimeException: JBAS011875: Resource lookup for injection failed: env/org.jboss.as.test.integration.ws.serviceref.ServletLoadOnStartup/endpoint1
> Caused by: javax.naming.NamingException: JBAS011878: Failed to lookup env/org.jboss.as.test.integration.ws.serviceref.ServletLoadOnStartup/endpoint1 [Root exception is org.jboss.wsf.spi.WSFException: Cannot create service]
> Caused by: org.jboss.wsf.spi.WSFException: Cannot create service
> Caused by: java.lang.reflect.InvocationTargetException
> Caused by: javax.xml.ws.WebServiceException: org.apache.cxf.service.factory.ServiceConstructionException: Failed to create service.
> Caused by: org.apache.cxf.service.factory.ServiceConstructionException: Failed to create service.
> Caused by: javax.wsdl.WSDLException: WSDLException: faultCode=PARSER_ERROR: Problem parsing 'http://localhost:8080/ws-servlet-test/EndpointService/EJB3Bean?wsdl'.: java.io.FileNotFoundException: http://localhost:8080/ws-servlet-test/EndpointService/EJB3Bean?wsdl
> Caused by: java.io.FileNotFoundException: http://localhost:8080/ws-servlet-test/EndpointService/EJB3Bean?wsdl"}}
> {code}
> If I change loadOnStartup parameter to -1, everything works fine, i.e. servlet gets instantiated and WS is injected correctly. Therefore, I suppose this is a bug.
> Another workaround exists - adding wsdl file to the deployment archive and using the 'wsdlLocation' parameter in @WebServiceRef (as can be seen in ServiceRefSevletTestCase).
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 9 months
[JBoss JIRA] (WFLY-3940) Parsers should print expected elements in case of error
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/WFLY-3940?page=com.atlassian.jira.plugin.... ]
Tomaz Cerar commented on WFLY-3940:
-----------------------------------
What archetype are you referring to? https://github.com/wildfly/wildfly-archetypes uses just that.
Yeah PersistentResourceDefinition is what i had in mind to be improved to better inform of parse errors.
we could probably also add some sample xml generation based on the definition of the parser. that shouldn't be that hard.
For time being what you can do is, start the subsystem with empty configuration and go to CLI and execute add commands for subsystem resource tree and as result you will get persistent xml you are interested in. not optimal solution but a workaround for time being.
> Parsers should print expected elements in case of error
> -------------------------------------------------------
>
> Key: WFLY-3940
> URL: https://issues.jboss.org/browse/WFLY-3940
> Project: WildFly
> Issue Type: Feature Request
> Components: Domain Management
> Reporter: Heiko Rupp
> Assignee: Tomaz Cerar
>
> While developing an extension I get "JBAS014789: Unexpected element "bla" encountered"
> At this point it would be sooooooo helpful if #WildFly would tell me what it did expect here to help me modifying my code.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 9 months
[JBoss JIRA] (WFLY-3940) Parsers should print expected elements in case of error
by Heiko Rupp (JIRA)
[ https://issues.jboss.org/browse/WFLY-3940?page=com.atlassian.jira.plugin.... ]
Heiko Rupp commented on WFLY-3940:
----------------------------------
I am using the classes that you mention. The provided archetype doesn't.
How am I supposed to test that a subsystem.xml is correct(ly parsed) when the tools do not tell me what it is supposed to look like according to the PersistentResourceDefinition ?
For you as a hardcore extension writer, this is pretty easy. For everyone else less so.
> Parsers should print expected elements in case of error
> -------------------------------------------------------
>
> Key: WFLY-3940
> URL: https://issues.jboss.org/browse/WFLY-3940
> Project: WildFly
> Issue Type: Feature Request
> Components: Domain Management
> Reporter: Heiko Rupp
> Assignee: Tomaz Cerar
>
> While developing an extension I get "JBAS014789: Unexpected element "bla" encountered"
> At this point it would be sooooooo helpful if #WildFly would tell me what it did expect here to help me modifying my code.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 9 months
[JBoss JIRA] (WFLY-3940) Parsers should print expected elements in case of error
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/WFLY-3940?page=com.atlassian.jira.plugin.... ]
Tomaz Cerar commented on WFLY-3940:
-----------------------------------
Why don't go with PersistentResourceDefinition & PersistentResourceXMLDescription for defining your parser?
It was done just so we can minimize problems like this. See IO, Mail and undertow subsystems for examples on how to use it.
If you are doing parser by hand then only way to report problems is by adding code to do reporting to your parser.
> Parsers should print expected elements in case of error
> -------------------------------------------------------
>
> Key: WFLY-3940
> URL: https://issues.jboss.org/browse/WFLY-3940
> Project: WildFly
> Issue Type: Feature Request
> Components: Domain Management
> Reporter: Heiko Rupp
> Assignee: Tomaz Cerar
>
> While developing an extension I get "JBAS014789: Unexpected element "bla" encountered"
> At this point it would be sooooooo helpful if #WildFly would tell me what it did expect here to help me modifying my code.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 9 months
[JBoss JIRA] (WFBUILD-10) Allow artifact versions to be overridden on the command line
by David Lloyd (JIRA)
[ https://issues.jboss.org/browse/WFBUILD-10?page=com.atlassian.jira.plugin... ]
David Lloyd commented on WFBUILD-10:
------------------------------------
One thing worth noting which I forgot to put before - at present, if you give the system property, it would override some cases but not others. So it's sort of weird and broken, rather than simply not working.
> Allow artifact versions to be overridden on the command line
> ------------------------------------------------------------
>
> Key: WFBUILD-10
> URL: https://issues.jboss.org/browse/WFBUILD-10
> Project: WildFly Build Tools
> Issue Type: Feature Request
> Reporter: David Lloyd
> Assignee: Stuart Douglas
> Fix For: 1.0.0.Alpha5
>
>
> For CI environments. Re-enable the lost ability to specify the version of a dependency or transitive dependency on the command line. Right now only immediate dependencies can be overridden due to the standard maven mechanism. Transitive dependency properties are presently ignored.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 9 months
[JBoss JIRA] (WFLY-3941) Provide a translator .xsd->parser+object model
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/WFLY-3941?page=com.atlassian.jira.plugin.... ]
Tomaz Cerar closed WFLY-3941.
-----------------------------
Resolution: Rejected
You are thinking too much in forms of XML.
XML is just current default persistent state of the model.
There are initiatives to support different formats like json for our persistent model. Based on that XSD --> model definition tooling would be just redundant extra work.
You can still make it as standalone tool and we can add it to Wildfly Extras https://github.com/wildfly-extras but I don't see any good reason to have this in main code base or a definitive go-to tool for writing subsystems.
> Provide a translator .xsd->parser+object model
> ----------------------------------------------
>
> Key: WFLY-3941
> URL: https://issues.jboss.org/browse/WFLY-3941
> Project: WildFly
> Issue Type: Feature Request
> Components: Domain Management
> Reporter: Heiko Rupp
> Assignee: Brian Stansberry
> Priority: Minor
>
> When writing a new subsystem, it would be good to have tooling that takes a .xsd for the <subsystem> element and translates its content in a rough first form of parser + matching object model (*Definition, *Add and so on).
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 9 months
[JBoss JIRA] (WFLY-3940) Parsers should print expected elements in case of error
by Heiko Rupp (JIRA)
[ https://issues.jboss.org/browse/WFLY-3940?page=com.atlassian.jira.plugin.... ]
Heiko Rupp commented on WFLY-3940:
----------------------------------
I am writing a *new subsystem/extension* and need to get the SubsystemParser + Object model right. I have some code but apparently the object hierarchy is not what the parser expects (or the other way around).
> Parsers should print expected elements in case of error
> -------------------------------------------------------
>
> Key: WFLY-3940
> URL: https://issues.jboss.org/browse/WFLY-3940
> Project: WildFly
> Issue Type: Feature Request
> Components: Domain Management
> Reporter: Heiko Rupp
> Assignee: Tomaz Cerar
>
> While developing an extension I get "JBAS014789: Unexpected element "bla" encountered"
> At this point it would be sooooooo helpful if #WildFly would tell me what it did expect here to help me modifying my code.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 9 months