[JBoss JIRA] (WFLY-3723) setting the local to english in CLI commands on non-english systems does not produce english output
by Romain Pelisse (JIRA)
[ https://issues.jboss.org/browse/WFLY-3723?page=com.atlassian.jira.plugin.... ]
Romain Pelisse commented on WFLY-3723:
--------------------------------------
Ok, switching to ROOT has not fix the issue, because when we request for the locale "en_US" we still end up in the same pitfall - there is no bundle for it. I have a fix however, that simply test if language is 'en' and if so, switch to "ROOT".
> setting the local to english in CLI commands on non-english systems does not produce english output
> ---------------------------------------------------------------------------------------------------
>
> Key: WFLY-3723
> URL: https://issues.jboss.org/browse/WFLY-3723
> Project: WildFly
> Issue Type: Bug
> Components: Localization
> Affects Versions: 8.1.0.Final
> Environment: Tested on MacOS running in German
> Reporter: Tom Fonteyne
> Assignee: Romain Pelisse
> Priority: Minor
>
> A German (or french etc...) system must be used to reproduce.
> It is likely this is not limited to MacOS, but I do not have a non-english Linux system available
> An out of the box install of wildfly/EAP:
> Without configuration, the log file is in German as expected.
> Using these CLI comands:
> :read-operation-description(name=stop-servers,locale=de_DE) -> german
> :read-operation-description(name=stop-servers,locale=en_US) -> german
> :read-operation-description(name=stop-servers,locale=fr_FR) -> french
> So we cannot get the CLI to produce english output
> when configuring JAVA_OPTS in domain.conf with:
> JAVA_OPTS="$JAVA_OPTS -Duser.language=en -Duser.country=DE -Duser.encoding=utf-8
> The log is now in English -> works as expected; and:
> :read-operation-description(name=stop-servers,locale=de_DE) -> german
> :read-operation-description(name=stop-servers,locale=en_US) -> english
> So it seems we have a bug where the locale set to start the domain takes precedence over the locale set in the CLI command (but only when English is asked)
> I presume this is because English is the default locale.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 3 months
[JBoss JIRA] (JBASMP-59) Shutdown CLI handler fails due to different ModelControllerClient being used
by Cristian Milasan (JIRA)
[ https://issues.jboss.org/browse/JBASMP-59?page=com.atlassian.jira.plugin.... ]
Cristian Milasan commented on JBASMP-59:
----------------------------------------
Hi James,
I need to point this again:
Executing CLI command WORKS: jboss-cli.bat --connect controller=localhost:9999 command="shutdown --host=myhost --restart=true" WORKS
Executing command from maven plugin with the execute-commands goat DO NOT WORK:
{noformat}
<plugin>
<groupId>org.jboss.as.plugins</groupId>
<artifactId>jboss-as-maven-plugin</artifactId>
<version>7.6.Final</version>
<executions>
<execution>
<phase>validate</phase>
<goals>
<goal>execute-commands</goal>
</goals>
</execution>
</executions>
<configuration>
<hostname>127.0.0.1</hostname>
<username>admin</username>
<password>admin</password>
<executeCommands>
<commands>
<command>shutdown --host=myhost</command>
</commands>
</executeCommands>
</configuration>
</plugin>
{noformat}
Stack trace:
{noformat}
[ERROR] Failed to execute goal org.jboss.as.plugins:jboss-as-maven-plugin:7.6.Final:execute-commands (default) on project cre-ear: Execution default of goal org.jboss.as.plugins:jboss-as-maven-plugin:7.6.Final:execute-commands failed: Command execution failed for command 'shutdown --host=myhost'. Unsupported ModelControllerClient implementation org.jboss.as.plugin.cli.Commands$NonClosingModelControllerClient -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.jboss.as.plugins:jboss-as-maven-plugin:7.6.Final:execute-commands (default) on project cre-ear: Execution default of goal org.jboss.as.plugins:jboss-as-maven-plugin:7.6.Final:execute-commands failed: Command execution failed for command 'shutdown --host=myhost'. Unsupported ModelControllerClient implementation org.jboss.as.plugin.cli.Commands$NonClosingModelControllerClient
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:225)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default of goal org.jboss.as.plugins:jboss-as-maven-plugin:7.6.Final:execute-commands failed: Command execution failed for command 'shutdown --host=myhost'. Unsupported ModelControllerClient implementation org.jboss.as.plugin.cli.Commands$NonClosingModelControllerClient
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:110)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
... 19 more
Caused by: java.lang.IllegalArgumentException: Command execution failed for command 'shutdown --host=myhost'. Unsupported ModelControllerClient implementation org.jboss.as.plugin.cli.Commands$NonClosingModelControllerClient
at org.jboss.as.plugin.cli.Commands.executeCommands(Commands.java:180)
at org.jboss.as.plugin.cli.Commands.execute(Commands.java:134)
at org.jboss.as.plugin.cli.ExecuteCommands.execute(ExecuteCommands.java:71)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
... 20 more
Caused by: org.jboss.as.cli.CommandLineException: Unsupported ModelControllerClient implementation org.jboss.as.plugin.cli.Commands$NonClosingModelControllerClient
at org.jboss.as.cli.handlers.ShutdownHandler.doHandle(ShutdownHandler.java:97)
at org.jboss.as.cli.handlers.CommandHandlerWithHelp.handle(CommandHandlerWithHelp.java:86)
at org.jboss.as.cli.impl.CommandContextImpl.handle(CommandContextImpl.java:581)
at org.jboss.as.plugin.cli.Commands.executeCommands(Commands.java:176)
... 23 more
[ERROR]
<noformat>
AM I missing something here?
> Shutdown CLI handler fails due to different ModelControllerClient being used
> ----------------------------------------------------------------------------
>
> Key: JBASMP-59
> URL: https://issues.jboss.org/browse/JBASMP-59
> Project: JBoss AS Maven Plugins
> Issue Type: Bug
> Reporter: James Perkins
> Assignee: James Perkins
>
> See https://github.com/wildfly/wildfly/blob/7.2.0.Final-prerelease1/cli/src/m.... Likely just need the {{NonClosingModelControllerClient}} to extend the {{CLIModelControllerClient}}.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 3 months
[JBoss JIRA] (WFLY-4229) Make http status return whily deploying configurable
by Tomaz Cerar (JIRA)
Tomaz Cerar created WFLY-4229:
---------------------------------
Summary: Make http status return whily deploying configurable
Key: WFLY-4229
URL: https://issues.jboss.org/browse/WFLY-4229
Project: WildFly
Issue Type: Feature Request
Components: Web (Undertow)
Affects Versions: 8.2.0.Final
Reporter: Tomaz Cerar
Assignee: Stuart Douglas
For deployment behind proxies it would be more than welcome to have server return 503 instead of 404 while application is deploying.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 3 months
[JBoss JIRA] (WFLY-4228) Fallback locale should be ROOT, and not Locale.getDefault()
by Romain Pelisse (JIRA)
[ https://issues.jboss.org/browse/WFLY-4228?page=com.atlassian.jira.plugin.... ]
Romain Pelisse commented on WFLY-4228:
--------------------------------------
This issue was reported while investigating WFLY-3723, as it appeared as potential fix for it.
> Fallback locale should be ROOT, and not Locale.getDefault()
> -----------------------------------------------------------
>
> Key: WFLY-4228
> URL: https://issues.jboss.org/browse/WFLY-4228
> Project: WildFly
> Issue Type: Enhancement
> Components: CLI, ConfigAdmin
> Affects Versions: 9.0.0.Alpha1
> Environment: Any system with default locale set to something diffirent from english
> Reporter: Romain Pelisse
> Assignee: Romain Pelisse
> Priority: Minor
>
> While investigating WFLY-3723, I found out that when a bundle for a specified locale can not be found, Wildfly code fallbacks to Locale.getDefault, rather than use the Locale.ROOT. This is a side effect on non-english system, because there is no bundle for "en_US", and root should be used in this case.
> I proposed to fix it by replacing all relevant occurences of Locale.getDefault() by Locale.ROOT.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 3 months
[JBoss JIRA] (WFLY-4228) Fallback locale should be ROOT, and not Locale.getDefault()
by Romain Pelisse (JIRA)
Romain Pelisse created WFLY-4228:
------------------------------------
Summary: Fallback locale should be ROOT, and not Locale.getDefault()
Key: WFLY-4228
URL: https://issues.jboss.org/browse/WFLY-4228
Project: WildFly
Issue Type: Enhancement
Components: CLI, ConfigAdmin
Affects Versions: 9.0.0.Alpha1
Environment: Any system with default locale set to something diffirent from english
Reporter: Romain Pelisse
Assignee: Romain Pelisse
Priority: Minor
While investigating WFLY-3723, I found out that when a bundle for a specified locale can not be found, Wildfly code fallbacks to Locale.getDefault, rather than use the Locale.ROOT. This is a side effect on non-english system, because there is no bundle for "en_US", and root should be used in this case.
I proposed to fix it by replacing all relevant occurences of Locale.getDefault() by Locale.ROOT.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 3 months