[JBoss JIRA] (WFCORE-1199) CLI Lists in non-interactive mode are erroneously split into multiple commands
by Ryan Emerson (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1199?page=com.atlassian.jira.plugi... ]
Ryan Emerson commented on WFCORE-1199:
--------------------------------------
My proposed solution requires that lists containing > 1 value must be contained within [] brackets. This prevents the list from being perceived as multiple commands and allows the list to be passed to the appropriate handler where the [] brackets can be removed and the list processed as expected.
So for example the valid command to add a module would become:
./bin/jboss-cli.sh -c --controller=localhost --commands="module add --name=test --resources=test.jar --dependencies=[dep1,dep2]
and the resulting module.xml dependencies would be:
<dependencies>
<module name="dep1"/>
<module name="dep2"/>
</dependencies>
> CLI Lists in non-interactive mode are erroneously split into multiple commands
> ------------------------------------------------------------------------------
>
> Key: WFCORE-1199
> URL: https://issues.jboss.org/browse/WFCORE-1199
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI, Modules, Patching
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
>
> The problem arises because commands entered in non-interactive mode are split by the "," character. Therefore, in the case of:
> "./bin/jboss-cli.sh -c --controller=localhost --commands="module add --name=test --resources=test.jar --dependencies=dep1,dep2"
> the cli is incorrectly splitting the request into two distinct commands:
> 1. module add --name=test --resources=test.jar --dependencies=dep1
> 2. dep2
> The reason this behaviour is not observed in interactive mode is because multiple commands can not be specified. However, in non-interactive mode --commands=ls,pwd is valid and should result in the execution of ls followed by pwd.
> This problem is not restricted to the module command, as it affects all commands entered in non-interactive mode that require a comma-separated list as an argument. So far this appears to be PatchHanlder.java, ASModuleHandler.java and DeploymentOverlayHandler.java.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (WFCORE-1199) CLI Lists in non-interactive mode are erroneously split into multiple commands
by Ryan Emerson (JIRA)
Ryan Emerson created WFCORE-1199:
------------------------------------
Summary: CLI Lists in non-interactive mode are erroneously split into multiple commands
Key: WFCORE-1199
URL: https://issues.jboss.org/browse/WFCORE-1199
Project: WildFly Core
Issue Type: Bug
Components: CLI, Modules, Patching
Reporter: Ryan Emerson
Assignee: Ryan Emerson
The problem arises because commands entered in non-interactive mode are split by the "," character. Therefore, in the case of:
"./bin/jboss-cli.sh -c --controller=localhost --commands="module add --name=test --resources=test.jar --dependencies=dep1,dep2"
the cli is incorrectly splitting the request into two distinct commands:
1. module add --name=test --resources=test.jar --dependencies=dep1
2. dep2
The reason this behaviour is not observed in interactive mode is because multiple commands can not be specified. However, in non-interactive mode --commands=ls,pwd is valid and should result in the execution of ls followed by pwd.
This problem is not restricted to the module command, as it affects all commands entered in non-interactive mode that require a comma-separated list as an argument. So far this appears to be PatchHanlder.java, ASModuleHandler.java and DeploymentOverlayHandler.java.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (WFLY-5821) Data source connection-properties is defined as an attribute and a sub-resource
by Stefano Maestri (JIRA)
Stefano Maestri created WFLY-5821:
-------------------------------------
Summary: Data source connection-properties is defined as an attribute and a sub-resource
Key: WFLY-5821
URL: https://issues.jboss.org/browse/WFLY-5821
Project: WildFly
Issue Type: Bug
Components: JCA
Reporter: Stefano Maestri
Assignee: Stefano Maestri
Priority: Critical
The {{subsystem=datasource/data-source=*}} resource has a {{connection-properties}} attribute and a {{connection-properties}} sub-resource. Since DMR is a tree structure each child must have a unique key. Since the parent resource has a {{connection-properties}} attribute and sub-resource with a {{read-resource}} operation you will only get one of the values.
Also writing to the {{connection-properties}} attribute fails to marshal the XML since marshaller expects the value to look something like
{code}
{ "key" => { "value" => "real-value" } }
{code}
But the resource definition expects
{code}
{ "key" => "real-value" }
{code}
The attribute does not appear to be in EAP 6.4. It is however in WildFly 8.x and 9.x. Some further research should be done, but the attribute could likely be removed. Not having the attribute would also be more consistent with XA data sources.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (WFLY-5351) querying TimerService information from CLI fails for canceled timer
by Matthieu Brouillard (JIRA)
[ https://issues.jboss.org/browse/WFLY-5351?page=com.atlassian.jira.plugin.... ]
Matthieu Brouillard updated WFLY-5351:
--------------------------------------
Affects Version/s: 10.0.0.CR4
10.0.0.CR5
> querying TimerService information from CLI fails for canceled timer
> -------------------------------------------------------------------
>
> Key: WFLY-5351
> URL: https://issues.jboss.org/browse/WFLY-5351
> Project: WildFly
> Issue Type: Bug
> Components: EJB
> Affects Versions: 8.2.1.Final, 10.0.0.CR2, 10.0.0.CR4, 10.0.0.CR5
> Environment: probably not relevant but here is my environment
> {{Java Version : 1.8.0_60
> Java Vendor : Oracle Corporation
> OS Hostname : PAMWX125
> OS Architecture : amd64
> OS Name : Windows 7
> }}
> Reporter: Matthieu Brouillard
> Attachments: patch1.diff, timer-cli-failure.zip, WFLY-5351diff
>
>
> When (at least) a persistent calendar timer is created then cancelled, querying TimerService information via CLI (script or library) fails when retrieving also runtime information.
> We discovered the issue because our arquillian tests are failing due to some code in arquillian that fires the equivalent of the provided CLI command below when remotes tests are executed.
> Attached is a proposed patch and a demo project to reproduce in a simple way.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (WFCORE-1198) CLI does not resolve multiple properties if one property is undefined
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1198?page=com.atlassian.jira.plugi... ]
RH Bugzilla Integration updated WFCORE-1198:
--------------------------------------------
Bugzilla References: https://bugzilla.redhat.com/show_bug.cgi?id=1289316
Bugzilla Update: Perform
> CLI does not resolve multiple properties if one property is undefined
> ---------------------------------------------------------------------
>
> Key: WFCORE-1198
> URL: https://issues.jboss.org/browse/WFCORE-1198
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI
> Affects Versions: 2.0.4.Final
> Reporter: Chao Wang
> Assignee: Chao Wang
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1289316 description:
> {noformat}
> Multiple property substitution is working with EAP 6.4.3+, however, if a variable amongst the multiple variables is empty or has no value, then the subsequent property in the CLI command is not substituted.
> For example :
> cat props.properties
> -----------------------------------------
> PROFILE-NAME=TestProfile
> SERVER-INSTANCE-NUMBER=TestInstance
> APP-VERSION=
> VAR=test
> -----------------------------------------
> cat test.cli :
> ---------------------------------------
> /host=master/server-config=${PROFILE-NAME}${APP-VERSION}${SERVER-INSTANCE-NUMBER}${VAR}:add(auto-start=true, group="${PROFILE-NAME}${APP-VERSION}-server-group")
> ---------------------------------------
> and if I execute "./jboss-cli.sh --connect --file=test.cli --properties=props.properties" then I have the following in the host.xml ":
> ----------
> ...
> <server name="TestProfile${SERVER-INSTANCE-NUMBER}test" group="TestProfile-server-group" auto-start="true"/>
> ...
> -----------
> Note APP-VERSION had no value, and so the subsequent SERVER-INSTANCE-NUMBER was not properly resolved
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (WFCORE-1198) CLI does not resolve multiple properties if one property is undefined
by Chao Wang (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1198?page=com.atlassian.jira.plugi... ]
Chao Wang commented on WFCORE-1198:
-----------------------------------
[CLIExpressionResolver.java#L181|https://github.com/wildfly/wildfly-core/b...] only checks null, but if there is an empty property as "APP-VERSION=", variable resolved is "". It continues to write <server name="TestProfile${SERVER-INSTANCE-NUMBER}test" group="TestProfile-server-group" auto-start="true"/> in configuration file without problem before next server reboot. It's an edge case to have empty value in properties file as reported case, however, it'd better to throw an UnresolvedExpressionException with informative message.
> CLI does not resolve multiple properties if one property is undefined
> ---------------------------------------------------------------------
>
> Key: WFCORE-1198
> URL: https://issues.jboss.org/browse/WFCORE-1198
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI
> Affects Versions: 2.0.4.Final
> Reporter: Chao Wang
> Assignee: Chao Wang
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1289316 description:
> {noformat}
> Multiple property substitution is working with EAP 6.4.3+, however, if a variable amongst the multiple variables is empty or has no value, then the subsequent property in the CLI command is not substituted.
> For example :
> cat props.properties
> -----------------------------------------
> PROFILE-NAME=TestProfile
> SERVER-INSTANCE-NUMBER=TestInstance
> APP-VERSION=
> VAR=test
> -----------------------------------------
> cat test.cli :
> ---------------------------------------
> /host=master/server-config=${PROFILE-NAME}${APP-VERSION}${SERVER-INSTANCE-NUMBER}${VAR}:add(auto-start=true, group="${PROFILE-NAME}${APP-VERSION}-server-group")
> ---------------------------------------
> and if I execute "./jboss-cli.sh --connect --file=test.cli --properties=props.properties" then I have the following in the host.xml ":
> ----------
> ...
> <server name="TestProfile${SERVER-INSTANCE-NUMBER}test" group="TestProfile-server-group" auto-start="true"/>
> ...
> -----------
> Note APP-VERSION had no value, and so the subsequent SERVER-INSTANCE-NUMBER was not properly resolved
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (WFLY-5351) querying TimerService information from CLI fails for canceled timer
by Bart Van Dosselaer (JIRA)
[ https://issues.jboss.org/browse/WFLY-5351?page=com.atlassian.jira.plugin.... ]
Bart Van Dosselaer updated WFLY-5351:
-------------------------------------
Attachment: WFLY-5351diff
Still an issue on the current 10.0.0.CR5-SNAPSHOT. As the code changed quite a bit, here's a new patch.
> querying TimerService information from CLI fails for canceled timer
> -------------------------------------------------------------------
>
> Key: WFLY-5351
> URL: https://issues.jboss.org/browse/WFLY-5351
> Project: WildFly
> Issue Type: Bug
> Components: EJB
> Affects Versions: 8.2.1.Final, 10.0.0.CR2
> Environment: probably not relevant but here is my environment
> {{Java Version : 1.8.0_60
> Java Vendor : Oracle Corporation
> OS Hostname : PAMWX125
> OS Architecture : amd64
> OS Name : Windows 7
> }}
> Reporter: Matthieu Brouillard
> Attachments: patch1.diff, timer-cli-failure.zip, WFLY-5351diff
>
>
> When (at least) a persistent calendar timer is created then cancelled, querying TimerService information via CLI (script or library) fails when retrieving also runtime information.
> We discovered the issue because our arquillian tests are failing due to some code in arquillian that fires the equivalent of the provided CLI command below when remotes tests are executed.
> Attached is a proposed patch and a demo project to reproduce in a simple way.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (WFCORE-1198) CLI does not resolve multiple properties if one property is undefined
by Chao Wang (JIRA)
Chao Wang created WFCORE-1198:
---------------------------------
Summary: CLI does not resolve multiple properties if one property is undefined
Key: WFCORE-1198
URL: https://issues.jboss.org/browse/WFCORE-1198
Project: WildFly Core
Issue Type: Bug
Components: CLI
Affects Versions: 2.0.4.Final
Reporter: Chao Wang
Assignee: Chao Wang
https://bugzilla.redhat.com/show_bug.cgi?id=1289316 description:
{noformat}
Multiple property substitution is working with EAP 6.4.3+, however, if a variable amongst the multiple variables is empty or has no value, then the subsequent property in the CLI command is not substituted.
For example :
cat props.properties
-----------------------------------------
PROFILE-NAME=TestProfile
SERVER-INSTANCE-NUMBER=TestInstance
APP-VERSION=
VAR=test
-----------------------------------------
cat test.cli :
---------------------------------------
/host=master/server-config=${PROFILE-NAME}${APP-VERSION}${SERVER-INSTANCE-NUMBER}${VAR}:add(auto-start=true, group="${PROFILE-NAME}${APP-VERSION}-server-group")
---------------------------------------
and if I execute "./jboss-cli.sh --connect --file=test.cli --properties=props.properties" then I have the following in the host.xml ":
----------
...
<server name="TestProfile${SERVER-INSTANCE-NUMBER}test" group="TestProfile-server-group" auto-start="true"/>
...
-----------
Note APP-VERSION had no value, and so the subsequent SERVER-INSTANCE-NUMBER was not properly resolved
{noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (WFLY-5596) MessageDrivenComponent startDelivery/stopDelivery is not thread safe
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/WFLY-5596?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration commented on WFLY-5596:
-----------------------------------------------
baranowb <bbaranow(a)redhat.com> changed the Status of [bug 1282661|https://bugzilla.redhat.com/show_bug.cgi?id=1282661] from NEW to POST
> MessageDrivenComponent startDelivery/stopDelivery is not thread safe
> --------------------------------------------------------------------
>
> Key: WFLY-5596
> URL: https://issues.jboss.org/browse/WFLY-5596
> Project: WildFly
> Issue Type: Bug
> Components: EJB, JMS
> Affects Versions: 10.0.0.CR4
> Reporter: James Livingston
> Assignee: Jeff Mesnil
>
> WFLY-4470 made a change to prevent MDBs being activated or deactivated multiple times, but it is not thread safe. A volatile boolean is used for the flag, but there is no protection against multiple threads invoking the methods simultaneously.
> Possible effects include:
> * activating the endpoint twice, with (probably) only one deactivation later, leading to not de-registering XA resources from the recovery manager properly
> * activate() and deactivate() running in the wrong order if done by separate threads
> Several simple solutions probably will not work correctly. Using an AtomicBoolean would stop multiple activations/deactivations from concurrent calls, but would mean that startDelivery() could return before the activation was one. Using a synchronized block or other exclusive lock would work, however since it involves invoking non-container code (the resource adapter), there could potentially be a deadlock risk if that invoked some related container functionality.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months