[JBoss JIRA] (WFCORE-1483) Recursive removal doesn't deal with reload-required cleanly
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1483?page=com.atlassian.jira.plugi... ]
Brian Stansberry commented on WFCORE-1483:
------------------------------------------
A possibility here is to use the OperationDefinition data associated with the handler for each remove to see if the op will require-reload. That is, the kernel doesn't wait for the remove OSH to call context.reloadRequired() in order to know that reload is required, as that call happens too late. Too late because the Stage.RUNTIME call (i.e. invocation of performRuntime(...)) for the parent resource will happen *after* the Stage.RUNTIME call for the children. What's needed is to have an expectation for the parent and all descendants before *any* of them get to their performRuntime() handling.
Still tricky though. The mechanism to communicate state between the relevant steps (but not to other steps) also doesn't exist.
> Recursive removal doesn't deal with reload-required cleanly
> -----------------------------------------------------------
>
> Key: WFCORE-1483
> URL: https://issues.jboss.org/browse/WFCORE-1483
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Reporter: Brian Stansberry
>
> There's a flaw in the WFCORE-808 recursive removal feature when it comes to reload-required.
> The problem is some of the resources recursively removed can require a reload while others don't, with the result that you get a semi-random set of changes to the runtime. This is particularly an issue if the parent resource requires reload and children don't. So based on the parent resource description the user may be expecting no runtime changes but instead some services are removed.
> This is tricky because when the Stage.RUNTIME steps execute for the child resources, they don't know if their parents are going to require a reload. We can probably use a OperationContext attachment of some sort to communicate information between steps associated with a recursive reload, but even with that kind of thing in place, unless we change how AbstractRemoveStepHandler works (likely breaking subclasses) at the time the child decides whether or not to require reload it's not going to know what the parents will decide.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (WFCORE-1629) Potential NullPointerException when registering the management console redirect service
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1629?page=com.atlassian.jira.plugi... ]
Brian Stansberry reassigned WFCORE-1629:
----------------------------------------
Assignee: George Gastaldi (was: Brian Stansberry)
> Potential NullPointerException when registering the management console redirect service
> ---------------------------------------------------------------------------------------
>
> Key: WFCORE-1629
> URL: https://issues.jboss.org/browse/WFCORE-1629
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 2.0.10.Final
> Reporter: George Gastaldi
> Assignee: George Gastaldi
>
> While creating a WildFly Swarm Fraction that exposes the management console, I debugged ConsoleMode and found out that a NullPointerException is thrown in the {{findConsoleVersions}} methods. That's because the {{module.path}} returns {{null}} (as specified in the default value in this same method).
> A simple null check is enough to fix it.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (WFLY-6794) Upgrade JGroups to 3.6.10.Final
by Paul Ferraro (JIRA)
Paul Ferraro created WFLY-6794:
----------------------------------
Summary: Upgrade JGroups to 3.6.10.Final
Key: WFLY-6794
URL: https://issues.jboss.org/browse/WFLY-6794
Project: WildFly
Issue Type: Component Upgrade
Components: Clustering
Affects Versions: 10.0.0.Final
Reporter: Paul Ferraro
Assignee: Paul Ferraro
Priority: Blocker
Fix For: 10.1.0.Final
Contains important regression fixes.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (WFCORE-351) CLI "revert to snapshot" command
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-351?page=com.atlassian.jira.plugin... ]
Brian Stansberry commented on WFCORE-351:
-----------------------------------------
OK, so that sounds good for the "revert to snapshot" use case, as we want the base file updated. It's not good for a use case where the user is really trying to completely switch the server to another file. But thinking about it more I think that's fine and is just a documentation issue. The purpose of the feature is to bulk update the running config from some other document (either a snapshot or standalone2.xml that they prepared for some reason.) It is not meant to be a complete switch of the server to a different config file. A complete switch requires stopping the server and starting again with new arguments.
IMO the CLI "reload --help" output and the read-operation-description(name=reload) output need to be clearer about this.
> CLI "revert to snapshot" command
> --------------------------------
>
> Key: WFCORE-351
> URL: https://issues.jboss.org/browse/WFCORE-351
> Project: WildFly Core
> Issue Type: Enhancement
> Components: Domain Management
> Environment: all
> Reporter: Rich Sharples
> Assignee: Kabir Khan
> Labels: eap6-ux
> Fix For: 3.0.0.Alpha1
>
>
> The CLI has commands for taking snapshots, listing snapshots, deleting snapshots but no way to rollback or revert to a previous snapshot.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months