[JBoss JIRA] (WFCORE-1855) Possible NPE on controller service start
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1855?page=com.atlassian.jira.plugi... ]
Brian Stansberry commented on WFCORE-1855:
------------------------------------------
https://github.com/bstansberry/wildfly-core/tree/WFCORE-1855 is WIP on this. Kind of a workaround. I opened up a PR for it but I think I'll withdraw it for now as it's a bit out of date and I don't feel urgency to get this particular solution in.
> Possible NPE on controller service start
> ----------------------------------------
>
> Key: WFCORE-1855
> URL: https://issues.jboss.org/browse/WFCORE-1855
> Project: WildFly Core
> Issue Type: Bug
> Reporter: David Lloyd
> Assignee: Brian Stansberry
>
> In {{org.jboss.as.controller.AbstractControllerService}}, the {{start}} method starts up a background thread which performs a certain amount of the boot process. Before this thread is started, a volatile field {{controller}} is initialized with the controller reported by the {{start()}} method.
> Inside this thread, some work is performed, and at the end of a certain amount of work, the {{finishBoot()}} method is invoked. This method calls {{controller.finishBoot()}}, referencing the field that was set in the {{start()}} method.
> The problem arises when the service itself is stopped before the boot thread completes. This causes the {{controller}} field to be nulled out, resulting in an NPE.
> I think we need to look at:
> * Why are we using a background thread for this?
> * Why are we _not_ using the asynchronous startup feature?
> I think we must do one of these two things in order to make this code "safe".
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 3 months
[JBoss JIRA] (WFCORE-1855) Possible NPE on controller service start
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1855?page=com.atlassian.jira.plugi... ]
Brian Stansberry reassigned WFCORE-1855:
----------------------------------------
Assignee: Brian Stansberry
> Possible NPE on controller service start
> ----------------------------------------
>
> Key: WFCORE-1855
> URL: https://issues.jboss.org/browse/WFCORE-1855
> Project: WildFly Core
> Issue Type: Bug
> Reporter: David Lloyd
> Assignee: Brian Stansberry
>
> In {{org.jboss.as.controller.AbstractControllerService}}, the {{start}} method starts up a background thread which performs a certain amount of the boot process. Before this thread is started, a volatile field {{controller}} is initialized with the controller reported by the {{start()}} method.
> Inside this thread, some work is performed, and at the end of a certain amount of work, the {{finishBoot()}} method is invoked. This method calls {{controller.finishBoot()}}, referencing the field that was set in the {{start()}} method.
> The problem arises when the service itself is stopped before the boot thread completes. This causes the {{controller}} field to be nulled out, resulting in an NPE.
> I think we need to look at:
> * Why are we using a background thread for this?
> * Why are we _not_ using the asynchronous startup feature?
> I think we must do one of these two things in order to make this code "safe".
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 3 months
[JBoss JIRA] (WFCORE-2160) Incorrect JBOSS_HOME warning in vault.sh
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2160?page=com.atlassian.jira.plugi... ]
Brian Stansberry reopened WFCORE-2160:
--------------------------------------
> Incorrect JBOSS_HOME warning in vault.sh
> ----------------------------------------
>
> Key: WFCORE-2160
> URL: https://issues.jboss.org/browse/WFCORE-2160
> Project: WildFly Core
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 3.0.0.Alpha16
> Reporter: Dennis Reed
> Assignee: Romain Pelisse
> Priority: Minor
> Fix For: 3.0.0.Alpha23
>
>
> vault.sh has an incorrect check to make sure JBOSS_HOME is set correctly.
> SANITIZED_JBOSS_HOME=`cd "$JBOSS_HOME/.."; pwd`
> if [ "$RESOLVED_JBOSS" != "$SANITIZED_JBOSS_HOME" ]; then
> The check will always fail because of the incorrect "/..", which should be removed.
> The incorrect value is only used for printing the "WARNING JBOSS_HOME may be pointing to a different installation - unpredictable results may occur." log, and appears to have been around since at least EAP 6.0.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 3 months
[JBoss JIRA] (WFCORE-2160) Incorrect JBOSS_HOME warning in vault.sh
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2160?page=com.atlassian.jira.plugi... ]
Brian Stansberry resolved WFCORE-2160.
--------------------------------------
Fix Version/s: 3.0.0.Alpha23
(was: 3.0.0.Alpha20)
Resolution: Done
> Incorrect JBOSS_HOME warning in vault.sh
> ----------------------------------------
>
> Key: WFCORE-2160
> URL: https://issues.jboss.org/browse/WFCORE-2160
> Project: WildFly Core
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 3.0.0.Alpha16
> Reporter: Dennis Reed
> Assignee: Romain Pelisse
> Priority: Minor
> Fix For: 3.0.0.Alpha23
>
>
> vault.sh has an incorrect check to make sure JBOSS_HOME is set correctly.
> SANITIZED_JBOSS_HOME=`cd "$JBOSS_HOME/.."; pwd`
> if [ "$RESOLVED_JBOSS" != "$SANITIZED_JBOSS_HOME" ]; then
> The check will always fail because of the incorrect "/..", which should be removed.
> The incorrect value is only used for printing the "WARNING JBOSS_HOME may be pointing to a different installation - unpredictable results may occur." log, and appears to have been around since at least EAP 6.0.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 3 months
[JBoss JIRA] (WFLY-7843) Initial context factory is not able to be set in Elytron dir-context
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/WFLY-7843?page=com.atlassian.jira.plugin.... ]
Jan Kalina closed WFLY-7843.
----------------------------
Resolution: Rejected
Rejected, see workaround above.
Feel free to reopen if complete class reference (module + class) would be required.
> Initial context factory is not able to be set in Elytron dir-context
> --------------------------------------------------------------------
>
> Key: WFLY-7843
> URL: https://issues.jboss.org/browse/WFLY-7843
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Affects Versions: 11.0.0.Alpha1
> Reporter: Ondrej Lukas
> Assignee: Jan Kalina
> Priority: Critical
>
> Elytron subsystem does not allow to configure custom Initial context factory for dir-context.
> Elytron {{org.wildfly.security.auth.realm.ldapSimpleDirContextFactoryBuilder}} includes setter for field {{initialContextFactory}}, but integration for Elytron subsystem is missing. This means that default value {{com.sun.jndi.ldap.LdapCtxFactory}} is always used by Application server.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 3 months
[JBoss JIRA] (WFLY-7843) Initial context factory is not able to be set in Elytron dir-context
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/WFLY-7843?page=com.atlassian.jira.plugin.... ]
Jan Kalina commented on WFLY-7843:
----------------------------------
It is possible to override this using generic options exposed as part of WFLY-7720:
{code:xml}
<dir-context name="DirContext" ...>
<properties>
<property name="java.naming.factory.initial" value="com.sun.jndi.ldap.LdapCtxFactory"/>
</properties>
</dir-context>
{code}
> Initial context factory is not able to be set in Elytron dir-context
> --------------------------------------------------------------------
>
> Key: WFLY-7843
> URL: https://issues.jboss.org/browse/WFLY-7843
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Affects Versions: 11.0.0.Alpha1
> Reporter: Ondrej Lukas
> Assignee: Jan Kalina
> Priority: Critical
>
> Elytron subsystem does not allow to configure custom Initial context factory for dir-context.
> Elytron {{org.wildfly.security.auth.realm.ldapSimpleDirContextFactoryBuilder}} includes setter for field {{initialContextFactory}}, but integration for Elytron subsystem is missing. This means that default value {{com.sun.jndi.ldap.LdapCtxFactory}} is always used by Application server.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 3 months