[JBoss JIRA] (WFLY-8512) Private undertow capability service values expose org.jboss.msc.service.Service methods
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/WFLY-8512?page=com.atlassian.jira.plugin.... ]
Tomaz Cerar updated WFLY-8512:
------------------------------
Summary: Private undertow capability service values expose org.jboss.msc.service.Service methods (was: Public undertow capability service values expose org.jboss.msc.service.Service methods)
> Private undertow capability service values expose org.jboss.msc.service.Service methods
> ---------------------------------------------------------------------------------------
>
> Key: WFLY-8512
> URL: https://issues.jboss.org/browse/WFLY-8512
> Project: WildFly
> Issue Type: Bug
> Components: Web (Undertow)
> Affects Versions: 11.0.0.Alpha1
> Reporter: Paul Ferraro
> Assignee: Tomaz Cerar
>
> Undertow new exposes UndertowService, Server, Host, etc. to other subsystems as service values of public capabilities. However, these objects all implement Service, and thus expose start/stop methods to their dependents. This is poor encapsulation. Ideally, we should extract interfaces from these objects such that the corresponding capabilities only expose methods in explicitly in their contract.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months
[JBoss JIRA] (WFLY-8512) Private undertow capability service values expose org.jboss.msc.service.Service methods
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/WFLY-8512?page=com.atlassian.jira.plugin.... ]
Tomaz Cerar updated WFLY-8512:
------------------------------
Issue Type: Enhancement (was: Bug)
> Private undertow capability service values expose org.jboss.msc.service.Service methods
> ---------------------------------------------------------------------------------------
>
> Key: WFLY-8512
> URL: https://issues.jboss.org/browse/WFLY-8512
> Project: WildFly
> Issue Type: Enhancement
> Components: Web (Undertow)
> Affects Versions: 11.0.0.Alpha1
> Reporter: Paul Ferraro
> Assignee: Tomaz Cerar
>
> Undertow new exposes UndertowService, Server, Host, etc. to other subsystems as service values of public capabilities. However, these objects all implement Service, and thus expose start/stop methods to their dependents. This is poor encapsulation. Ideally, we should extract interfaces from these objects such that the corresponding capabilities only expose methods in explicitly in their contract.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months
[JBoss JIRA] (WFLY-8512) Public undertow capability service values expose org.jboss.msc.service.Service methods
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/WFLY-8512?page=com.atlassian.jira.plugin.... ]
Tomaz Cerar commented on WFLY-8512:
-----------------------------------
We had discussion on this topic with [~bstansberry] and decided that best thing to do for now is to mark all this capabilities as private, at least until we have some proper contract that is exposed.
> Public undertow capability service values expose org.jboss.msc.service.Service methods
> --------------------------------------------------------------------------------------
>
> Key: WFLY-8512
> URL: https://issues.jboss.org/browse/WFLY-8512
> Project: WildFly
> Issue Type: Bug
> Components: Web (Undertow)
> Affects Versions: 11.0.0.Alpha1
> Reporter: Paul Ferraro
> Assignee: Tomaz Cerar
>
> Undertow new exposes UndertowService, Server, Host, etc. to other subsystems as service values of public capabilities. However, these objects all implement Service, and thus expose start/stop methods to their dependents. This is poor encapsulation. Ideally, we should extract interfaces from these objects such that the corresponding capabilities only expose methods in explicitly in their contract.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months
[JBoss JIRA] (WFLY-8512) Public undertow capability service values expose org.jboss.msc.service.Service methods
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/WFLY-8512?page=com.atlassian.jira.plugin.... ]
Tomaz Cerar reassigned WFLY-8512:
---------------------------------
Assignee: Tomaz Cerar (was: Stuart Douglas)
> Public undertow capability service values expose org.jboss.msc.service.Service methods
> --------------------------------------------------------------------------------------
>
> Key: WFLY-8512
> URL: https://issues.jboss.org/browse/WFLY-8512
> Project: WildFly
> Issue Type: Bug
> Components: Web (Undertow)
> Affects Versions: 11.0.0.Alpha1
> Reporter: Paul Ferraro
> Assignee: Tomaz Cerar
>
> Undertow new exposes UndertowService, Server, Host, etc. to other subsystems as service values of public capabilities. However, these objects all implement Service, and thus expose start/stop methods to their dependents. This is poor encapsulation. Ideally, we should extract interfaces from these objects such that the corresponding capabilities only expose methods in explicitly in their contract.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months
[JBoss JIRA] (WFCORE-1059) RestartParentResourceAdd/RemoveHandler should handle capability registration
by Paul Ferraro (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1059?page=com.atlassian.jira.plugi... ]
Paul Ferraro commented on WFCORE-1059:
--------------------------------------
[~brian.stansberry] Not to my knowledge. What distinguishes these handlers from the others in wildfly-controller is that they do not extend AbstractAddStepHandler/AbstractRemoveStepHandler, and thus do not inherit any capability handling.
> RestartParentResourceAdd/RemoveHandler should handle capability registration
> ----------------------------------------------------------------------------
>
> Key: WFCORE-1059
> URL: https://issues.jboss.org/browse/WFCORE-1059
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 2.0.0.CR6
> Reporter: Paul Ferraro
> Fix For: 3.0.0.Beta14
>
>
> RestartParentResourceAddHandler and RestartParentResourceRemoveHandler do not extend the respective AbstractAddStepHandler and AbstractRemoveStepHandler base classes, and thus does not handle capability [un]registration.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months
[JBoss JIRA] (WFLY-8512) Public undertow capability service values expose org.jboss.msc.service.Service methods
by Paul Ferraro (JIRA)
Paul Ferraro created WFLY-8512:
----------------------------------
Summary: Public undertow capability service values expose org.jboss.msc.service.Service methods
Key: WFLY-8512
URL: https://issues.jboss.org/browse/WFLY-8512
Project: WildFly
Issue Type: Bug
Components: Web (Undertow)
Affects Versions: 11.0.0.Alpha1
Reporter: Paul Ferraro
Assignee: Stuart Douglas
Undertow new exposes UndertowService, Server, Host, etc. to other subsystems as service values of public capabilities. However, these objects all implement Service, and thus expose start/stop methods to their dependents. This is poor encapsulation. Ideally, we should extract interfaces from these objects such that the corresponding capabilities only expose methods in explicitly in their contract.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months
[JBoss JIRA] (WFCORE-2592) wildfly-service.exe and jbosspass wrong with # inside
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2592?page=com.atlassian.jira.plugi... ]
Tomaz Cerar commented on WFCORE-2592:
-------------------------------------
This is limitation of procrun tool we are using for running service https://commons.apache.org/proper/commons-daemon/procrun.html
from docs:
{quote}
++StartParams List of parameters that will be passed to either StartImage or StartClass. Parameters are separated using either # or ; character.
++StopParams List of parameters that will be passed to either StopImage or StopClass. Parameters are separated using either # or ; character.
{quote}
In some cases escaping it with \ works but it is not universal fix.
> wildfly-service.exe and jbosspass wrong with # inside
> -----------------------------------------------------
>
> Key: WFCORE-2592
> URL: https://issues.jboss.org/browse/WFCORE-2592
> Project: WildFly Core
> Issue Type: Bug
> Components: Scripts
> Reporter: Seb Dk
> Assignee: Tomaz Cerar
>
> Hi there,
>
> I am installing wildfy 10.1.0 as service on a win 20012 server.
> It is working but I cannot stop the service.
> I figured out where the problem is coming from.
>
> When I installe Wildly as a service, I run the following command:
> E:\Products\wildfly-10.1.0.Final\bin\service>service.bat install /serviceuser .\JBoss /servicepass my#pass /controller localhost:9991 /jbossuser myuser /jbosspass *my#pass*
>
> But I can see whe I am trying to stop the service, the command running is:
> E:\Products\wildfly-10.1.0.Final\bin\jboss-cli.bat --controller=localhost:9991 --connect --user=myuser --password=*my" "pass* --command=:shutdown
>
> Any workaround?
>
> Thanks,
>
> S.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months