[JBoss JIRA] (ELY-1051) Coverity, derefere null return value in KeyStoreCredentialStore.store
by Ilia Vassilev (JIRA)
[ https://issues.jboss.org/browse/ELY-1051?page=com.atlassian.jira.plugin.s... ]
Ilia Vassilev reassigned ELY-1051:
----------------------------------
Assignee: Ilia Vassilev (was: Darran Lofthouse)
> Coverity, derefere null return value in KeyStoreCredentialStore.store
> ---------------------------------------------------------------------
>
> Key: ELY-1051
> URL: https://issues.jboss.org/browse/ELY-1051
> Project: WildFly Elytron
> Issue Type: Bug
> Reporter: Martin Choma
> Assignee: Ilia Vassilev
> Priority: Critical
>
> Coverity found possible null dereference as {{getEntry()}} could return null.
> https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=12563...
> {code:java|title=KeyStoreCredentialStore.java}
> void store(OutputStream outputStream) throws IOException, GeneralSecurityException {
> ObjectOutputStream oos = new ObjectOutputStream(outputStream);
> oos.writeInt(VERSION);
> Enumeration<String> ksAliases = dataKeyStore.aliases();
> while(ksAliases.hasMoreElements()) {
> String alias = ksAliases.nextElement();
> KeyStore.Entry entry = dataKeyStore.getEntry(alias, convertParameter(protectionParameter));
> if (entry instanceof KeyStore.SecretKeyEntry) {
> saveSecretKey(alias, oos, (KeyStore.SecretKeyEntry)entry);
> } else {
> throw log.unrecognizedEntryType(entry.getClass().getCanonicalName());
> }
> }
> oos.flush();
> oos.close();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months
[JBoss JIRA] (ELY-1052) For the wrapped SSLEngine and SSLSockets allow further restriction of cipher suites.
by Darran Lofthouse (JIRA)
Darran Lofthouse created ELY-1052:
-------------------------------------
Summary: For the wrapped SSLEngine and SSLSockets allow further restriction of cipher suites.
Key: ELY-1052
URL: https://issues.jboss.org/browse/ELY-1052
Project: WildFly Elytron
Issue Type: Enhancement
Components: SSL
Reporter: Darran Lofthouse
Fix For: 2.0.0.Alpha1
We should allow further configuration where this configuration leads to a union of centrally enabled cipher suites with API specified cipher suites.
i.e. an administrator can centrally define the acceptable cipher suites but utilities using the APIs can restrict this further.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months
[JBoss JIRA] (WFCORE-2615) Attribute allow-sasl-mechanisms is ignored in Elytron Authentication Configuration
by Ondrej Lukas (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2615?page=com.atlassian.jira.plugi... ]
Ondrej Lukas updated WFCORE-2615:
---------------------------------
Description:
In case when attribute allow-sasl-mechanisms from Elytron Authentication Configuration includes some SASL mechanisms then this attribute (and mechanisms configured there) is not taken into account during choosing SASL mechanism. It means that client tries to use all of mechanisms allowed on server side even if client does not allow them. e.g. in case when server side allowed DIGEST-MD5 and JBOSS-LOCAL-USER and client side allows PLAIN, then it tries to use DIGEST-MD5 and JBOSS-LOCAL-USER mechanisms.
See log from wireshark in attachments. This is log for server configured through "Steps to Reproduce".
This happens also for using allow-sasl-mechanisms from wildfly config and also for programatically configured client.
We request blocker since it allows to use some SASL mechanisms even if they are not allowed on client side.
was:
In case when attribute allow-sasl-mechanisms from Elytron Authentication Configuration includes some SASL mechanisms then this attribute (and mechanisms configured there) is not taken into account during choosing SASL mechanism. It means that client tries to use all of mechanisms allowed on server side even if client does not allow them. e.g. in case when server side allowed DIGEST-MD5 and JBOSS-LOCAL-USER and client side allows PLAIN, then it tries to use DIGEST-MD5 and JBOSS-LOCAL-USER mechanisms.
See log from wireshark in attachments. This is log for server configured through "Steps to Reproduce".
This happens also for using allow-sasl-mechanisms from wildfly config and also for programatically configured client.
We request blocker since this issue blocks RFE EAP7-567 and EAP7-568 and it allows to use some SASL mechanisms even if they are not allowed on client side.
> Attribute allow-sasl-mechanisms is ignored in Elytron Authentication Configuration
> ----------------------------------------------------------------------------------
>
> Key: WFCORE-2615
> URL: https://issues.jboss.org/browse/WFCORE-2615
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Affects Versions: 3.0.0.Beta10
> Reporter: Ondrej Lukas
> Assignee: Darran Lofthouse
> Priority: Blocker
> Attachments: dep.war, wireshark.pcapng
>
>
> In case when attribute allow-sasl-mechanisms from Elytron Authentication Configuration includes some SASL mechanisms then this attribute (and mechanisms configured there) is not taken into account during choosing SASL mechanism. It means that client tries to use all of mechanisms allowed on server side even if client does not allow them. e.g. in case when server side allowed DIGEST-MD5 and JBOSS-LOCAL-USER and client side allows PLAIN, then it tries to use DIGEST-MD5 and JBOSS-LOCAL-USER mechanisms.
> See log from wireshark in attachments. This is log for server configured through "Steps to Reproduce".
> This happens also for using allow-sasl-mechanisms from wildfly config and also for programatically configured client.
> We request blocker since it allows to use some SASL mechanisms even if they are not allowed on client side.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months
[JBoss JIRA] (WFCORE-2615) Attribute allow-sasl-mechanisms is ignored in Elytron Authentication Configuration
by Ondrej Lukas (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2615?page=com.atlassian.jira.plugi... ]
Ondrej Lukas updated WFCORE-2615:
---------------------------------
Affects Version/s: 3.0.0.Beta10
> Attribute allow-sasl-mechanisms is ignored in Elytron Authentication Configuration
> ----------------------------------------------------------------------------------
>
> Key: WFCORE-2615
> URL: https://issues.jboss.org/browse/WFCORE-2615
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Affects Versions: 3.0.0.Beta10
> Reporter: Ondrej Lukas
> Assignee: Darran Lofthouse
> Priority: Blocker
> Attachments: dep.war, wireshark.pcapng
>
>
> In case when attribute allow-sasl-mechanisms from Elytron Authentication Configuration includes some SASL mechanisms then this attribute (and mechanisms configured there) is not taken into account during choosing SASL mechanism. It means that client tries to use all of mechanisms allowed on server side even if client does not allow them. e.g. in case when server side allowed DIGEST-MD5 and JBOSS-LOCAL-USER and client side allows PLAIN, then it tries to use DIGEST-MD5 and JBOSS-LOCAL-USER mechanisms.
> See log from wireshark in attachments. This is log for server configured through "Steps to Reproduce".
> This happens also for using allow-sasl-mechanisms from wildfly config and also for programatically configured client.
> We request blocker since this issue blocks RFE EAP7-567 and EAP7-568 and it allows to use some SASL mechanisms even if they are not allowed on client side.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months