[JBoss JIRA] (DROOLS-1685) Improve performance of rules using "or" in LHS
by Russell Morrisey (JIRA)
Russell Morrisey created DROOLS-1685:
----------------------------------------
Summary: Improve performance of rules using "or" in LHS
Key: DROOLS-1685
URL: https://issues.jboss.org/browse/DROOLS-1685
Project: Drools
Issue Type: Enhancement
Components: core engine, kie server
Affects Versions: 6.5.0.Final
Reporter: Russell Morrisey
Assignee: Mario Fusco
The following two rulesets produce the same output, but their performance differs dramatically.
My understanding is that the two rulesets should be equivalent to one another. It seems like the 'or' operation must be handled inefficiently by the engine. Is there anything that can be improved the engine's performance in this case?
Ruleset #1 takes ~3 seconds to execute on my local machine (for a dataset with 3 entities, 1 service ordered each). Ruleset #2 runs in ~200 ms.
*Ruleset 1*
{code:java}
rule "Rule183"
dialect "mvel"
when
$entity : Entity( )
( $service : ServiceOrdered( serviceId == "FORM" , entity == $entity , entity.entityTypeId in ( 291262, 291275, 291277 ) ) or $service : ServiceOrdered( serviceId == "DISSO" , entity == $entity , entity.entityTypeId in ( 291262 ) , stateId == 290864 ) )
$r1 : QuestionDefinition( id == 590 )
then
Question fact0 = new Question();
fact0.setQuestionDefinition( $r1 );
fact0.setEntity( $entity );
insert( fact0 );
end
{code}
*Ruleset 2*
{code:java}
rule "Rule183"
dialect "mvel"
when
$entity : Entity( )
$service : ServiceOrdered( serviceId == "FORM" , entity == $entity , entity.entityTypeId in ( 291262, 291275, 291277 ) )
$r1 : QuestionDefinition( id == 590 )
then
Question fact0 = new Question();
fact0.setQuestionDefinition( $r1 );
fact0.setEntity( $entity );
insert( fact0 );
end
{code}
{code}
rule "Rule183-2"
dialect "mvel"
when
$entity : Entity( )
$service : ServiceOrdered( serviceId == "DISSO" , entity == $entity , entity.entityTypeId == 291262 , stateId == 290864 )
$r1 : QuestionDefinition( id == 590 )
then
Question fact0 = new Question();
fact0.setQuestionDefinition( $r1 );
fact0.setEntity( $entity );
insert( fact0 );
end
{code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 8 months
[JBoss JIRA] (WFCORE-3128) [7.0.z] standalone.bat script does not parse JAVA_OPTS containing '|' symbol properly
by Radovan Stancel (JIRA)
Radovan Stancel created WFCORE-3128:
---------------------------------------
Summary: [7.0.z] standalone.bat script does not parse JAVA_OPTS containing '|' symbol properly
Key: WFCORE-3128
URL: https://issues.jboss.org/browse/WFCORE-3128
Project: WildFly Core
Issue Type: Bug
Components: Scripts
Affects Versions: 3.0.0.Beta30
Reporter: Radovan Stancel
Assignee: Radovan Stancel
======================
Scenario-1)
============ With the following line of JAVA_OPTS in "standalone.bat.conf" file
set "JAVA_OPTS=%JAVA_OPTS% -Dhttp.nonProxyHosts=localhost|127.0.0.1|10.10.10.*"
{code}
Error while starting EAP 6.1.1
C:\jboss-eap-6.1.1\bin>standalone.bat
Calling "C:\jboss-eap-6.1.1\bin\standalone.conf.bat"
Setting JAVA property to "C:\JDKs\jdk1.7.0_67\bin\java"
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
{code}
Scenario-2)
============ In Windows "^" sign is the escape character so we tried altering the JAVA_OPTS as following in the "standalone.bat.conf" file:
set "JAVA_OPTS=%JAVA_OPTS% -Dhttp.nonProxyHosts=localhost^|127.0.0.1^|10.10.10.*"
Now EAP 6.1.1 server starts but still we see the following messages in windows console:
{code}
C:\jboss-eap-6.1.1\bin>standalone.bat
Calling "C:\jboss-eap-6.1.1\bin\standalone.conf.bat"
Setting JAVA property to "C:\JDKs\jdk1.7.0_67\bin\java"
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
{code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 8 months
[JBoss JIRA] (ELY-1313) Alias from dependent credential store is not avalaible on server start
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/ELY-1313?page=com.atlassian.jira.plugin.s... ]
Jan Kalina updated ELY-1313:
----------------------------
Description:
This is backport of
BouncyCastle external CredentialStore fail to store secret:
{code}
KeyStoreCredentialStore: flushing failed: java.lang.NullPointerException
at org.bouncycastle.jcajce.provider.BaseCipher.engineGetParameters(Unknown Source)
at javax.crypto.Cipher.checkCryptoPerm(Cipher.java:1020)
at javax.crypto.Cipher.init(Cipher.java:1245)
at javax.crypto.Cipher.init(Cipher.java:1186)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.saveSecretKey(KeyStoreCredentialStore.java:1299)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.store(KeyStoreCredentialStore.java:1283)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore.flush(KeyStoreCredentialStore.java:779)
at org.wildfly.security.credential.store.CredentialStore.flush(CredentialStore.java:364)
at org.wildfly.extension.elytron.CredentialStoreResourceDefinition.storeSecret(CredentialStoreResourceDefinition.java:517)
{code}
was:
BouncyCastle external CredentialStore fail to store secret:
{code}
KeyStoreCredentialStore: flushing failed: java.lang.NullPointerException
at org.bouncycastle.jcajce.provider.BaseCipher.engineGetParameters(Unknown Source)
at javax.crypto.Cipher.checkCryptoPerm(Cipher.java:1020)
at javax.crypto.Cipher.init(Cipher.java:1245)
at javax.crypto.Cipher.init(Cipher.java:1186)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.saveSecretKey(KeyStoreCredentialStore.java:1299)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.store(KeyStoreCredentialStore.java:1283)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore.flush(KeyStoreCredentialStore.java:779)
at org.wildfly.security.credential.store.CredentialStore.flush(CredentialStore.java:364)
at org.wildfly.extension.elytron.CredentialStoreResourceDefinition.storeSecret(CredentialStoreResourceDefinition.java:517)
{code}
> Alias from dependent credential store is not avalaible on server start
> ----------------------------------------------------------------------
>
> Key: ELY-1313
> URL: https://issues.jboss.org/browse/ELY-1313
> Project: WildFly Elytron
> Issue Type: Bug
> Components: Credential Store
> Affects Versions: 1.1.0.CR2
> Reporter: Jan Kalina
> Assignee: Jan Kalina
> Priority: Critical
>
> This is backport of
> BouncyCastle external CredentialStore fail to store secret:
> {code}
> KeyStoreCredentialStore: flushing failed: java.lang.NullPointerException
> at org.bouncycastle.jcajce.provider.BaseCipher.engineGetParameters(Unknown Source)
> at javax.crypto.Cipher.checkCryptoPerm(Cipher.java:1020)
> at javax.crypto.Cipher.init(Cipher.java:1245)
> at javax.crypto.Cipher.init(Cipher.java:1186)
> at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.saveSecretKey(KeyStoreCredentialStore.java:1299)
> at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.store(KeyStoreCredentialStore.java:1283)
> at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore.flush(KeyStoreCredentialStore.java:779)
> at org.wildfly.security.credential.store.CredentialStore.flush(CredentialStore.java:364)
> at org.wildfly.extension.elytron.CredentialStoreResourceDefinition.storeSecret(CredentialStoreResourceDefinition.java:517)
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 8 months
[JBoss JIRA] (ELY-1313) Alias from dependent credential store is not avalaible on server start
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/ELY-1313?page=com.atlassian.jira.plugin.s... ]
Jan Kalina updated ELY-1313:
----------------------------
Description:
*This is backport of ELY-1308*
BouncyCastle external CredentialStore fail to store secret:
{code}
KeyStoreCredentialStore: flushing failed: java.lang.NullPointerException
at org.bouncycastle.jcajce.provider.BaseCipher.engineGetParameters(Unknown Source)
at javax.crypto.Cipher.checkCryptoPerm(Cipher.java:1020)
at javax.crypto.Cipher.init(Cipher.java:1245)
at javax.crypto.Cipher.init(Cipher.java:1186)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.saveSecretKey(KeyStoreCredentialStore.java:1299)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.store(KeyStoreCredentialStore.java:1283)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore.flush(KeyStoreCredentialStore.java:779)
at org.wildfly.security.credential.store.CredentialStore.flush(CredentialStore.java:364)
at org.wildfly.extension.elytron.CredentialStoreResourceDefinition.storeSecret(CredentialStoreResourceDefinition.java:517)
{code}
was:
This is backport of
BouncyCastle external CredentialStore fail to store secret:
{code}
KeyStoreCredentialStore: flushing failed: java.lang.NullPointerException
at org.bouncycastle.jcajce.provider.BaseCipher.engineGetParameters(Unknown Source)
at javax.crypto.Cipher.checkCryptoPerm(Cipher.java:1020)
at javax.crypto.Cipher.init(Cipher.java:1245)
at javax.crypto.Cipher.init(Cipher.java:1186)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.saveSecretKey(KeyStoreCredentialStore.java:1299)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.store(KeyStoreCredentialStore.java:1283)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore.flush(KeyStoreCredentialStore.java:779)
at org.wildfly.security.credential.store.CredentialStore.flush(CredentialStore.java:364)
at org.wildfly.extension.elytron.CredentialStoreResourceDefinition.storeSecret(CredentialStoreResourceDefinition.java:517)
{code}
> Alias from dependent credential store is not avalaible on server start
> ----------------------------------------------------------------------
>
> Key: ELY-1313
> URL: https://issues.jboss.org/browse/ELY-1313
> Project: WildFly Elytron
> Issue Type: Bug
> Components: Credential Store
> Affects Versions: 1.1.0.CR2
> Reporter: Jan Kalina
> Assignee: Jan Kalina
> Priority: Critical
>
> *This is backport of ELY-1308*
> BouncyCastle external CredentialStore fail to store secret:
> {code}
> KeyStoreCredentialStore: flushing failed: java.lang.NullPointerException
> at org.bouncycastle.jcajce.provider.BaseCipher.engineGetParameters(Unknown Source)
> at javax.crypto.Cipher.checkCryptoPerm(Cipher.java:1020)
> at javax.crypto.Cipher.init(Cipher.java:1245)
> at javax.crypto.Cipher.init(Cipher.java:1186)
> at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.saveSecretKey(KeyStoreCredentialStore.java:1299)
> at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.store(KeyStoreCredentialStore.java:1283)
> at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore.flush(KeyStoreCredentialStore.java:779)
> at org.wildfly.security.credential.store.CredentialStore.flush(CredentialStore.java:364)
> at org.wildfly.extension.elytron.CredentialStoreResourceDefinition.storeSecret(CredentialStoreResourceDefinition.java:517)
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 8 months
[JBoss JIRA] (ELY-1313) Alias from dependent credential store is not avalaible on server start
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/ELY-1313?page=com.atlassian.jira.plugin.s... ]
Jan Kalina updated ELY-1313:
----------------------------
Fix Version/s: (was: 1.2.0.Beta1)
> Alias from dependent credential store is not avalaible on server start
> ----------------------------------------------------------------------
>
> Key: ELY-1313
> URL: https://issues.jboss.org/browse/ELY-1313
> Project: WildFly Elytron
> Issue Type: Bug
> Components: Credential Store
> Affects Versions: 1.1.0.CR2
> Reporter: Jan Kalina
> Assignee: Jan Kalina
> Priority: Critical
>
> BouncyCastle external CredentialStore fail to store secret:
> {code}
> KeyStoreCredentialStore: flushing failed: java.lang.NullPointerException
> at org.bouncycastle.jcajce.provider.BaseCipher.engineGetParameters(Unknown Source)
> at javax.crypto.Cipher.checkCryptoPerm(Cipher.java:1020)
> at javax.crypto.Cipher.init(Cipher.java:1245)
> at javax.crypto.Cipher.init(Cipher.java:1186)
> at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.saveSecretKey(KeyStoreCredentialStore.java:1299)
> at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.store(KeyStoreCredentialStore.java:1283)
> at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore.flush(KeyStoreCredentialStore.java:779)
> at org.wildfly.security.credential.store.CredentialStore.flush(CredentialStore.java:364)
> at org.wildfly.extension.elytron.CredentialStoreResourceDefinition.storeSecret(CredentialStoreResourceDefinition.java:517)
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 8 months
[JBoss JIRA] (ELY-1313) Alias from dependent credential store is not avalaible on server start
by Jan Kalina (JIRA)
Jan Kalina created ELY-1313:
-------------------------------
Summary: Alias from dependent credential store is not avalaible on server start
Key: ELY-1313
URL: https://issues.jboss.org/browse/ELY-1313
Project: WildFly Elytron
Issue Type: Bug
Components: Credential Store
Affects Versions: 1.1.0.CR2
Reporter: Jan Kalina
Assignee: Jan Kalina
Priority: Critical
Fix For: 1.2.0.Beta1
BouncyCastle external CredentialStore fail to store secret:
{code}
KeyStoreCredentialStore: flushing failed: java.lang.NullPointerException
at org.bouncycastle.jcajce.provider.BaseCipher.engineGetParameters(Unknown Source)
at javax.crypto.Cipher.checkCryptoPerm(Cipher.java:1020)
at javax.crypto.Cipher.init(Cipher.java:1245)
at javax.crypto.Cipher.init(Cipher.java:1186)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.saveSecretKey(KeyStoreCredentialStore.java:1299)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore$ExternalStorage.store(KeyStoreCredentialStore.java:1283)
at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore.flush(KeyStoreCredentialStore.java:779)
at org.wildfly.security.credential.store.CredentialStore.flush(CredentialStore.java:364)
at org.wildfly.extension.elytron.CredentialStoreResourceDefinition.storeSecret(CredentialStoreResourceDefinition.java:517)
{code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 8 months
[JBoss JIRA] (WFCORE-3127) standalone.bat script does not parse JAVA_OPTS containing '|' symbol properly
by Radovan Stancel (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3127?page=com.atlassian.jira.plugi... ]
Radovan Stancel commented on WFCORE-3127:
-----------------------------------------
As code was changed a lot, fix for WFCORE-99 is no more valid.
> standalone.bat script does not parse JAVA_OPTS containing '|' symbol properly
> -----------------------------------------------------------------------------
>
> Key: WFCORE-3127
> URL: https://issues.jboss.org/browse/WFCORE-3127
> Project: WildFly Core
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 3.0.0.Beta30
> Reporter: Radovan Stancel
> Assignee: Radovan Stancel
> Labels: downstream_dependency
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> ======================
> Scenario-1)
> ============ With the following line of JAVA_OPTS in "standalone.bat.conf" file
> set "JAVA_OPTS=%JAVA_OPTS% -Dhttp.nonProxyHosts=localhost|127.0.0.1|10.10.10.*"
> {code}
> Error while starting EAP 6.1.1
> C:\jboss-eap-6.1.1\bin>standalone.bat
> Calling "C:\jboss-eap-6.1.1\bin\standalone.conf.bat"
> Setting JAVA property to "C:\JDKs\jdk1.7.0_67\bin\java"
> '127.0.0.1' is not recognized as an internal or external command,
> operable program or batch file.
> {code}
> Scenario-2)
> ============ In Windows "^" sign is the escape character so we tried altering the JAVA_OPTS as following in the "standalone.bat.conf" file:
> set "JAVA_OPTS=%JAVA_OPTS% -Dhttp.nonProxyHosts=localhost^|127.0.0.1^|10.10.10.*"
> Now EAP 6.1.1 server starts but still we see the following messages in windows console:
> {code}
> C:\jboss-eap-6.1.1\bin>standalone.bat
> Calling "C:\jboss-eap-6.1.1\bin\standalone.conf.bat"
> Setting JAVA property to "C:\JDKs\jdk1.7.0_67\bin\java"
> '127.0.0.1' is not recognized as an internal or external command,
> operable program or batch file.
> '127.0.0.1' is not recognized as an internal or external command,
> operable program or batch file.
> '127.0.0.1' is not recognized as an internal or external command,
> operable program or batch file.
> '127.0.0.1' is not recognized as an internal or external command,
> operable program or batch file.
> '127.0.0.1' is not recognized as an internal or external command,
> operable program or batch file.
> '127.0.0.1' is not recognized as an internal or external command,
> operable program or batch file.
> '127.0.0.1' is not recognized as an internal or external command,
> operable program or batch file.
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 8 months
[JBoss JIRA] (WFCORE-3127) standalone.bat script does not parse JAVA_OPTS containing '|' symbol properly
by Radovan Stancel (JIRA)
Radovan Stancel created WFCORE-3127:
---------------------------------------
Summary: standalone.bat script does not parse JAVA_OPTS containing '|' symbol properly
Key: WFCORE-3127
URL: https://issues.jboss.org/browse/WFCORE-3127
Project: WildFly Core
Issue Type: Bug
Components: Scripts
Affects Versions: 3.0.0.Beta30
Reporter: Radovan Stancel
Assignee: Radovan Stancel
======================
Scenario-1)
============ With the following line of JAVA_OPTS in "standalone.bat.conf" file
set "JAVA_OPTS=%JAVA_OPTS% -Dhttp.nonProxyHosts=localhost|127.0.0.1|10.10.10.*"
{code}
Error while starting EAP 6.1.1
C:\jboss-eap-6.1.1\bin>standalone.bat
Calling "C:\jboss-eap-6.1.1\bin\standalone.conf.bat"
Setting JAVA property to "C:\JDKs\jdk1.7.0_67\bin\java"
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
{code}
Scenario-2)
============ In Windows "^" sign is the escape character so we tried altering the JAVA_OPTS as following in the "standalone.bat.conf" file:
set "JAVA_OPTS=%JAVA_OPTS% -Dhttp.nonProxyHosts=localhost^|127.0.0.1^|10.10.10.*"
Now EAP 6.1.1 server starts but still we see the following messages in windows console:
{code}
C:\jboss-eap-6.1.1\bin>standalone.bat
Calling "C:\jboss-eap-6.1.1\bin\standalone.conf.bat"
Setting JAVA property to "C:\JDKs\jdk1.7.0_67\bin\java"
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
'127.0.0.1' is not recognized as an internal or external command,
operable program or batch file.
{code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 8 months