[JBoss JIRA] (DROOLS-3761) [DMN Designer] Enumeration constraint entry edit mode
by Elizabeth Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-3761?page=com.atlassian.jira.plugi... ]
Elizabeth Clayton commented on DROOLS-3761:
-------------------------------------------
Jozef Marko Here's what I found in PF concerning inline edits: https://www.patternfly.org/pattern-library/forms-and-controls/inli...
* "Click Away: When a new or existing row is in edit mode and changes have not been made, clicking away should act as a cancel action, exiting edit mode without confirmation. If changes have been made to the editable row, a dialog should appear to ask the user if changes should be saved before exiting edit mode."
A dialog would not be reasonable in our case, but we could use an inline notification instead. There are some things we'd still need to work out with the Cancel interaction though...

> [DMN Designer] Enumeration constraint entry edit mode
> -----------------------------------------------------
>
> Key: DROOLS-3761
> URL: https://issues.jboss.org/browse/DROOLS-3761
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.19.0.Final
> Reporter: Jozef Marko
> Assignee: Daniel José dos Santos
> Priority: Minor
> Labels: drools-tools
> Attachments: constraint_unsaved.png, focus_lost.webm, lost_focus_data_types.webm
>
>
> The attached video shows the user interaction with enumeration constraint component. We can see if user fill valid values and clicks somewhere outside of the entry in edit mode, the values are lost. The only way how to save values is to click the *check* button. User should not lost filled in values if he clicks outside of input fields.
> Please compare the same behavior with data types list view component. It means [^focus_lost.webm] vs [^lost_focus_data_types.webm] .
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 5 months
[JBoss JIRA] (DROOLS-3761) [DMN Designer] Enumeration constraint entry edit mode
by Elizabeth Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-3761?page=com.atlassian.jira.plugi... ]
Elizabeth Clayton updated DROOLS-3761:
--------------------------------------
Comment: was deleted
(was: [~jomarko] Here's what I found in PF concerning inline edits: https://www.patternfly.org/pattern-library/forms-and-controls/inline-edit...
* "Click Away: When a new or existing row is in edit mode and changes have not been made, clicking away should act as a cancel action, exiting edit mode without confirmation. If changes have been made to the editable row, a dialog should appear to ask the user if changes should be saved before exiting edit mode."
In the latter case, it doesn't specify whether to hold the values or not but I would think it should. And a dialog would not be reasonable in our case, so instead I think an inline notification instead. If so, it might look something like this (note: I replaced the intro help text and placed the alert in its location instead.) Example:
!constraint_unsaved.png|thumbnail!
[~karreiro] [~dadossan] Wdyt?
)
> [DMN Designer] Enumeration constraint entry edit mode
> -----------------------------------------------------
>
> Key: DROOLS-3761
> URL: https://issues.jboss.org/browse/DROOLS-3761
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.19.0.Final
> Reporter: Jozef Marko
> Assignee: Daniel José dos Santos
> Priority: Minor
> Labels: drools-tools
> Attachments: constraint_unsaved.png, focus_lost.webm, lost_focus_data_types.webm
>
>
> The attached video shows the user interaction with enumeration constraint component. We can see if user fill valid values and clicks somewhere outside of the entry in edit mode, the values are lost. The only way how to save values is to click the *check* button. User should not lost filled in values if he clicks outside of input fields.
> Please compare the same behavior with data types list view component. It means [^focus_lost.webm] vs [^lost_focus_data_types.webm] .
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 5 months
[JBoss JIRA] (DROOLS-3761) [DMN Designer] Enumeration constraint entry edit mode
by Elizabeth Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-3761?page=com.atlassian.jira.plugi... ]
Elizabeth Clayton edited comment on DROOLS-3761 at 4/24/19 4:39 PM:
--------------------------------------------------------------------
[~jomarko] Here's what I found in PF concerning inline edits: https://www.patternfly.org/pattern-library/forms-and-controls/inline-edit...
* "Click Away: When a new or existing row is in edit mode and changes have not been made, clicking away should act as a cancel action, exiting edit mode without confirmation. If changes have been made to the editable row, a dialog should appear to ask the user if changes should be saved before exiting edit mode."
In the latter case, it doesn't specify whether to hold the values or not but I would think it should. And a dialog would not be reasonable in our case, so instead I think an inline notification instead. If so, it might look something like this (note: I replaced the intro help text and placed the alert in its location instead.) Example:
!constraint_unsaved.png|thumbnail!
[~karreiro] [~dadossan] Wdyt?
was (Author: uxdlc):
[~jomarko] Here's what I found in PF concerning inline edits: https://www.patternfly.org/pattern-library/forms-and-controls/inline-edit...
* "Click Away: When a new or existing row is in edit mode and changes have not been made, clicking away should act as a cancel action, exiting edit mode without confirmation. If changes have been made to the editable row, a dialog should appear to ask the user if changes should be saved before exiting edit mode."
In the latter case, it doesn't specify whether to hold the values or not but I would think it should. And a dialog would not be reasonable in our case, so instead I think an inline notification instead. If so, it might look something like this (note: I replaced the intro help text and placed the alert in its location instead.) Example:
!constraint_unsaved.png|thumbnail!
[~karreiro] [~dadossan] Wdyt?
> [DMN Designer] Enumeration constraint entry edit mode
> -----------------------------------------------------
>
> Key: DROOLS-3761
> URL: https://issues.jboss.org/browse/DROOLS-3761
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.19.0.Final
> Reporter: Jozef Marko
> Assignee: Daniel José dos Santos
> Priority: Minor
> Labels: drools-tools
> Attachments: constraint_unsaved.png, focus_lost.webm, lost_focus_data_types.webm
>
>
> The attached video shows the user interaction with enumeration constraint component. We can see if user fill valid values and clicks somewhere outside of the entry in edit mode, the values are lost. The only way how to save values is to click the *check* button. User should not lost filled in values if he clicks outside of input fields.
> Please compare the same behavior with data types list view component. It means [^focus_lost.webm] vs [^lost_focus_data_types.webm] .
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 5 months
[JBoss JIRA] (DROOLS-3761) [DMN Designer] Enumeration constraint entry edit mode
by Elizabeth Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-3761?page=com.atlassian.jira.plugi... ]
Elizabeth Clayton edited comment on DROOLS-3761 at 4/24/19 4:39 PM:
--------------------------------------------------------------------
[~jomarko] Here's what I found in PF concerning inline edits: https://www.patternfly.org/pattern-library/forms-and-controls/inline-edit...
* "Click Away: When a new or existing row is in edit mode and changes have not been made, clicking away should act as a cancel action, exiting edit mode without confirmation. If changes have been made to the editable row, a dialog should appear to ask the user if changes should be saved before exiting edit mode."
In the latter case, it doesn't specify whether to hold the values or not but I would think it should. And a dialog would not be reasonable in our case, so instead I think an inline notification instead. If so, it might look something like this (note: I replaced the intro help text and placed the alert in its location instead.) Example:
!constraint_unsaved.png|thumbnail!
[~karreiro] [~dadossan] Wdyt?
was (Author: uxdlc):
[~jomarko] Here's what I found in PF concerning inline edits: https://www.patternfly.org/pattern-library/forms-and-controls/inline-edit...
_"Click Away: When a new or existing row is in edit mode and changes have not been made, clicking away should act as a cancel action, exiting edit mode without confirmation. If changes have been made to the editable row, a dialog should appear to ask the user if changes should be saved before exiting edit mode." _
In the latter case, it doesn't specify whether to hold the values or not but I would think it should. And a dialog would not be reasonable in our case, so instead I think an inline notification instead. If so, it might look something like this (note: I replaced the intro help text and placed the alert in its location instead.) Example:
!constraint_unsaved.png|thumbnail!
[~karreiro] [~dadossan] Wdyt?
> [DMN Designer] Enumeration constraint entry edit mode
> -----------------------------------------------------
>
> Key: DROOLS-3761
> URL: https://issues.jboss.org/browse/DROOLS-3761
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.19.0.Final
> Reporter: Jozef Marko
> Assignee: Daniel José dos Santos
> Priority: Minor
> Labels: drools-tools
> Attachments: constraint_unsaved.png, focus_lost.webm, lost_focus_data_types.webm
>
>
> The attached video shows the user interaction with enumeration constraint component. We can see if user fill valid values and clicks somewhere outside of the entry in edit mode, the values are lost. The only way how to save values is to click the *check* button. User should not lost filled in values if he clicks outside of input fields.
> Please compare the same behavior with data types list view component. It means [^focus_lost.webm] vs [^lost_focus_data_types.webm] .
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 5 months
[JBoss JIRA] (DROOLS-3761) [DMN Designer] Enumeration constraint entry edit mode
by Elizabeth Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-3761?page=com.atlassian.jira.plugi... ]
Elizabeth Clayton updated DROOLS-3761:
--------------------------------------
Attachment: constraint_unsaved.png
> [DMN Designer] Enumeration constraint entry edit mode
> -----------------------------------------------------
>
> Key: DROOLS-3761
> URL: https://issues.jboss.org/browse/DROOLS-3761
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.19.0.Final
> Reporter: Jozef Marko
> Assignee: Daniel José dos Santos
> Priority: Minor
> Labels: drools-tools
> Attachments: constraint_unsaved.png, focus_lost.webm, lost_focus_data_types.webm
>
>
> The attached video shows the user interaction with enumeration constraint component. We can see if user fill valid values and clicks somewhere outside of the entry in edit mode, the values are lost. The only way how to save values is to click the *check* button. User should not lost filled in values if he clicks outside of input fields.
> Please compare the same behavior with data types list view component. It means [^focus_lost.webm] vs [^lost_focus_data_types.webm] .
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 5 months
[JBoss JIRA] (DROOLS-3761) [DMN Designer] Enumeration constraint entry edit mode
by Elizabeth Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-3761?page=com.atlassian.jira.plugi... ]
Elizabeth Clayton commented on DROOLS-3761:
-------------------------------------------
[~jomarko] Here's what I found in PF concerning inline edits: https://www.patternfly.org/pattern-library/forms-and-controls/inline-edit...
_"Click Away: When a new or existing row is in edit mode and changes have not been made, clicking away should act as a cancel action, exiting edit mode without confirmation. If changes have been made to the editable row, a dialog should appear to ask the user if changes should be saved before exiting edit mode." _
In the latter case, it doesn't specify whether to hold the values or not but I would think it should. And a dialog would not be reasonable in our case, so instead I think an inline notification instead. If so, it might look something like this (note: I replaced the intro help text and placed the alert in its location instead.) Example:
!constraint_unsaved.png|thumbnail!
[~karreiro] [~dadossan] Wdyt?
> [DMN Designer] Enumeration constraint entry edit mode
> -----------------------------------------------------
>
> Key: DROOLS-3761
> URL: https://issues.jboss.org/browse/DROOLS-3761
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.19.0.Final
> Reporter: Jozef Marko
> Assignee: Daniel José dos Santos
> Priority: Minor
> Labels: drools-tools
> Attachments: constraint_unsaved.png, focus_lost.webm, lost_focus_data_types.webm
>
>
> The attached video shows the user interaction with enumeration constraint component. We can see if user fill valid values and clicks somewhere outside of the entry in edit mode, the values are lost. The only way how to save values is to click the *check* button. User should not lost filled in values if he clicks outside of input fields.
> Please compare the same behavior with data types list view component. It means [^focus_lost.webm] vs [^lost_focus_data_types.webm] .
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 5 months
[JBoss JIRA] (DROOLS-3877) DMN Decision table headers: Add edit table actions to contextual menu.
by Elizabeth Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-3877?page=com.atlassian.jira.plugi... ]
Elizabeth Clayton commented on DROOLS-3877:
-------------------------------------------
[~manstis] The pic is just an example for this one grid/column of course. The menu for each would be contextual to the type of grid and header. :)
> DMN Decision table headers: Add edit table actions to contextual menu.
> ----------------------------------------------------------------------
>
> Key: DROOLS-3877
> URL: https://issues.jboss.org/browse/DROOLS-3877
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Reporter: Elizabeth Clayton
> Assignee: Elizabeth Clayton
> Priority: Major
> Labels: Field, UX, UXTeam, drools-tools
> Attachments: Screen Shot 2019-04-18 at 5.04.49 PM.png, header-context.png, header-context2b.png
>
>
> As a user of this feature I want to have the possibility to add columns or rows in a DT when right-clicking on the table header.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 5 months
[JBoss JIRA] (DROOLS-3877) DMN Decision table headers: Add edit table actions to contextual menu.
by Elizabeth Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-3877?page=com.atlassian.jira.plugi... ]
Elizabeth Clayton commented on DROOLS-3877:
-------------------------------------------
[~manstis] Thanks for opening this up for consideration. I guess if I were to propose a more long term solution, then I would weigh in favor of consistency. In this case, because Scenario already has header menus then we should align with them. In which case then we would:
* Hide, rather than disable, the menu items that don't apply to the header.
* Use generic actions (Insert column left) with context-specific headers (Output Clause). This was presented earlier in this document: https://docs.google.com/document/d/1lHQ1mvmzQcgWbxwkBobIXb9mV6uM3RLbEll8-...
The menu would end up looking something like this:
!header-context2b.png|thumbnail!
I wasn't sure how to deal with Clear because I'm a little unclear (no pun intended) about that action? Also, I used the verbiage that [~stetson.robinson] recommended in the above document. I defer to him wrt adding an Append action or just leave it as "Insert row below" or "Insert row" (which could add to the bottom by default.)
The above would require reworking all the contextual menus in DMN, not just the header menus.
P.S. [~danielezonca] The header cell in Scenario does appear to get the highlight selection, is there a fix for that or is it in the works?
> DMN Decision table headers: Add edit table actions to contextual menu.
> ----------------------------------------------------------------------
>
> Key: DROOLS-3877
> URL: https://issues.jboss.org/browse/DROOLS-3877
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Reporter: Elizabeth Clayton
> Assignee: Elizabeth Clayton
> Priority: Major
> Labels: Field, UX, UXTeam, drools-tools
> Attachments: Screen Shot 2019-04-18 at 5.04.49 PM.png, header-context.png, header-context2b.png
>
>
> As a user of this feature I want to have the possibility to add columns or rows in a DT when right-clicking on the table header.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 5 months