[JBoss JIRA] (ELY-1745) The AvailableRealmsCallback should not result in a NPE if there is no mechanism configuration.
by Justin Cook (Jira)
[ https://issues.jboss.org/browse/ELY-1745?page=com.atlassian.jira.plugin.s... ]
Justin Cook commented on ELY-1745:
----------------------------------
Since my internship is finishing today, I am unassigning myself from this issue. Work done so far is available on my clone of the [WildFly Elytron repository|https://github.com/justinmcook/wildfly-elytron/tree/ELY-1745]
> The AvailableRealmsCallback should not result in a NPE if there is no mechanism configuration.
> ----------------------------------------------------------------------------------------------
>
> Key: ELY-1745
> URL: https://issues.jboss.org/browse/ELY-1745
> Project: WildFly Elytron
> Issue Type: Bug
> Components: API / SPI
> Reporter: Darran Lofthouse
> Assignee: Justin Cook
> Priority: Major
> Fix For: 1.10.0.CR7
>
>
> The NPE is due to the following code: -
> {noformat}
> } else if (callback instanceof AvailableRealmsCallback) {
> Collection<String> names = stateRef.get().getMechanismConfiguration().getMechanismRealmNames();
> if (log.isTraceEnabled()) {
> log.tracef("Handling AvailableRealmsCallback: realms = [%s]", String.join(", ", names));
> }
> if (! names.isEmpty()) {
> ((AvailableRealmsCallback) callback).setRealmNames(names.toArray(new String[names.size()]));
> }
> handleOne(callbacks, idx + 1);
> {noformat}
> If mechanism configuration is mandatory this should report an appropriate error, if not it should fallback to specifying an empty list.
--
This message was sent by Atlassian Jira
(v7.13.5#713005)
5 years, 4 months
[JBoss JIRA] (ELY-1745) The AvailableRealmsCallback should not result in a NPE if there is no mechanism configuration.
by Justin Cook (Jira)
[ https://issues.jboss.org/browse/ELY-1745?page=com.atlassian.jira.plugin.s... ]
Justin Cook reassigned ELY-1745:
--------------------------------
Assignee: (was: Justin Cook)
> The AvailableRealmsCallback should not result in a NPE if there is no mechanism configuration.
> ----------------------------------------------------------------------------------------------
>
> Key: ELY-1745
> URL: https://issues.jboss.org/browse/ELY-1745
> Project: WildFly Elytron
> Issue Type: Bug
> Components: API / SPI
> Reporter: Darran Lofthouse
> Priority: Major
> Fix For: 1.10.0.CR7
>
>
> The NPE is due to the following code: -
> {noformat}
> } else if (callback instanceof AvailableRealmsCallback) {
> Collection<String> names = stateRef.get().getMechanismConfiguration().getMechanismRealmNames();
> if (log.isTraceEnabled()) {
> log.tracef("Handling AvailableRealmsCallback: realms = [%s]", String.join(", ", names));
> }
> if (! names.isEmpty()) {
> ((AvailableRealmsCallback) callback).setRealmNames(names.toArray(new String[names.size()]));
> }
> handleOne(callbacks, idx + 1);
> {noformat}
> If mechanism configuration is mandatory this should report an appropriate error, if not it should fallback to specifying an empty list.
--
This message was sent by Atlassian Jira
(v7.13.5#713005)
5 years, 4 months
[JBoss JIRA] (ELY-1778) Enhanced Audit Logging - Feature parity with legacy audit logging
by Justin Cook (Jira)
[ https://issues.jboss.org/browse/ELY-1778?page=com.atlassian.jira.plugin.s... ]
Justin Cook edited comment on ELY-1778 at 8/30/19 2:17 PM:
-----------------------------------------------------------
Since my internship is finishing today, I'm unassigning myself from the issue and leaving this status update based on my [Elytron branch|https://github.com/justinmcook/wildfly-elytron/tree/ELY-1778]:
The security events without a direct legacy equivalent have been added
Work has been done on making RealmEventVisitor available in WildFly Core's AuditResourceDefinitions by attempting to create a generic ElytronEvent that can be used
The branch is currently incorporates [ELY-1712|https://issues.jboss.org/browse/ELY-1712], which has since been merged and as such future work on this issue no longer needs that commit
was (Author: jucook):
Since my internship is finishing today, I'm unassigning myself from the issue and leaving this status update based on my [Elytron branch|https://github.com/justinmcook/wildfly-elytron/tree/ELY-1778]:
The security events without a direct legacy equivalent have been added
Work has been done on making RealmEventVisitor available in WildFly Core's AuditResourceDefinitions by attempting to create a generic ElytronEvent that can be used
> Enhanced Audit Logging - Feature parity with legacy audit logging
> -----------------------------------------------------------------
>
> Key: ELY-1778
> URL: https://issues.jboss.org/browse/ELY-1778
> Project: WildFly Elytron
> Issue Type: Feature Request
> Components: Audit
> Reporter: Justin Cook
> Priority: Major
> Fix For: 1.10.0.CR7
>
>
> This RFE for Enhanced Audit Logging in WildFly Elytron is for feature parity with legacy audit logging via:
> * Additional audit events
> * An "Audit" annotation
--
This message was sent by Atlassian Jira
(v7.13.5#713005)
5 years, 4 months