[JBoss JIRA] (WFLY-12915) Clean out unneeded provisioning boilerplate
by Brian Stansberry (Jira)
[ https://issues.redhat.com/browse/WFLY-12915?page=com.atlassian.jira.plugi... ]
Brian Stansberry resolved WFLY-12915.
-------------------------------------
Resolution: Duplicate Issue
> Clean out unneeded provisioning boilerplate
> -------------------------------------------
>
> Key: WFLY-12915
> URL: https://issues.redhat.com/browse/WFLY-12915
> Project: WildFly
> Issue Type: Task
> Components: Build System
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
> Priority: Major
>
> The current Galleon versions should allow trimming quite a bit of boilerplate from all the places where we provision servers:
> Alexey Loubyansky 5:07 PM
> I did a bit more work on this, fixed a couple of issues and just released Galleon 4.2.1.Final and WFGP 4.2.1.Final
> Alexey Loubyansky 5:07 PM
> also opened a PR to upgrade WildFly Core to these releases https://github.com/wildfly/wildfly-core/pull/4025
> 5:08 PM
> upgrading doesn't affect anything, except the bug fixes contained in those versions
> 5:10 PM
> however, for wildfly, i think we should use GAVs as feature-pack locations for feature-pack dependencies, in place of Galleon FPL
> 5:11 PM
> the benefit would be to avoid the universe resolver in maven builds
> 5:11 PM
> and also a simplified (mojo) provisioning config
> Brian Stansberry 5:14 PM
> good timing; I'm working on how to add a new f-p to wildfly (for microprofile stuff) so i should use best practices :)
> Alexey Loubyansky 5:16 PM
> by simplified provisioning config i mean that the selected block should be removed completely https://github.com/wildfly/wildfly/blob/master/build/pom.xml#L84-L97
> 5:16 PM
> the only reason it is there is to avoid resolution from the universe
> 5:17 PM
> with GAVs for dependencies, it won't be necessary anymore
> Brian Stansberry 5:17 PM
> what about <inheritConfigs>false</inheritConfigs> ?
> Alexey Loubyansky 5:18 PM
> that was there to workaround a bug which was fixed in 4.2.0.Final
> Brian Stansberry 5:18 PM
> how about
> 5:18 PM
> <included-packages>
> <name>docs.examples.configs</name>
> </included-packages>
> 5:19 PM
> assuming that's not in the top level f-p
> Alexey Loubyansky 5:19 PM
> that should definitely stay, it's not in the selected block
> 5:19 PM
> ah, then you can have that
> 5:20 PM
> then there would be a real reason to mention the transitive dependency
> 5:20 PM
> i.e. you want something from it
> Brian Stansberry 5:20 PM
> could it be declared in the top level block, even though the package is in the transitive dep?
> 5:20 PM
> i'm going off on tangents, but first i should have said...
> 5:21 PM
> Nice!
> Alexey Loubyansky 5:21 PM (EDITED)
> unless the package is installed by default, it has to be included explicitly using transitive element
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 6 months
[JBoss JIRA] (DROOLS-4903) In constraints fail to compile if negated or inside a forall pattern
by Matteo Casalino (Jira)
Matteo Casalino created DROOLS-4903:
---------------------------------------
Summary: In constraints fail to compile if negated or inside a forall pattern
Key: DROOLS-4903
URL: https://issues.redhat.com/browse/DROOLS-4903
Project: Drools
Issue Type: Bug
Components: core engine
Affects Versions: 7.31.0.Final
Reporter: Matteo Casalino
Assignee: Mario Fusco
Attachments: in-constraint-negation.tgz
It appears that the KieBuilder fails to compile the following pattern:
{noformat}
Pojo(!(x in (1,2,3)))
{noformat}
returning the following error:
{noformat}
Error Messages:
Message [id=1, kieBase=defaultKieBase, level=ERROR, path=rules.drl, line=4, column=0
text=Unable to Analyse Expression !(x in (1,2,3)):
[Error: unexpected token: ,2]
[Near : {... !(x in (1,2,3)) ....}]
{noformat}
Furthermore, as of Drools 7.29.0.Final, the following form will also fail to compile:
{noformat}
forall(Pojo(y==42, x in (1,2,3)))
{noformat}
with the following error:
{noformat}
Error Messages:
Message [id=1, kieBase=defaultKieBase, level=ERROR, path=rules.drl, line=4, column=0
text=Unable to Analyse Expression !(y==42) || !(x in (1,2,3)):
[Error: unexpected token: ,2]
[Near : {... !(y==42) || !(x in (1,2,3)) ....}]
{noformat}
The latter is likely a consequence of the negation introduced by [DROOLS-4632|https://issues.redhat.com/browse/DROOLS-4632]
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 6 months
[JBoss JIRA] (WFWIP-291) Log messages from io.smallrye.openapi don't have message ID
by Paul Ferraro (Jira)
[ https://issues.redhat.com/browse/WFWIP-291?page=com.atlassian.jira.plugin... ]
Paul Ferraro closed WFWIP-291.
------------------------------
Resolution: Rejected
WildFly has no such requirement that debug or trace messages use i18n (and thus have a message ID).
> Log messages from io.smallrye.openapi don't have message ID
> -----------------------------------------------------------
>
> Key: WFWIP-291
> URL: https://issues.redhat.com/browse/WFWIP-291
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP OpenAPI
> Reporter: Fabio Burzigotti
> Assignee: Paul Ferraro
> Priority: Major
>
> Messages logged by io.smallrye.openapi don't have assigned ID:
> {code}
> 2020-01-05 16:58:49,225 DEBUG [io.smallrye.openapi.runtime.util.SchemaFactory] (MSC service thread 1-4) Processing a single @Schema annotation.
> 2020-01-05 16:58:49,225 DEBUG [io.smallrye.openapi.runtime.scanner.OpenApiAnnotationScanner] (MSC service thread 1-4) Processing a single @Response annotation.
> 2020-01-05 16:58:49,225 DEBUG [io.smallrye.openapi.runtime.scanner.OpenApiAnnotationScanner] (MSC service thread 1-4) Processing jax-rs method: {0}
> 2020-01-05 16:58:49,225 DEBUG [io.smallrye.openapi.runtime.scanner.OpenApiDataObjectScanner] (MSC service thread 1-4) Starting processing with root: java.lang.String
> {code}
> A search in SmallRye implementation seems to show that IDs are not used even when level is WARN:
> {code}
> $ find . -name '*.*' -type f -print0 | xargs -0 grep --color -n -e 'LOG.warn'
> ./implementation/src/main/java/io/smallrye/openapi/runtime/scanner/ParameterProcessor.java:551: LOG.warnf("Matrix parameter references missing path segment: %s", segmentName);
> ./implementation/src/main/java/io/smallrye/openapi/runtime/scanner/ParameterProcessor.java:1147: LOG.warnf("Value '%s' is not a valid %s default", stringValue, primitive.name().toLowerCase());
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 6 months